From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>, Russell King <rmk+kernel@arm.linux.org.uk>
Cc: alsa-devel@alsa-project.org, Jason Cooper <jason@lakedaemon.net>,
linux-sh@vger.kernel.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH 10/14] ARM: orion: use clkdev_create()
Date: Tue, 07 Apr 2015 13:20:05 +0000 [thread overview]
Message-ID: <5523D985.60800@free-electrons.com> (raw)
In-Reply-To: <20150404001729.GA14824@lunn.ch>
Hi Andrew, Russell,
On 04/04/2015 02:17, Andrew Lunn wrote:
> On Fri, Apr 03, 2015 at 06:13:13PM +0100, Russell King wrote:
>> clkdev_create() is a shorter way to write clkdev_alloc() followed by
>> clkdev_add(). Use this instead.
>>
>> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Acked-by: Andrew Lunn <andrew@lunn.ch>
This change makes sens however what about Thomas' comment: removing
orion_clkdev_add() entirely and directly using lkdev_create() all over
the place:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-March/327294.html
Then what would be the path for this patch?
As there is a dependency on the 6th patch of this series: "clkdev: add
clkdev_create() helper" which should be merged through the clk tree, I
think the best option is that this patch would be also managed by the
clk tree maintainer (I added them in CC).
Thanks,
Gregory
>
> Andrew
>
>> ---
>> arch/arm/plat-orion/common.c | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/plat-orion/common.c b/arch/arm/plat-orion/common.c
>> index f5b00f41c4f6..2235081a04ee 100644
>> --- a/arch/arm/plat-orion/common.c
>> +++ b/arch/arm/plat-orion/common.c
>> @@ -28,11 +28,7 @@
>> void __init orion_clkdev_add(const char *con_id, const char *dev_id,
>> struct clk *clk)
>> {
>> - struct clk_lookup *cl;
>> -
>> - cl = clkdev_alloc(clk, con_id, dev_id);
>> - if (cl)
>> - clkdev_add(cl);
>> + clkdev_create(clk, con_id, "%s", dev_id);
>> }
>>
>> /* Create clkdev entries for all orion platforms except kirkwood.
>> --
>> 1.8.3.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>, Russell King <rmk+kernel@arm.linux.org.uk>
Cc: alsa-devel@alsa-project.org, Jason Cooper <jason@lakedaemon.net>,
linux-sh@vger.kernel.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH 10/14] ARM: orion: use clkdev_create()
Date: Tue, 07 Apr 2015 15:20:05 +0200 [thread overview]
Message-ID: <5523D985.60800@free-electrons.com> (raw)
In-Reply-To: <20150404001729.GA14824@lunn.ch>
Hi Andrew, Russell,
On 04/04/2015 02:17, Andrew Lunn wrote:
> On Fri, Apr 03, 2015 at 06:13:13PM +0100, Russell King wrote:
>> clkdev_create() is a shorter way to write clkdev_alloc() followed by
>> clkdev_add(). Use this instead.
>>
>> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Acked-by: Andrew Lunn <andrew@lunn.ch>
This change makes sens however what about Thomas' comment: removing
orion_clkdev_add() entirely and directly using lkdev_create() all over
the place:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-March/327294.html
Then what would be the path for this patch?
As there is a dependency on the 6th patch of this series: "clkdev: add
clkdev_create() helper" which should be merged through the clk tree, I
think the best option is that this patch would be also managed by the
clk tree maintainer (I added them in CC).
Thanks,
Gregory
>
> Andrew
>
>> ---
>> arch/arm/plat-orion/common.c | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/plat-orion/common.c b/arch/arm/plat-orion/common.c
>> index f5b00f41c4f6..2235081a04ee 100644
>> --- a/arch/arm/plat-orion/common.c
>> +++ b/arch/arm/plat-orion/common.c
>> @@ -28,11 +28,7 @@
>> void __init orion_clkdev_add(const char *con_id, const char *dev_id,
>> struct clk *clk)
>> {
>> - struct clk_lookup *cl;
>> -
>> - cl = clkdev_alloc(clk, con_id, dev_id);
>> - if (cl)
>> - clkdev_add(cl);
>> + clkdev_create(clk, con_id, "%s", dev_id);
>> }
>>
>> /* Create clkdev entries for all orion platforms except kirkwood.
>> --
>> 1.8.3.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/14] ARM: orion: use clkdev_create()
Date: Tue, 07 Apr 2015 15:20:05 +0200 [thread overview]
Message-ID: <5523D985.60800@free-electrons.com> (raw)
In-Reply-To: <20150404001729.GA14824@lunn.ch>
Hi Andrew, Russell,
On 04/04/2015 02:17, Andrew Lunn wrote:
> On Fri, Apr 03, 2015 at 06:13:13PM +0100, Russell King wrote:
>> clkdev_create() is a shorter way to write clkdev_alloc() followed by
>> clkdev_add(). Use this instead.
>>
>> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Acked-by: Andrew Lunn <andrew@lunn.ch>
This change makes sens however what about Thomas' comment: removing
orion_clkdev_add() entirely and directly using lkdev_create() all over
the place:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-March/327294.html
Then what would be the path for this patch?
As there is a dependency on the 6th patch of this series: "clkdev: add
clkdev_create() helper" which should be merged through the clk tree, I
think the best option is that this patch would be also managed by the
clk tree maintainer (I added them in CC).
Thanks,
Gregory
>
> Andrew
>
>> ---
>> arch/arm/plat-orion/common.c | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/plat-orion/common.c b/arch/arm/plat-orion/common.c
>> index f5b00f41c4f6..2235081a04ee 100644
>> --- a/arch/arm/plat-orion/common.c
>> +++ b/arch/arm/plat-orion/common.c
>> @@ -28,11 +28,7 @@
>> void __init orion_clkdev_add(const char *con_id, const char *dev_id,
>> struct clk *clk)
>> {
>> - struct clk_lookup *cl;
>> -
>> - cl = clkdev_alloc(clk, con_id, dev_id);
>> - if (cl)
>> - clkdev_add(cl);
>> + clkdev_create(clk, con_id, "%s", dev_id);
>> }
>>
>> /* Create clkdev entries for all orion platforms except kirkwood.
>> --
>> 1.8.3.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-04-07 13:20 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 17:11 [PATCH 00/14] Fix fallout from per-user struct clk patches Russell King - ARM Linux
2015-04-03 17:11 ` Russell King - ARM Linux
2015-04-03 17:11 ` Russell King - ARM Linux
2015-04-03 17:12 ` [PATCH 01/14] clk: update clk API documentation to clarify clk_round_rate() Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-07 8:47 ` [alsa-devel] " Ricard Wanderlof
2015-04-03 17:12 ` [PATCH 02/14] clkdev: drop __init from clkdev_add_table() Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 23:49 ` Tony Lindgren
2015-04-03 23:49 ` Tony Lindgren
2015-04-03 23:49 ` Tony Lindgren
2015-04-04 12:43 ` Robert Jarzmik
2015-04-04 12:43 ` Robert Jarzmik
2015-04-04 12:43 ` Robert Jarzmik
2015-04-04 12:43 ` Robert Jarzmik
2015-04-04 12:53 ` Russell King - ARM Linux
2015-04-04 12:53 ` Russell King - ARM Linux
2015-04-04 12:53 ` Russell King - ARM Linux
2015-04-06 19:04 ` Stephen Boyd
2015-04-06 19:04 ` Stephen Boyd
2015-04-06 19:04 ` Stephen Boyd
2015-04-07 10:05 ` Robert Jarzmik
2015-04-07 10:05 ` Robert Jarzmik
2015-04-07 10:05 ` Robert Jarzmik
2015-04-07 12:42 ` Russell King - ARM Linux
2015-04-07 12:42 ` Russell King - ARM Linux
2015-04-07 12:42 ` Russell King - ARM Linux
2015-04-06 5:50 ` Sekhar Nori
2015-04-06 5:51 ` Sekhar Nori
2015-04-06 5:50 ` Sekhar Nori
2015-04-06 5:50 ` Sekhar Nori
2015-04-03 17:12 ` [PATCH 04/14] clkdev: const-ify connection id to clk_add_alias() Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` [PATCH 05/14] clkdev: use clk_hw internally Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-06 20:18 ` Stephen Boyd
2015-04-06 20:18 ` Stephen Boyd
2015-04-06 20:18 ` Stephen Boyd
2015-04-03 17:12 ` [PATCH 06/14] clkdev: add clkdev_create() helper Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-06 20:19 ` Stephen Boyd
2015-04-06 20:19 ` Stephen Boyd
2015-04-06 20:19 ` Stephen Boyd
2015-04-07 12:43 ` Russell King - ARM Linux
2015-04-07 12:43 ` Russell King - ARM Linux
2015-04-07 12:43 ` Russell King - ARM Linux
2015-04-07 23:09 ` Stephen Boyd
2015-04-07 23:09 ` Stephen Boyd
2015-04-07 23:09 ` Stephen Boyd
2015-04-03 17:12 ` [PATCH 07/14] media: omap3isp: remove unused clkdev Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 21:44 ` Laurent Pinchart
2015-04-03 21:44 ` Laurent Pinchart
2015-04-03 21:44 ` Laurent Pinchart
2015-04-05 14:20 ` Russell King - ARM Linux
2015-04-05 14:20 ` Russell King - ARM Linux
2015-04-05 14:20 ` Russell King - ARM Linux
2015-04-07 9:42 ` Laurent Pinchart
2015-04-07 9:42 ` Laurent Pinchart
2015-04-07 9:42 ` Laurent Pinchart
2015-04-07 12:45 ` Russell King - ARM Linux
2015-04-07 12:45 ` Russell King - ARM Linux
2015-04-07 12:45 ` Russell King - ARM Linux
2015-04-07 14:38 ` Laurent Pinchart
2015-04-07 14:38 ` Laurent Pinchart
2015-04-07 14:38 ` Laurent Pinchart
2015-04-03 17:13 ` [PATCH 08/14] SH: use clkdev_add_table() Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` [PATCH 09/14] ARM: lpc32xx: convert to " Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` [PATCH 10/14] ARM: orion: use clkdev_create() Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-04 0:17 ` Andrew Lunn
2015-04-04 0:17 ` Andrew Lunn
2015-04-04 0:17 ` Andrew Lunn
2015-04-07 13:20 ` Gregory CLEMENT [this message]
2015-04-07 13:20 ` Gregory CLEMENT
2015-04-07 13:20 ` Gregory CLEMENT
2015-04-07 14:01 ` Russell King - ARM Linux
2015-04-07 14:01 ` Russell King - ARM Linux
2015-04-07 14:01 ` Russell King - ARM Linux
2015-04-07 14:20 ` Gregory CLEMENT
2015-04-07 14:20 ` Gregory CLEMENT
2015-04-07 14:20 ` Gregory CLEMENT
2015-04-03 17:13 ` [PATCH 11/14] ARM: omap2: " Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 23:49 ` Tony Lindgren
2015-04-03 23:49 ` Tony Lindgren
2015-04-03 23:49 ` Tony Lindgren
2015-04-03 17:13 ` [PATCH 12/14] ARM: omap2: use clkdev_add_alias() Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 23:50 ` Tony Lindgren
2015-04-03 23:50 ` Tony Lindgren
2015-04-03 23:50 ` Tony Lindgren
2015-04-03 17:13 ` [PATCH 13/14] ASoC: migor: use clkdev_create() Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` [PATCH 14/14] clk: s2mps11: " Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:16 ` [PATCH 00/14] Fix fallout from per-user struct clk patches Russell King - ARM Linux
2015-04-03 17:16 ` Russell King - ARM Linux
2015-04-03 17:16 ` Russell King - ARM Linux
2015-04-05 9:04 ` Geert Uytterhoeven
2015-04-05 9:04 ` Geert Uytterhoeven
2015-04-05 9:04 ` Geert Uytterhoeven
2015-04-05 9:04 ` Geert Uytterhoeven
2015-04-05 14:13 ` Russell King - ARM Linux
2015-04-05 14:13 ` Russell King - ARM Linux
2015-04-05 14:13 ` Russell King - ARM Linux
2015-04-05 14:13 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5523D985.60800@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@lunn.ch \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sboyd@codeaurora.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.