From: Michael Welling <mwelling@ieee.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-next@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs
Date: Thu, 21 May 2015 16:04:11 -0500 [thread overview]
Message-ID: <20150521210411.GA5406@deathray> (raw)
In-Reply-To: <20150521101857.GR21577@sirena.org.uk>
On Thu, May 21, 2015 at 11:18:57AM +0100, Mark Brown wrote:
> On Wed, May 20, 2015 at 09:07:09PM -0500, Michael Welling wrote:
>
> > My guess is that the set_cs needs to be called even when toggling as GPIO.
>
> > How should I handle this?
>
> It shouldn't be part of a set_cs() operation but rather part of the main
> transfer operation.
Okay then this patch should be reverted.
Do you want to revert the patch and apply a new one or should I provide a
patch that reverts the changes and fixes it all in one?
Sorry for this mess.
WARNING: multiple messages have this Message-ID (diff)
From: mwelling@ieee.org (Michael Welling)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs
Date: Thu, 21 May 2015 16:04:11 -0500 [thread overview]
Message-ID: <20150521210411.GA5406@deathray> (raw)
In-Reply-To: <20150521101857.GR21577@sirena.org.uk>
On Thu, May 21, 2015 at 11:18:57AM +0100, Mark Brown wrote:
> On Wed, May 20, 2015 at 09:07:09PM -0500, Michael Welling wrote:
>
> > My guess is that the set_cs needs to be called even when toggling as GPIO.
>
> > How should I handle this?
>
> It shouldn't be part of a set_cs() operation but rather part of the main
> transfer operation.
Okay then this patch should be reverted.
Do you want to revert the patch and apply a new one or should I provide a
patch that reverts the changes and fixes it all in one?
Sorry for this mess.
next prev parent reply other threads:[~2015-05-21 21:04 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 17:38 [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs Michael Welling
2015-05-12 17:38 ` Michael Welling
2015-05-12 18:57 ` Nishanth Menon
2015-05-12 18:57 ` Nishanth Menon
2015-05-12 18:57 ` Nishanth Menon
2015-05-12 19:19 ` Mark Brown
2015-05-12 19:19 ` Mark Brown
2015-05-12 19:19 ` Mark Brown
2015-05-12 19:21 ` Nishanth Menon
2015-05-12 19:21 ` Nishanth Menon
2015-05-12 19:21 ` Nishanth Menon
2015-05-12 19:17 ` Mark Brown
2015-05-12 19:17 ` Mark Brown
2015-05-21 2:07 ` Michael Welling
2015-05-21 2:07 ` Michael Welling
2015-05-21 2:07 ` Michael Welling
2015-05-21 10:18 ` Mark Brown
2015-05-21 10:18 ` Mark Brown
2015-05-21 21:04 ` Michael Welling [this message]
2015-05-21 21:04 ` Michael Welling
2015-05-21 21:16 ` Mark Brown
2015-05-21 21:16 ` Mark Brown
2015-05-21 23:48 ` Michael Welling
2015-05-21 23:48 ` Michael Welling
2015-05-22 12:25 ` Mark Brown
2015-05-22 12:25 ` Mark Brown
2015-05-22 12:25 ` Mark Brown
2015-05-22 15:31 ` Michael Welling
2015-05-22 15:31 ` Michael Welling
2015-05-24 2:13 ` [PATCH 0/4] spi: omap2-mcspi: Fixes for recent updates Michael Welling
2015-05-24 2:13 ` Michael Welling
2015-05-24 2:13 ` [PATCH 1/4] spi: omap2-mcspi: Remove unnecessary delay Michael Welling
2015-05-24 2:13 ` Michael Welling
2015-05-24 2:13 ` [PATCH 2/4] spi: omap2-mcspi: Fix set_cs function for active high Michael Welling
2015-05-24 2:13 ` Michael Welling
2015-05-24 2:13 ` [PATCH 3/4] spi: omap2-mcspi: Fix GPIO chip select support Michael Welling
2015-05-24 2:13 ` Michael Welling
2015-05-24 2:13 ` [PATCH 4/4] spi: omap2-mcspi: Handle error on gpio_request Michael Welling
2015-05-24 2:13 ` Michael Welling
2015-05-24 8:13 ` Nicholas Mc Guire
2015-05-24 8:13 ` Nicholas Mc Guire
2015-05-24 16:52 ` Michael Welling
2015-05-24 16:52 ` Michael Welling
2015-05-25 12:00 ` [PATCH 0/4] spi: omap2-mcspi: Fixes for recent updates Mark Brown
2015-05-25 12:00 ` Mark Brown
2015-05-25 12:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521210411.GA5406@deathray \
--to=mwelling@ieee.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.