From: Arnd Bergmann <arnd@arndb.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
tglx@linutronix.de, ross.zwisler@linux.intel.com,
akpm@linux-foundation.org, jgross@suse.com, x86@kernel.org,
toshi.kani@hp.com, linux-nvdimm@lists.01.org, mcgrof@suse.com,
konrad.wilk@oracle.com, linux-kernel@vger.kernel.org,
stefan.bader@canonical.com, luto@amacapital.net,
linux-mm@kvack.org, geert@linux-m68k.org, hmh@hmh.eng.br,
tj@kernel.org, hch@lst.de
Subject: Re: [PATCH v2 2/4] devm: fix ioremap_cache() usage
Date: Sat, 30 May 2015 22:52:19 +0200 [thread overview]
Message-ID: <201505302252.19647.arnd@arndb.de> (raw)
In-Reply-To: <20150530185929.32590.22873.stgit@dwillia2-desk3.amr.corp.intel.com>
On Saturday 30 May 2015, Dan Williams wrote:
> @@ -154,7 +148,7 @@ void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res)
> }
>
> if (res->flags & IORESOURCE_CACHEABLE)
> - dest_ptr = devm_ioremap(dev, res->start, size);
> + dest_ptr = devm_ioremap_cache(dev, res->start, size);
> else
> dest_ptr = devm_ioremap_nocache(dev, res->start, size);
I think the existing uses of IORESOURCE_CACHEABLE are mostly bugs, so changing
the behavior here may cause more problems than it solves.
Arnd
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
tglx@linutronix.de, ross.zwisler@linux.intel.com,
akpm@linux-foundation.org, jgross@suse.com, x86@kernel.org,
toshi.kani@hp.com, linux-nvdimm@ml01.01.org, mcgrof@suse.com,
konrad.wilk@oracle.com, linux-kernel@vger.kernel.org,
stefan.bader@canonical.com, luto@amacapital.net,
linux-mm@kvack.org, geert@linux-m68k.org, hmh@hmh.eng.br,
tj@kernel.org, hch@lst.de
Subject: Re: [PATCH v2 2/4] devm: fix ioremap_cache() usage
Date: Sat, 30 May 2015 22:52:19 +0200 [thread overview]
Message-ID: <201505302252.19647.arnd@arndb.de> (raw)
In-Reply-To: <20150530185929.32590.22873.stgit@dwillia2-desk3.amr.corp.intel.com>
On Saturday 30 May 2015, Dan Williams wrote:
> @@ -154,7 +148,7 @@ void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res)
> }
>
> if (res->flags & IORESOURCE_CACHEABLE)
> - dest_ptr = devm_ioremap(dev, res->start, size);
> + dest_ptr = devm_ioremap_cache(dev, res->start, size);
> else
> dest_ptr = devm_ioremap_nocache(dev, res->start, size);
I think the existing uses of IORESOURCE_CACHEABLE are mostly bugs, so changing
the behavior here may cause more problems than it solves.
Arnd
next prev parent reply other threads:[~2015-05-30 20:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 18:59 [PATCH v2 0/4] pmem api, generic ioremap_cache, and memremap Dan Williams
2015-05-30 18:59 ` Dan Williams
2015-05-30 18:59 ` [PATCH v2 1/4] arch/*/asm/io.h: add ioremap_cache() to all architectures Dan Williams
2015-05-30 18:59 ` Dan Williams
2015-06-01 22:36 ` Toshi Kani
2015-06-01 22:36 ` Toshi Kani
2015-06-02 8:20 ` Arnd Bergmann
2015-06-02 8:20 ` Arnd Bergmann
2015-06-02 8:38 ` Geert Uytterhoeven
2015-06-02 8:38 ` Geert Uytterhoeven
2015-05-30 18:59 ` [PATCH v2 2/4] devm: fix ioremap_cache() usage Dan Williams
2015-05-30 18:59 ` Dan Williams
2015-05-30 20:52 ` Arnd Bergmann [this message]
2015-05-30 20:52 ` Arnd Bergmann
2015-05-30 21:16 ` Dan Williams
2015-05-30 21:16 ` Dan Williams
2015-06-01 14:26 ` Arnd Bergmann
2015-06-01 14:26 ` Arnd Bergmann
2015-05-30 18:59 ` [PATCH v2 3/4] arch: introduce memremap() Dan Williams
2015-05-30 18:59 ` Dan Williams
2015-05-30 21:00 ` Arnd Bergmann
2015-05-30 21:00 ` Arnd Bergmann
2015-05-30 21:39 ` Dan Williams
2015-05-30 21:39 ` Dan Williams
2015-06-01 14:29 ` Arnd Bergmann
2015-06-01 14:29 ` Arnd Bergmann
2015-05-30 18:59 ` [PATCH v2 4/4] arch, x86: cache management apis for persistent memory Dan Williams
2015-05-30 18:59 ` Dan Williams
2015-06-01 9:19 ` Paul Bolle
2015-06-01 9:19 ` Paul Bolle
2015-06-01 11:39 ` Boaz Harrosh
2015-06-01 11:39 ` Boaz Harrosh
2015-06-01 11:44 ` Boaz Harrosh
2015-06-01 11:44 ` Boaz Harrosh
2015-06-01 16:07 ` Dan Williams
2015-06-01 16:07 ` Dan Williams
2015-06-01 16:22 ` Dan Williams
2015-06-01 16:22 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201505302252.19647.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=luto@amacapital.net \
--cc=mcgrof@suse.com \
--cc=mingo@redhat.com \
--cc=ross.zwisler@linux.intel.com \
--cc=stefan.bader@canonical.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.