From: Dan Williams <dan.j.williams@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Juergen Gross <jgross@suse.com>, X86 ML <x86@kernel.org>,
"Kani, Toshimitsu" <toshi.kani@hp.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Luis Rodriguez <mcgrof@suse.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stefan Bader <stefan.bader@canonical.com>,
Andy Lutomirski <luto@amacapital.net>,
linux-mm@kvack.org, geert@linux-m68k.org,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Tejun Heo <tj@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 2/4] devm: fix ioremap_cache() usage
Date: Sat, 30 May 2015 14:16:28 -0700 [thread overview]
Message-ID: <CAPcyv4g30QqO2+vmhfFi6Mw3pku=BkEmvUbzxMme4nm8SkHyrQ@mail.gmail.com> (raw)
In-Reply-To: <201505302252.19647.arnd@arndb.de>
On Sat, May 30, 2015 at 1:52 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Saturday 30 May 2015, Dan Williams wrote:
>> @@ -154,7 +148,7 @@ void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res)
>> }
>>
>> if (res->flags & IORESOURCE_CACHEABLE)
>> - dest_ptr = devm_ioremap(dev, res->start, size);
>> + dest_ptr = devm_ioremap_cache(dev, res->start, size);
>> else
>> dest_ptr = devm_ioremap_nocache(dev, res->start, size);
>
> I think the existing uses of IORESOURCE_CACHEABLE are mostly bugs, so changing
> the behavior here may cause more problems than it solves.
>
Ok, but that effectively makes devm_ioremap_resource() unusable for
the cached case. How about introducing devm_ioremap_cache_resource(),
and cleaning up devm_ioremap_resource() to stop pretending that it is
honoring the memory type of the resource?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Juergen Gross <jgross@suse.com>, X86 ML <x86@kernel.org>,
"Kani, Toshimitsu" <toshi.kani@hp.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
Luis Rodriguez <mcgrof@suse.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stefan Bader <stefan.bader@canonical.com>,
Andy Lutomirski <luto@amacapital.net>,
linux-mm@kvack.org, geert@linux-m68k.org,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Tejun Heo <tj@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 2/4] devm: fix ioremap_cache() usage
Date: Sat, 30 May 2015 14:16:28 -0700 [thread overview]
Message-ID: <CAPcyv4g30QqO2+vmhfFi6Mw3pku=BkEmvUbzxMme4nm8SkHyrQ@mail.gmail.com> (raw)
In-Reply-To: <201505302252.19647.arnd@arndb.de>
On Sat, May 30, 2015 at 1:52 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Saturday 30 May 2015, Dan Williams wrote:
>> @@ -154,7 +148,7 @@ void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res)
>> }
>>
>> if (res->flags & IORESOURCE_CACHEABLE)
>> - dest_ptr = devm_ioremap(dev, res->start, size);
>> + dest_ptr = devm_ioremap_cache(dev, res->start, size);
>> else
>> dest_ptr = devm_ioremap_nocache(dev, res->start, size);
>
> I think the existing uses of IORESOURCE_CACHEABLE are mostly bugs, so changing
> the behavior here may cause more problems than it solves.
>
Ok, but that effectively makes devm_ioremap_resource() unusable for
the cached case. How about introducing devm_ioremap_cache_resource(),
and cleaning up devm_ioremap_resource() to stop pretending that it is
honoring the memory type of the resource?
next prev parent reply other threads:[~2015-05-30 21:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 18:59 [PATCH v2 0/4] pmem api, generic ioremap_cache, and memremap Dan Williams
2015-05-30 18:59 ` Dan Williams
2015-05-30 18:59 ` [PATCH v2 1/4] arch/*/asm/io.h: add ioremap_cache() to all architectures Dan Williams
2015-05-30 18:59 ` Dan Williams
2015-06-01 22:36 ` Toshi Kani
2015-06-01 22:36 ` Toshi Kani
2015-06-02 8:20 ` Arnd Bergmann
2015-06-02 8:20 ` Arnd Bergmann
2015-06-02 8:38 ` Geert Uytterhoeven
2015-06-02 8:38 ` Geert Uytterhoeven
2015-05-30 18:59 ` [PATCH v2 2/4] devm: fix ioremap_cache() usage Dan Williams
2015-05-30 18:59 ` Dan Williams
2015-05-30 20:52 ` Arnd Bergmann
2015-05-30 20:52 ` Arnd Bergmann
2015-05-30 21:16 ` Dan Williams [this message]
2015-05-30 21:16 ` Dan Williams
2015-06-01 14:26 ` Arnd Bergmann
2015-06-01 14:26 ` Arnd Bergmann
2015-05-30 18:59 ` [PATCH v2 3/4] arch: introduce memremap() Dan Williams
2015-05-30 18:59 ` Dan Williams
2015-05-30 21:00 ` Arnd Bergmann
2015-05-30 21:00 ` Arnd Bergmann
2015-05-30 21:39 ` Dan Williams
2015-05-30 21:39 ` Dan Williams
2015-06-01 14:29 ` Arnd Bergmann
2015-06-01 14:29 ` Arnd Bergmann
2015-05-30 18:59 ` [PATCH v2 4/4] arch, x86: cache management apis for persistent memory Dan Williams
2015-05-30 18:59 ` Dan Williams
2015-06-01 9:19 ` Paul Bolle
2015-06-01 9:19 ` Paul Bolle
2015-06-01 11:39 ` Boaz Harrosh
2015-06-01 11:39 ` Boaz Harrosh
2015-06-01 11:44 ` Boaz Harrosh
2015-06-01 11:44 ` Boaz Harrosh
2015-06-01 16:07 ` Dan Williams
2015-06-01 16:07 ` Dan Williams
2015-06-01 16:22 ` Dan Williams
2015-06-01 16:22 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4g30QqO2+vmhfFi6Mw3pku=BkEmvUbzxMme4nm8SkHyrQ@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=luto@amacapital.net \
--cc=mcgrof@suse.com \
--cc=mingo@redhat.com \
--cc=ross.zwisler@linux.intel.com \
--cc=stefan.bader@canonical.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.