Re: Audio crackles with 4.1-rc1

From: Jonathan McDowell <noodles@earth.li>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Mihai Donțu" <mihai.dontu@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: Audio crackles with 4.1-rc1
Date: Sun, 14 Jun 2015 13:24:20 +0100	[thread overview]
Message-ID: <20150614122420.GT28070@earth.li> (raw)
In-Reply-To: <s5hk2v9hv5v.wl-tiwai@suse.de>

On Fri, Jun 12, 2015 at 04:13:16PM +0200, Takashi Iwai wrote:
> At Fri, 12 Jun 2015 12:09:55 +0200,
> Takashi Iwai wrote:
> > At Fri, 12 Jun 2015 12:45:23 +0300,
> > Mihai Donțu wrote:
> > > Nice shot! It appears to work. :-) No clicks, no static.
> > 
> > Good to hear!
> > 
> > > I had to apply it by hand over 4.1-rc7, because the first two arrays
> > > look different in both it and -master. Anyway, I will play with it some
> > > more today see if anything else is broken.
> > 
> > While we are at it: could you try to enable codec->power_save_node in
> > patch_alc269() (while keeping the new patch)?
> > 
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -5671,8 +5671,7 @@ static int patch_alc269(struct hda_codec *codec)
> >  
> >  	spec = codec->spec;
> >  	spec->gen.shared_mic_vref_pin = 0x18;
> > -	if (codec->core.vendor_id != 0x10ec0292)
> > -		codec->power_save_node = 1;
> > +	codec->power_save_node = 1;
> >  
> >  #ifdef CONFIG_PM
> >  	codec->patch_ops.suspend = alc269_suspend;
> 
> For your convenience, below is the combined patch for 4.1.
> 
> Jonathan, could you also try this patch and see whether you still get
> the noise?

Applying the combined patch to 4.1-rc7 I'm not getting any noise on the
transition from suspended to active.

J.

-- 
   101 things you can't have too   |  .''`.  Debian GNU/Linux Developer
    much of : 47 - More coffee.    | : :' :  Happy to accept PGP signed
                                   | `. `'   or encrypted mail - RSA
                                   |   `-    key on the keyservers.