From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
liam.r.girdwood@linux.intel.com, patches.audio@intel.com, "Kp,
Jeeja" <jeeja.kp@intel.com>,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH v2 1/6] ASoC: Intel: Add helper to poll register for DSP status
Date: Wed, 8 Jul 2015 19:36:21 +0100 [thread overview]
Message-ID: <20150708183621.GZ11162@sirena.org.uk> (raw)
In-Reply-To: <1435919647-14049-2-git-send-email-vinod.koul@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 325 bytes --]
On Fri, Jul 03, 2015 at 04:04:02PM +0530, Vinod Koul wrote:
> + for (time = 0; time < timeout; time++) {
> + if ((sst_dsp_shim_read_unlocked(ctx, offset) & mask) == expected_value)
> + break;
> +
> + mdelay(1);
> + }
mdelay() not msleep()? If we're waiting for multiple miliseconds that
could be lots of busy waiting.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-07-08 18:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 10:34 [PATCH v2 0/6] ASoC: Intel: Sklyake - add IPC routines Vinod Koul
2015-07-03 10:34 ` [PATCH v2 1/6] ASoC: Intel: Add helper to poll register for DSP status Vinod Koul
2015-07-08 18:36 ` Mark Brown [this message]
2015-07-09 4:27 ` Vinod Koul
2015-07-09 10:48 ` Mark Brown
2015-07-09 10:53 ` Vinod Koul
2015-07-03 10:34 ` [PATCH v2 2/6] ASoC: Intel: Define SKL ADSP IPC and general purpose registers Vinod Koul
2015-07-03 10:34 ` [PATCH v2 3/6] ASoC: Intel: Reorganize the common dsp structure Vinod Koul
2015-07-08 18:38 ` Mark Brown
2015-07-09 4:32 ` Vinod Koul
2015-07-03 10:34 ` [PATCH v2 4/6] ASoC: Intel: Add helper to update register bits with attr RWC Vinod Koul
2015-07-08 18:47 ` Mark Brown
2015-07-09 4:44 ` Vinod Koul
2015-07-03 10:34 ` [PATCH v2 5/6] ASoC: Intel: Add Skylake IPC library Vinod Koul
2015-07-08 18:46 ` Mark Brown
2015-07-09 5:26 ` Vinod Koul
2015-07-09 13:18 ` Vinod Koul
2015-07-03 10:34 ` [PATCH v2 6/6] ASoC: Intel: Add DSP init and boot up functionality for SKL Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708183621.GZ11162@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.