Re: [PATCH v2 3/6] ASoC: Intel: Reorganize the common dsp structure

From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>, liam.r.girdwood@linux.intel.com
Cc: tiwai@suse.de, patches.audio@intel.com,
	alsa-devel@alsa-project.org,
	"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH v2 3/6] ASoC: Intel: Reorganize the common dsp structure
Date: Thu, 9 Jul 2015 10:02:39 +0530	[thread overview]
Message-ID: <20150709043239.GG836@localhost> (raw)
In-Reply-To: <20150708183833.GA11162@sirena.org.uk>

[-- Attachment #1.1: Type: text/plain, Size: 970 bytes --]

On Wed, Jul 08, 2015 at 07:38:33PM +0100, Mark Brown wrote:
> On Fri, Jul 03, 2015 at 04:04:04PM +0530, Vinod Koul wrote:
> > From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
> > 
> > We will add SKL platform data. So organizing common and platform
> > specific data helps.
> 
> >  struct sst_dsp {
> >  
> > +	/* Shared for all platforms */
> > +
> >  	/* runtime */
> >  	struct sst_dsp_device *sst_dev;
> >  	spinlock_t spinlock;	/* IPC locking */
> > @@ -268,10 +270,6 @@ struct sst_dsp {
> >  	int irq;
> >  	u32 id;
> >  
> > -	/* list of free and used ADSP memory blocks */
> > -	struct list_head used_block_list;
> > -	struct list_head free_block_list;
> > -
> 
> Perhaps a union might start to make sense at some point?
Initially we did start with a union but Liam didn't like another indirection.
Anyway since not a bunch a members are getting added here, this should be
okay

Liam you want to add here...

-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]