Re: [PATCH v2 6/9] ASoC: Intel: Skylake: Initialize and load DSP controls

From: Vinod Koul <vinod.koul@intel.com>
To: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Cc: patches.audio@intel.com, Jeeja KP <jeeja.kp@intel.com>,
	alsa-devel@alsa-project.org, broonie@kernel.org,
	"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH v2 6/9] ASoC: Intel: Skylake: Initialize and load DSP controls
Date: Fri, 18 Sep 2015 20:41:31 +0530	[thread overview]
Message-ID: <20150918151131.GE19522@localhost> (raw)
In-Reply-To: <1442570334.7634.39.camel@loki>

On Fri, Sep 18, 2015 at 10:58:54AM +0100, Liam Girdwood wrote:

> > +static int skl_be_hw_params(struct snd_pcm_substream *substream,
> > +				struct snd_pcm_hw_params *params,
> > +				struct snd_soc_dai *dai)
> > +{
> > +	struct skl_pipe_params p_params = {0};
> > +
> > +	dev_dbg(dai->dev, "%s: %s\n", __func__, dai->name);
> > +
> 
> Seeing a lot of dev_dbg(__func__) in this series that really are just
> tracing. Probably best to trace the calls properly or remove if it's
> just development debugging.

Yes tracing will be added later, I will remove bunch of these but keep few
to help debug as we are still adding features :)

-- 
~Vinod