Re: [PATCH v2 6/9] ASoC: Intel: Skylake: Initialize and load DSP controls

From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	patches.audio@intel.com, alsa-devel@alsa-project.org,
	"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
	Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH v2 6/9] ASoC: Intel: Skylake: Initialize and load DSP controls
Date: Mon, 21 Sep 2015 08:56:10 +0530	[thread overview]
Message-ID: <20150921032610.GE2381@localhost> (raw)
In-Reply-To: <20150919162620.GF30445@sirena.org.uk>

[-- Attachment #1.1: Type: text/plain, Size: 820 bytes --]

On Sat, Sep 19, 2015 at 09:26:20AM -0700, Mark Brown wrote:
> On Fri, Sep 18, 2015 at 10:58:54AM +0100, Liam Girdwood wrote:
> > On Mon, 2015-08-17 at 22:56 +0530, Vinod Koul wrote:
> 
> > > +				struct snd_soc_dai *dai)
> > > +{
> > > +	struct skl_pipe_params p_params = {0};
> > > +
> > > +	dev_dbg(dai->dev, "%s: %s\n", __func__, dai->name);
> 
> > Seeing a lot of dev_dbg(__func__) in this series that really are just
> > tracing. Probably best to trace the calls properly or remove if it's
> > just development debugging.
> 
> It's all through the whole Intel DSP codebase.  :(

Yes the code is getting features added so we thought of keeping this for a
while, but I agree this doesn't help much, we are adding tracing anyway so
lets add that. Will remove most of these...

Thanks
-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]