Re: [PATCH v2 4/9] ASoC: Intel: Skylake: Add FE and BE hw_params handling

From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
	alsa-devel@alsa-project.org,
	"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
	Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH v2 4/9] ASoC: Intel: Skylake: Add FE and BE hw_params handling
Date: Mon, 21 Sep 2015 08:43:05 +0530	[thread overview]
Message-ID: <20150921031305.GC2381@localhost> (raw)
In-Reply-To: <20150919162210.GE30445@sirena.org.uk>


[-- Attachment #1.1: Type: text/plain, Size: 1171 bytes --]

On Sat, Sep 19, 2015 at 09:22:10AM -0700, Mark Brown wrote:
> On Mon, Aug 17, 2015 at 10:56:39PM +0530, Vinod Koul wrote:
> 
> > +/* Run/Stop the FE pipeline */
> > +int skl_tplg_set_fe_pipeline_state(struct snd_soc_dai *dai, bool start,
> > +								int stream)
> > +{
> > +	struct skl *skl = get_skl_ctx(dai->dev);
> > +	struct skl_sst *ctx = skl->skl_sst;
> > +	struct skl_module_cfg *mconfig = NULL;
> > +
> > +	dev_dbg(dai->dev, "%s: enter, dai-name=%s dir=%d\n", __func__, dai->name, stream);
> > +
> > +	mconfig = skl_tplg_fe_get_cpr_module(dai, stream);
> > +	if (mconfig != NULL) {
> > +		if (start)
> > +			return skl_run_pipe(ctx, mconfig->pipe);
> > +		else
> > +			return skl_stop_pipe(ctx, mconfig->pipe);
> > +	}
> > +
> > +	return 0;
> > +}
> 
> Another one of these wrappers with basically no shared code :(  
Yes this is wrapper over pipeline start and stop. This function is invoked
from the PCM trigger code so we though providing a wrapper makes it look
better. I will remove this and invoke skl_run_pipe and skl_stop_pipe from
PCM trigger now

Will check if we can remove other wrappers as well

Thanks
-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]