From: Sascha Hauer <s.hauer@pengutronix.de>
To: Punit Agrawal <punit.agrawal@arm.com>
Cc: linux-pm@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org, mark.rutland@arm.com,
robh+dt@kernel.org
Subject: Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support
Date: Wed, 30 Sep 2015 12:37:04 +0200 [thread overview]
Message-ID: <20150930103704.GA7858@pengutronix.de> (raw)
In-Reply-To: <9hhpp105jw1.fsf@e105922-lin.cambridge.arm.com>
Hi Punit,
On Wed, Sep 30, 2015 at 10:36:14AM +0100, Punit Agrawal wrote:
> Hi Sascha,
>
> Re-posting a comment from v7. Perhaps you missed it...
Uh, sorry. In fact I didn't miss it and I thought I have answered it.
Appearantly I haven't.
> > + struct mtk_thermal *mt = bank->mt;
> > + int temp, i, max;
> > + u32 raw;
> > +
> > + temp = max = INT_MIN;
> > +
> > + for (i = 0; i < bank_data[bank->id].num_sensors; i++) {
> > + raw = readl(mt->thermal_base + sensing_points[i].msr);
> > +
> > + temp = raw_to_mcelsius(mt, raw);
> > +
> > + /*
> > + * The first read of a sensor often contains very high bogus
> > + * temperature value. Filter these out so that the system does
> > + * not immediately shut down.
> > + */
> > + if (temp > 200000)
> > + temp = 0;
> > +
>
> If the bogus value is only the first time the sensor is read, instead of
> filtering here, you could call mtk_thermal_bank_temperature at probe
> time when you are initialising the banks and ignore the returned value.
It seems that after initialization the hardware needs some time to
settle before correct values can be read. Doing what you suggest would
mean we have to delay the boot by several 100ms. I'd rather not do that.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] thermal: Add Mediatek thermal controller support
Date: Wed, 30 Sep 2015 12:37:04 +0200 [thread overview]
Message-ID: <20150930103704.GA7858@pengutronix.de> (raw)
In-Reply-To: <9hhpp105jw1.fsf@e105922-lin.cambridge.arm.com>
Hi Punit,
On Wed, Sep 30, 2015 at 10:36:14AM +0100, Punit Agrawal wrote:
> Hi Sascha,
>
> Re-posting a comment from v7. Perhaps you missed it...
Uh, sorry. In fact I didn't miss it and I thought I have answered it.
Appearantly I haven't.
> > + struct mtk_thermal *mt = bank->mt;
> > + int temp, i, max;
> > + u32 raw;
> > +
> > + temp = max = INT_MIN;
> > +
> > + for (i = 0; i < bank_data[bank->id].num_sensors; i++) {
> > + raw = readl(mt->thermal_base + sensing_points[i].msr);
> > +
> > + temp = raw_to_mcelsius(mt, raw);
> > +
> > + /*
> > + * The first read of a sensor often contains very high bogus
> > + * temperature value. Filter these out so that the system does
> > + * not immediately shut down.
> > + */
> > + if (temp > 200000)
> > + temp = 0;
> > +
>
> If the bogus value is only the first time the sensor is read, instead of
> filtering here, you could call mtk_thermal_bank_temperature at probe
> time when you are initialising the banks and ignore the returned value.
It seems that after initialization the hardware needs some time to
settle before correct values can be read. Doing what you suggest would
mean we have to delay the boot by several 100ms. I'd rather not do that.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2015-09-30 10:37 UTC|newest]
Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 13:37 [PATCH v9] Add Mediatek thermal support Sascha Hauer
2015-09-23 13:37 ` Sascha Hauer
2015-09-23 13:37 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer
2015-09-23 13:37 ` Sascha Hauer
2015-09-23 13:37 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer
2015-09-23 13:37 ` Sascha Hauer
2015-09-23 18:31 ` Vladimir Zapolskiy
2015-09-23 18:31 ` Vladimir Zapolskiy
2015-09-23 18:31 ` Vladimir Zapolskiy
2015-09-30 6:14 ` Sascha Hauer
2015-09-30 6:14 ` Sascha Hauer
2015-09-29 23:04 ` Eduardo Valentin
2015-09-29 23:04 ` Eduardo Valentin
2015-09-29 23:04 ` Eduardo Valentin
2015-09-30 6:13 ` Sascha Hauer
2015-09-30 6:13 ` Sascha Hauer
2015-09-30 9:36 ` Punit Agrawal
2015-09-30 9:36 ` Punit Agrawal
2015-09-30 9:36 ` Punit Agrawal
2015-09-30 10:37 ` Sascha Hauer [this message]
2015-09-30 10:37 ` Sascha Hauer
2015-09-30 11:07 ` Punit Agrawal
2015-09-30 11:07 ` Punit Agrawal
2015-09-23 13:37 ` [PATCH 3/3] ARM64: dts: mt8173: Add thermal/auxadc device nodes Sascha Hauer
2015-09-23 13:37 ` Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2015-11-30 11:42 [PATCH v12] Add Mediatek thermal support Sascha Hauer
2015-11-30 11:42 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer
2015-11-30 11:42 ` Sascha Hauer
2015-12-17 19:33 ` Eduardo Valentin
2015-12-17 19:33 ` Eduardo Valentin
2016-01-04 14:19 ` Sascha Hauer
2016-01-04 14:19 ` Sascha Hauer
2016-01-19 7:29 ` Sascha Hauer
2016-01-19 7:29 ` Sascha Hauer
2016-02-01 2:54 ` Eddie Huang
2016-02-01 2:54 ` Eddie Huang
2016-02-01 2:54 ` Eddie Huang
2016-02-15 2:11 ` Daniel Kurtz
2016-02-15 2:11 ` Daniel Kurtz
2016-02-15 2:11 ` Daniel Kurtz
2016-02-15 2:14 ` Daniel Kurtz
2016-02-15 2:14 ` Daniel Kurtz
2016-02-15 2:14 ` Daniel Kurtz
2016-02-17 17:05 ` Matthias Brugger
2016-02-17 17:05 ` Matthias Brugger
2016-02-17 17:05 ` Matthias Brugger
2016-02-18 10:56 ` Sascha Hauer
2016-02-18 10:56 ` Sascha Hauer
2016-02-18 10:56 ` Sascha Hauer
2016-02-18 14:28 ` Javi Merino
2016-02-18 14:28 ` Javi Merino
2016-02-18 14:28 ` Javi Merino
2016-02-18 15:15 ` Eduardo Valentin
2016-02-18 15:15 ` Eduardo Valentin
2016-02-18 15:15 ` Eduardo Valentin
2016-02-19 7:21 ` Sascha Hauer
2016-02-19 7:21 ` Sascha Hauer
2016-02-19 7:21 ` Sascha Hauer
2015-12-21 4:07 ` Daniel Kurtz
2015-12-21 4:07 ` Daniel Kurtz
2015-12-21 4:07 ` Daniel Kurtz
2016-01-04 14:31 ` Sascha Hauer
2016-01-04 14:31 ` Sascha Hauer
2016-01-04 14:31 ` Sascha Hauer
2016-01-04 15:43 ` Daniel Kurtz
2016-01-04 15:43 ` Daniel Kurtz
2016-01-04 15:43 ` Daniel Kurtz
2015-11-18 8:24 [PATCH v11] Add Mediatek thermal support Sascha Hauer
2015-11-18 8:24 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer
2015-11-18 8:24 ` Sascha Hauer
2015-11-24 6:06 ` dawei chien
2015-11-24 6:06 ` dawei chien
2015-11-24 6:06 ` dawei chien
2015-11-24 7:53 ` Sascha Hauer
2015-11-24 7:53 ` Sascha Hauer
2015-11-09 10:13 [PATCH v10] Add Mediatek thermal support Sascha Hauer
2015-11-09 10:13 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer
2015-11-09 10:13 ` Sascha Hauer
2015-11-09 10:13 ` Sascha Hauer
2015-11-09 14:39 ` Andy Shevchenko
2015-11-09 14:39 ` Andy Shevchenko
2015-11-18 8:11 ` Sascha Hauer
2015-11-18 8:11 ` Sascha Hauer
2015-11-18 8:11 ` Sascha Hauer
2015-11-10 12:05 ` Javi Merino
2015-11-10 12:05 ` Javi Merino
2015-11-10 18:26 ` Eduardo Valentin
2015-11-10 18:26 ` Eduardo Valentin
2015-11-11 7:27 ` Sascha Hauer
2015-11-11 7:27 ` Sascha Hauer
2015-11-11 9:40 ` Javi Merino
2015-11-11 9:40 ` Javi Merino
2015-11-11 9:40 ` Javi Merino
2015-11-13 10:09 ` Sascha Hauer
2015-11-13 10:09 ` Sascha Hauer
2015-11-13 11:26 ` Javi Merino
2015-11-13 11:26 ` Javi Merino
2015-11-18 8:18 ` Sascha Hauer
2015-11-18 8:18 ` Sascha Hauer
2015-08-31 7:34 [PATCH v8] Add Mediatek thermal support Sascha Hauer
2015-08-31 7:34 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer
2015-08-31 7:34 ` Sascha Hauer
2015-08-31 7:34 ` Sascha Hauer
2015-09-14 7:32 ` Daniel Kurtz
2015-09-14 7:32 ` Daniel Kurtz
2015-09-14 7:32 ` Daniel Kurtz
2015-09-22 7:30 ` Daniel Kurtz
2015-09-22 7:30 ` Daniel Kurtz
2015-09-22 7:30 ` Daniel Kurtz
2015-09-22 8:30 ` Sascha Hauer
2015-09-22 8:30 ` Sascha Hauer
2015-09-22 8:30 ` Sascha Hauer
2015-08-27 6:41 [PATCH v7] Add Mediatek thermal support Sascha Hauer
2015-08-27 6:41 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer
2015-08-27 11:50 ` Punit Agrawal
2015-08-26 13:58 [PATCH v6] Add Mediatek thermal support Sascha Hauer
2015-08-26 13:58 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer
2015-08-20 8:05 [PATCH v5] Add Mediatek thermal support Sascha Hauer
2015-08-20 8:06 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer
2015-08-20 22:20 ` Eduardo Valentin
2015-08-20 22:29 ` Daniel Lezcano
2015-08-21 5:06 ` Sascha Hauer
2015-08-20 23:12 ` Daniel Lezcano
2015-08-26 13:54 ` Sascha Hauer
2015-08-26 14:02 ` Daniel Lezcano
2015-08-25 17:41 ` Daniel Kurtz
2015-08-07 13:55 [PATCH v4] Add Mediatek thermal support Sascha Hauer
2015-08-07 13:55 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer
2015-08-11 7:03 ` Daniel Kurtz
2015-08-20 7:57 ` Sascha Hauer
2015-08-05 12:25 [PATCH v3] Add Mediatek thermal support Sascha Hauer
2015-08-05 12:25 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer
2015-08-05 18:02 ` Daniel Kurtz
2015-08-06 8:10 ` Sascha Hauer
2015-07-21 7:59 [PATCH v2] Add Mediatek thermal support Sascha Hauer
2015-07-21 7:59 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer
2015-07-21 7:59 ` Sascha Hauer
2015-07-21 15:13 ` Daniel Kurtz
2015-07-21 15:13 ` Daniel Kurtz
2015-07-21 15:13 ` Daniel Kurtz
2015-08-05 10:20 ` Sascha Hauer
2015-08-05 10:20 ` Sascha Hauer
2015-08-05 10:20 ` Sascha Hauer
2015-07-13 10:34 [PATCH] thermal: Add Mediatek thermal support Sascha Hauer
2015-07-13 10:34 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer
2015-07-13 10:34 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930103704.GA7858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=punit.agrawal@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.