From: Daniel Kurtz <djkurtz@chromium.org> To: Eddie Huang <eddie.huang@mediatek.com> Cc: Eduardo Valentin <edubezval@gmail.com>, Sascha Hauer <s.hauer@pengutronix.de>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mediatek@lists.infradead.org" <linux-mediatek@lists.infradead.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>, Matthias Brugger <matthias.bgg@gmail.com>, Zhang Rui <rui.zhang@intel.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support Date: Mon, 15 Feb 2016 10:14:12 +0800 [thread overview] Message-ID: <CAGS+omArr0_-ziBXWjEcKS0bqnruNzZc2aq2s3zkghUC7_HfGw@mail.gmail.com> (raw) In-Reply-To: <CAGS+omD9U8tKmb02d_gMMAGX18MJZhz0RrugpBK2EuqgZrBy6g@mail.gmail.com> On Mon, Feb 15, 2016 at 10:11 AM, Daniel Kurtz <djkurtz@chromium.org> wrote: > Hi Eduardo, Sascha, > > On Mon, Feb 1, 2016 at 10:54 AM, Eddie Huang <eddie.huang@mediatek.com> wrote: >> >> On Tue, 2016-01-19 at 15:29 +0800, Sascha Hauer wrote: >> > Eduardo, >> > >> > On Mon, Jan 04, 2016 at 03:19:40PM +0100, Sascha Hauer wrote: >> > > Hi Eduardo, >> > > >> > > > >> > > > That should remove the policy of computing the maximum from this driver. >> > > > Please have a look on the work being done [1] to add grouping and >> > > > aggregation of thermal zones. With that in place, you should be a matter >> > > > of configuring the grouping and selecting max as the aggregation function, >> > > > from the thermal core, instead in the driver. Which should give the >> > > > system engineer, more flexibility to compose whatever policy based on >> > > > the exposed sensors. >> > > >> > > I think the aggregation of thermal zones is quite useful when it comes >> > > to putting different chips together to a system. I am not so sure how >> > > useful it is to expose different thermal zones of a single SoC to the >> > > device tree. >> > > Currently the only control knob we have is the CPU frequency. When any >> > > of the sensors on the SoC gets too hot then the only thing we can do is >> > > to decrease the CPU frequency. This does not leave much space for >> > > configuration in the device tree. >> > > What I need to be able is to attach multiple sensors to one thermal >> > > zone. The aggregation patch series only partly solves that and I think >> > > is inconsistent, but I commented on the series directly. >> > >> > Any input on this? I really like to get this driver upstream as it is >> > currently blocking other Mediatek drivers. >> > >> >> Hi Eduardo, >> >> Do you have any comment about Sascha's response ? We really hope get >> your comment since Mediatek thermal driver already reviewed in public >> over half years, and we have other patches [0] [1] depend on thermal >> driver. >> >> [0]: >> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/394084.html >> [1]: >> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/401055.html > > Friendly ping on the Mediatek thermal driver. > The "EFUSE" dependency has now landed in v4.5-rc4. Actually, it landed in char-misc-next, not v4.5-rc4. > So, AFAICT, the only thing left that may be blocking landing Mediatek > thermal driver is resolution of this discussion about thermal zones. > Can we kindly resolve this soon so we have a chance to land it in v4.6. > > Thanks, > -Dan
WARNING: multiple messages have this Message-ID (diff)
From: djkurtz@chromium.org (Daniel Kurtz) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] thermal: Add Mediatek thermal controller support Date: Mon, 15 Feb 2016 10:14:12 +0800 [thread overview] Message-ID: <CAGS+omArr0_-ziBXWjEcKS0bqnruNzZc2aq2s3zkghUC7_HfGw@mail.gmail.com> (raw) In-Reply-To: <CAGS+omD9U8tKmb02d_gMMAGX18MJZhz0RrugpBK2EuqgZrBy6g@mail.gmail.com> On Mon, Feb 15, 2016 at 10:11 AM, Daniel Kurtz <djkurtz@chromium.org> wrote: > Hi Eduardo, Sascha, > > On Mon, Feb 1, 2016 at 10:54 AM, Eddie Huang <eddie.huang@mediatek.com> wrote: >> >> On Tue, 2016-01-19 at 15:29 +0800, Sascha Hauer wrote: >> > Eduardo, >> > >> > On Mon, Jan 04, 2016 at 03:19:40PM +0100, Sascha Hauer wrote: >> > > Hi Eduardo, >> > > >> > > > >> > > > That should remove the policy of computing the maximum from this driver. >> > > > Please have a look on the work being done [1] to add grouping and >> > > > aggregation of thermal zones. With that in place, you should be a matter >> > > > of configuring the grouping and selecting max as the aggregation function, >> > > > from the thermal core, instead in the driver. Which should give the >> > > > system engineer, more flexibility to compose whatever policy based on >> > > > the exposed sensors. >> > > >> > > I think the aggregation of thermal zones is quite useful when it comes >> > > to putting different chips together to a system. I am not so sure how >> > > useful it is to expose different thermal zones of a single SoC to the >> > > device tree. >> > > Currently the only control knob we have is the CPU frequency. When any >> > > of the sensors on the SoC gets too hot then the only thing we can do is >> > > to decrease the CPU frequency. This does not leave much space for >> > > configuration in the device tree. >> > > What I need to be able is to attach multiple sensors to one thermal >> > > zone. The aggregation patch series only partly solves that and I think >> > > is inconsistent, but I commented on the series directly. >> > >> > Any input on this? I really like to get this driver upstream as it is >> > currently blocking other Mediatek drivers. >> > >> >> Hi Eduardo, >> >> Do you have any comment about Sascha's response ? We really hope get >> your comment since Mediatek thermal driver already reviewed in public >> over half years, and we have other patches [0] [1] depend on thermal >> driver. >> >> [0]: >> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/394084.html >> [1]: >> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/401055.html > > Friendly ping on the Mediatek thermal driver. > The "EFUSE" dependency has now landed in v4.5-rc4. Actually, it landed in char-misc-next, not v4.5-rc4. > So, AFAICT, the only thing left that may be blocking landing Mediatek > thermal driver is resolution of this discussion about thermal zones. > Can we kindly resolve this soon so we have a chance to land it in v4.6. > > Thanks, > -Dan
next prev parent reply other threads:[~2016-02-15 2:14 UTC|newest] Thread overview: 164+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-30 11:42 [PATCH v12] Add Mediatek thermal support Sascha Hauer 2015-11-30 11:42 ` Sascha Hauer 2015-11-30 11:42 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer 2015-11-30 11:42 ` Sascha Hauer 2015-12-16 11:23 ` Daniel Kurtz 2015-12-16 11:23 ` Daniel Kurtz 2015-12-16 11:23 ` Daniel Kurtz 2015-12-17 19:23 ` Eduardo Valentin 2015-12-17 19:23 ` Eduardo Valentin 2015-12-17 19:23 ` Eduardo Valentin 2015-12-18 7:16 ` Sascha Hauer 2015-12-18 7:16 ` Sascha Hauer 2015-12-18 7:16 ` Sascha Hauer 2015-12-20 2:12 ` Eduardo Valentin 2015-12-20 2:12 ` Eduardo Valentin 2015-12-20 2:12 ` Eduardo Valentin 2015-11-30 11:42 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer 2015-11-30 11:42 ` Sascha Hauer 2015-12-17 19:33 ` Eduardo Valentin 2015-12-17 19:33 ` Eduardo Valentin 2016-01-04 14:19 ` Sascha Hauer 2016-01-04 14:19 ` Sascha Hauer 2016-01-19 7:29 ` Sascha Hauer 2016-01-19 7:29 ` Sascha Hauer 2016-02-01 2:54 ` Eddie Huang 2016-02-01 2:54 ` Eddie Huang 2016-02-01 2:54 ` Eddie Huang 2016-02-15 2:11 ` Daniel Kurtz 2016-02-15 2:11 ` Daniel Kurtz 2016-02-15 2:11 ` Daniel Kurtz 2016-02-15 2:14 ` Daniel Kurtz [this message] 2016-02-15 2:14 ` Daniel Kurtz 2016-02-15 2:14 ` Daniel Kurtz 2016-02-17 17:05 ` Matthias Brugger 2016-02-17 17:05 ` Matthias Brugger 2016-02-17 17:05 ` Matthias Brugger 2016-02-18 10:56 ` Sascha Hauer 2016-02-18 10:56 ` Sascha Hauer 2016-02-18 10:56 ` Sascha Hauer 2016-02-18 14:28 ` Javi Merino 2016-02-18 14:28 ` Javi Merino 2016-02-18 14:28 ` Javi Merino 2016-02-18 15:15 ` Eduardo Valentin 2016-02-18 15:15 ` Eduardo Valentin 2016-02-18 15:15 ` Eduardo Valentin 2016-02-19 7:21 ` Sascha Hauer 2016-02-19 7:21 ` Sascha Hauer 2016-02-19 7:21 ` Sascha Hauer 2015-12-21 4:07 ` Daniel Kurtz 2015-12-21 4:07 ` Daniel Kurtz 2015-12-21 4:07 ` Daniel Kurtz 2016-01-04 14:31 ` Sascha Hauer 2016-01-04 14:31 ` Sascha Hauer 2016-01-04 14:31 ` Sascha Hauer 2016-01-04 15:43 ` Daniel Kurtz 2016-01-04 15:43 ` Daniel Kurtz 2016-01-04 15:43 ` Daniel Kurtz 2015-11-30 11:42 ` [PATCH 3/3] ARM64: dts: mt8173: Add thermal/auxadc device nodes Sascha Hauer 2015-11-30 11:42 ` Sascha Hauer 2016-02-18 16:18 ` Matthias Brugger 2016-02-18 16:18 ` Matthias Brugger 2016-02-19 7:20 ` Sascha Hauer 2016-02-19 7:20 ` Sascha Hauer 2016-04-20 11:23 ` Matthias Brugger 2016-04-20 11:23 ` Matthias Brugger 2015-12-14 10:37 ` [PATCH v12] Add Mediatek thermal support Sascha Hauer 2015-12-14 10:37 ` Sascha Hauer 2015-12-14 10:37 ` Sascha Hauer 2015-12-14 21:08 ` Eduardo Valentin 2015-12-14 21:08 ` Eduardo Valentin 2016-02-18 15:50 ` [PATCH 1/1] thermal: small style cleanup in mtk_thermal Eduardo Valentin 2016-02-18 15:50 ` Eduardo Valentin 2016-02-18 15:56 ` Matthias Brugger 2016-02-18 15:56 ` Matthias Brugger 2016-02-18 15:53 ` [PATCH v12] Add Mediatek thermal support Eduardo Valentin 2016-02-18 15:53 ` Eduardo Valentin -- strict thread matches above, loose matches on Subject: below -- 2015-11-18 8:24 [PATCH v11] " Sascha Hauer 2015-11-18 8:24 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer 2015-11-18 8:24 ` Sascha Hauer 2015-11-24 6:06 ` dawei chien 2015-11-24 6:06 ` dawei chien 2015-11-24 6:06 ` dawei chien 2015-11-24 7:53 ` Sascha Hauer 2015-11-24 7:53 ` Sascha Hauer 2015-11-09 10:13 [PATCH v10] Add Mediatek thermal support Sascha Hauer 2015-11-09 10:13 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer 2015-11-09 10:13 ` Sascha Hauer 2015-11-09 10:13 ` Sascha Hauer 2015-11-09 14:39 ` Andy Shevchenko 2015-11-09 14:39 ` Andy Shevchenko 2015-11-18 8:11 ` Sascha Hauer 2015-11-18 8:11 ` Sascha Hauer 2015-11-18 8:11 ` Sascha Hauer 2015-11-10 12:05 ` Javi Merino 2015-11-10 12:05 ` Javi Merino 2015-11-10 18:26 ` Eduardo Valentin 2015-11-10 18:26 ` Eduardo Valentin 2015-11-11 7:27 ` Sascha Hauer 2015-11-11 7:27 ` Sascha Hauer 2015-11-11 9:40 ` Javi Merino 2015-11-11 9:40 ` Javi Merino 2015-11-11 9:40 ` Javi Merino 2015-11-13 10:09 ` Sascha Hauer 2015-11-13 10:09 ` Sascha Hauer 2015-11-13 11:26 ` Javi Merino 2015-11-13 11:26 ` Javi Merino 2015-11-18 8:18 ` Sascha Hauer 2015-11-18 8:18 ` Sascha Hauer 2015-09-23 13:37 [PATCH v9] Add Mediatek thermal support Sascha Hauer 2015-09-23 13:37 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer 2015-09-23 13:37 ` Sascha Hauer 2015-09-23 18:31 ` Vladimir Zapolskiy 2015-09-23 18:31 ` Vladimir Zapolskiy 2015-09-23 18:31 ` Vladimir Zapolskiy 2015-09-30 6:14 ` Sascha Hauer 2015-09-30 6:14 ` Sascha Hauer 2015-09-29 23:04 ` Eduardo Valentin 2015-09-29 23:04 ` Eduardo Valentin 2015-09-29 23:04 ` Eduardo Valentin 2015-09-30 6:13 ` Sascha Hauer 2015-09-30 6:13 ` Sascha Hauer 2015-09-30 9:36 ` Punit Agrawal 2015-09-30 9:36 ` Punit Agrawal 2015-09-30 9:36 ` Punit Agrawal 2015-09-30 10:37 ` Sascha Hauer 2015-09-30 10:37 ` Sascha Hauer 2015-09-30 11:07 ` Punit Agrawal 2015-09-30 11:07 ` Punit Agrawal 2015-08-31 7:34 [PATCH v8] Add Mediatek thermal support Sascha Hauer 2015-08-31 7:34 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer 2015-08-31 7:34 ` Sascha Hauer 2015-08-31 7:34 ` Sascha Hauer 2015-09-14 7:32 ` Daniel Kurtz 2015-09-14 7:32 ` Daniel Kurtz 2015-09-14 7:32 ` Daniel Kurtz 2015-09-22 7:30 ` Daniel Kurtz 2015-09-22 7:30 ` Daniel Kurtz 2015-09-22 7:30 ` Daniel Kurtz 2015-09-22 8:30 ` Sascha Hauer 2015-09-22 8:30 ` Sascha Hauer 2015-09-22 8:30 ` Sascha Hauer 2015-08-27 6:41 [PATCH v7] Add Mediatek thermal support Sascha Hauer 2015-08-27 6:41 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer 2015-08-27 11:50 ` Punit Agrawal 2015-08-26 13:58 [PATCH v6] Add Mediatek thermal support Sascha Hauer 2015-08-26 13:58 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer 2015-08-20 8:05 [PATCH v5] Add Mediatek thermal support Sascha Hauer 2015-08-20 8:06 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer 2015-08-20 22:20 ` Eduardo Valentin 2015-08-20 22:29 ` Daniel Lezcano 2015-08-21 5:06 ` Sascha Hauer 2015-08-20 23:12 ` Daniel Lezcano 2015-08-26 13:54 ` Sascha Hauer 2015-08-26 14:02 ` Daniel Lezcano 2015-08-25 17:41 ` Daniel Kurtz 2015-08-07 13:55 [PATCH v4] Add Mediatek thermal support Sascha Hauer 2015-08-07 13:55 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer 2015-08-11 7:03 ` Daniel Kurtz 2015-08-20 7:57 ` Sascha Hauer 2015-08-05 12:25 [PATCH v3] Add Mediatek thermal support Sascha Hauer 2015-08-05 12:25 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer 2015-08-05 18:02 ` Daniel Kurtz 2015-08-06 8:10 ` Sascha Hauer 2015-07-21 7:59 [PATCH v2] Add Mediatek thermal support Sascha Hauer 2015-07-21 7:59 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer 2015-07-21 7:59 ` Sascha Hauer 2015-07-21 15:13 ` Daniel Kurtz 2015-07-21 15:13 ` Daniel Kurtz 2015-07-21 15:13 ` Daniel Kurtz 2015-08-05 10:20 ` Sascha Hauer 2015-08-05 10:20 ` Sascha Hauer 2015-08-05 10:20 ` Sascha Hauer 2015-07-13 10:34 [PATCH] thermal: Add Mediatek thermal support Sascha Hauer 2015-07-13 10:34 ` [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer 2015-07-13 10:34 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGS+omArr0_-ziBXWjEcKS0bqnruNzZc2aq2s3zkghUC7_HfGw@mail.gmail.com \ --to=djkurtz@chromium.org \ --cc=eddie.huang@mediatek.com \ --cc=edubezval@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=matthias.bgg@gmail.com \ --cc=rui.zhang@intel.com \ --cc=s.hauer@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.