From: Brian Norris <computersforpeace@gmail.com>
To: Yakir Yang <ykk@rock-chips.com>
Cc: Inki Dae <inki.dae@samsung.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>,
Thierry Reding <treding@nvidia.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Mark Yao <mark.yao@rock-chips.com>,
djkurtz@chromium.org, dianders@chromium.org,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
linux-samsung-soc@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
linux-rockchip@lists.infradead.org,
Kishon Vijay Abraham I <kishon@ti.com>,
javier@osg.samsung.com, Kukjin Kim <kgene@kernel.org>,
robherring2@gmail.com, devicetree@vger.kernel.org,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Sean Paul <seanpaul@chromium.org>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org, emil.l.velikov@gmail.com,
linux-kernel@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
ajaynumb@gmail.com, Andy Yan <andy.yan@rock-chips.com>
Subject: Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY
Date: Tue, 3 Nov 2015 17:13:48 -0800 [thread overview]
Message-ID: <20151104011348.GL7274@google.com> (raw)
In-Reply-To: <563955E6.7000905@rock-chips.com>
Hi Yakir,
On Wed, Nov 04, 2015 at 08:48:38AM +0800, Yakir Yang wrote:
> On 11/03/2015 12:38 PM, Brian Norris wrote:
> >On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote:
> >(FYI, I came across this by inspection when comparing Heiko's
> >'somewhat-stable' branch [1] with this series. The former brings up eDP
> >fine on veyron-jaq, whereas this one doesn't yet, even with the above
> >change. Still debugging the issue.)
>
> Hmm... I'm not sure whether your eDP screen have the hotplug signal, so I
I believe hotplug is hooked up but...
> think you can try to add "analogix,force-hpd" flag into
> rk3288-veyron-jaq.dts
>
> &edp {
> analogix,need-force-hpd;
> }
...already tried, just in case. No luck.
> If that changes couldn't fix the problem, guess you may need max the panel
> power up delay time which pointed by Heiko. Like:
>
> Thanks,
> - Yakir
>
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 4fa5f69..546a506 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -82,6 +82,13 @@ static int analogix_dp_detect_hpd(struct
> analogix_dp_device *dp)
> */
> dev_dbg(dp->dev, "failed to get hpd plug status, try to
> force hpd\n");
>
> + /*
> + * Hotplug signal would indicate the right time to operate
> + * panel after poweron, but if the hotplug is missing, then
> + * panel would need wait hundreds of milliseconds at here.
> + */
> + mdelay(100);
> +
> analogix_dp_force_hpd(dp);
>
> if (analogix_dp_get_plug_in_status(dp) != 0) {
I'll give that a try. Per Heiko's suggestion, I've already hacked around
with adding delays in the regulator node, but this could give slightly
different behavior. I doubt it'll help, but I'll let you know if it
does.
Regards,
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: Yakir Yang <ykk@rock-chips.com>
Cc: Inki Dae <inki.dae@samsung.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>,
Thierry Reding <treding@nvidia.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Mark Yao <mark.yao@rock-chips.com>,
djkurtz@chromium.org, dianders@chromium.org,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
linux-samsung-soc@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
linux-rockchip@lists.infradead.org,
Kishon Vijay Abraham I <kishon@ti.com>,
javier@osg.samsung.com, Kukjin Kim <kgene@kernel.org>,
robherring2@gmail.com, devicetree@vger.kernel.org,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Sean Paul <seanpaul@chromi>
Subject: Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY
Date: Tue, 3 Nov 2015 17:13:48 -0800 [thread overview]
Message-ID: <20151104011348.GL7274@google.com> (raw)
In-Reply-To: <563955E6.7000905@rock-chips.com>
Hi Yakir,
On Wed, Nov 04, 2015 at 08:48:38AM +0800, Yakir Yang wrote:
> On 11/03/2015 12:38 PM, Brian Norris wrote:
> >On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote:
> >(FYI, I came across this by inspection when comparing Heiko's
> >'somewhat-stable' branch [1] with this series. The former brings up eDP
> >fine on veyron-jaq, whereas this one doesn't yet, even with the above
> >change. Still debugging the issue.)
>
> Hmm... I'm not sure whether your eDP screen have the hotplug signal, so I
I believe hotplug is hooked up but...
> think you can try to add "analogix,force-hpd" flag into
> rk3288-veyron-jaq.dts
>
> &edp {
> analogix,need-force-hpd;
> }
...already tried, just in case. No luck.
> If that changes couldn't fix the problem, guess you may need max the panel
> power up delay time which pointed by Heiko. Like:
>
> Thanks,
> - Yakir
>
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 4fa5f69..546a506 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -82,6 +82,13 @@ static int analogix_dp_detect_hpd(struct
> analogix_dp_device *dp)
> */
> dev_dbg(dp->dev, "failed to get hpd plug status, try to
> force hpd\n");
>
> + /*
> + * Hotplug signal would indicate the right time to operate
> + * panel after poweron, but if the hotplug is missing, then
> + * panel would need wait hundreds of milliseconds at here.
> + */
> + mdelay(100);
> +
> analogix_dp_force_hpd(dp);
>
> if (analogix_dp_get_plug_in_status(dp) != 0) {
I'll give that a try. Per Heiko's suggestion, I've already hacked around
with adding delays in the regulator node, but this could give slightly
different behavior. I doubt it'll help, but I'll let you know if it
does.
Regards,
Brian
WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY
Date: Tue, 3 Nov 2015 17:13:48 -0800 [thread overview]
Message-ID: <20151104011348.GL7274@google.com> (raw)
In-Reply-To: <563955E6.7000905@rock-chips.com>
Hi Yakir,
On Wed, Nov 04, 2015 at 08:48:38AM +0800, Yakir Yang wrote:
> On 11/03/2015 12:38 PM, Brian Norris wrote:
> >On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote:
> >(FYI, I came across this by inspection when comparing Heiko's
> >'somewhat-stable' branch [1] with this series. The former brings up eDP
> >fine on veyron-jaq, whereas this one doesn't yet, even with the above
> >change. Still debugging the issue.)
>
> Hmm... I'm not sure whether your eDP screen have the hotplug signal, so I
I believe hotplug is hooked up but...
> think you can try to add "analogix,force-hpd" flag into
> rk3288-veyron-jaq.dts
>
> &edp {
> analogix,need-force-hpd;
> }
...already tried, just in case. No luck.
> If that changes couldn't fix the problem, guess you may need max the panel
> power up delay time which pointed by Heiko. Like:
>
> Thanks,
> - Yakir
>
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 4fa5f69..546a506 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -82,6 +82,13 @@ static int analogix_dp_detect_hpd(struct
> analogix_dp_device *dp)
> */
> dev_dbg(dp->dev, "failed to get hpd plug status, try to
> force hpd\n");
>
> + /*
> + * Hotplug signal would indicate the right time to operate
> + * panel after poweron, but if the hotplug is missing, then
> + * panel would need wait hundreds of milliseconds at here.
> + */
> + mdelay(100);
> +
> analogix_dp_force_hpd(dp);
>
> if (analogix_dp_get_plug_in_status(dp) != 0) {
I'll give that a try. Per Heiko's suggestion, I've already hacked around
with adding delays in the regulator node, but this could give slightly
different behavior. I doubt it'll help, but I'll let you know if it
does.
Regards,
Brian
next prev parent reply other threads:[~2015-11-04 1:13 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 8:15 [PATCH v8 0/17] Add Analogix Core Display Port Driver Yakir Yang
2015-10-28 8:15 ` Yakir Yang
2015-10-28 8:15 ` Yakir Yang
2015-10-28 8:19 ` [PATCH v8 01/17] drm: exynos: dp: convert to drm bridge mode Yakir Yang
2015-10-28 8:19 ` Yakir Yang
2016-03-22 22:22 ` Inki Dae
2016-03-22 22:22 ` Inki Dae
2015-10-28 8:21 ` [PATCH v8 02/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory Yakir Yang
2015-10-28 8:21 ` Yakir Yang
2015-11-26 17:30 ` Heiko Stübner
2015-11-26 17:30 ` Heiko Stübner
2015-11-26 17:30 ` Heiko Stübner
2015-11-27 1:20 ` Yakir Yang
2015-11-27 1:20 ` Yakir Yang
2015-11-27 1:20 ` Yakir Yang
2015-11-27 8:42 ` Heiko Stübner
2015-11-27 8:42 ` Heiko Stübner
2015-11-27 8:42 ` Heiko Stübner
2015-10-28 8:23 ` [PATCH v8 03/17] drm: bridge: analogix/dp: fix some obvious code style Yakir Yang
2015-10-28 8:23 ` Yakir Yang
2015-10-28 8:23 ` Yakir Yang
2015-10-28 8:24 ` [PATCH v8 04/17] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count Yakir Yang
2015-10-28 8:24 ` Yakir Yang
2015-10-28 8:24 ` Yakir Yang
2015-10-28 8:25 ` [PATCH v8 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range Yakir Yang
2015-10-28 8:25 ` Yakir Yang
2015-10-28 8:26 ` [PATCH v8 06/17] dt-bindings: add document for analogix display port driver Yakir Yang
2015-10-28 8:26 ` Yakir Yang
2015-10-28 8:26 ` Yakir Yang
2015-10-28 20:02 ` Heiko Stuebner
2015-10-28 20:02 ` Heiko Stuebner
2015-10-28 20:02 ` Heiko Stuebner
2015-10-29 1:12 ` Yakir Yang
2015-10-29 1:12 ` Yakir Yang
2015-10-29 1:12 ` Yakir Yang
2015-10-29 8:40 ` Heiko Stuebner
2015-10-29 8:40 ` Heiko Stuebner
2015-10-29 8:40 ` Heiko Stuebner
2015-10-29 8:56 ` Yakir Yang
2015-10-28 8:27 ` [PATCH v8 07/17] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver Yakir Yang
2015-10-28 8:27 ` Yakir Yang
2015-10-28 8:27 ` [PATCH v8 08/17] drm: rockchip: dp: add rockchip platform dp driver Yakir Yang
2015-10-28 8:27 ` Yakir Yang
2015-11-27 8:41 ` Heiko Stübner
2015-11-27 8:41 ` Heiko Stübner
2015-11-27 8:41 ` Heiko Stübner
2015-10-28 8:28 ` [PATCH v8 09/17] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang
2015-10-28 8:28 ` Yakir Yang
2015-10-30 16:46 ` Rob Herring
2015-10-30 16:46 ` Rob Herring
2015-10-30 16:46 ` Rob Herring
2015-10-31 3:15 ` Yakir Yang
2015-10-31 3:15 ` Yakir Yang
2015-10-31 3:15 ` Yakir Yang
2015-10-28 8:30 ` [PATCH v8 10/17] phy: Add driver for rockchip Display Port PHY Yakir Yang
2015-10-28 8:30 ` Yakir Yang
2015-10-28 20:36 ` Heiko Stuebner
2015-10-28 20:36 ` Heiko Stuebner
2015-10-28 20:36 ` Heiko Stuebner
2015-10-29 1:14 ` Yakir Yang
2015-10-29 1:14 ` Yakir Yang
2015-10-29 1:14 ` Yakir Yang
2015-11-11 23:23 ` Heiko Stuebner
2015-11-11 23:23 ` Heiko Stuebner
2015-11-11 23:23 ` Heiko Stuebner
2015-11-12 2:36 ` Yakir Yang
2015-11-12 9:21 ` Heiko Stuebner
2015-11-12 9:21 ` Heiko Stuebner
2015-11-12 9:21 ` Heiko Stuebner
2015-10-28 8:31 ` [PATCH v8 11/17] dt-bindings: add document for rockchip dp phy Yakir Yang
2015-10-28 8:31 ` Yakir Yang
2015-10-30 16:42 ` Rob Herring
2015-10-30 16:42 ` Rob Herring
2015-10-30 16:42 ` Rob Herring
2015-10-31 3:13 ` Yakir Yang
2015-10-31 3:13 ` Yakir Yang
2015-10-31 3:13 ` Yakir Yang
2015-10-28 8:52 ` [PATCH v8 12/17] drm: rockchip: vop: add bpc and color mode setting Yakir Yang
2015-10-28 8:52 ` Yakir Yang
2015-10-28 8:52 ` Yakir Yang
2015-10-28 8:55 ` [PATCH v8 13/17] drm: bridge: analogix/dp: add some rk3288 special registers setting Yakir Yang
2015-10-28 8:55 ` Yakir Yang
2015-10-28 8:56 ` [PATCH v8 14/17] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 Yakir Yang
2015-10-28 8:56 ` Yakir Yang
2015-11-27 13:32 ` Heiko Stübner
2015-11-27 13:32 ` Heiko Stübner
2015-11-27 13:32 ` Heiko Stübner
2015-12-02 10:46 ` Yakir Yang
2015-12-02 10:46 ` Yakir Yang
2015-12-02 10:46 ` Yakir Yang
2015-10-28 9:12 ` [PATCH v8 16/17] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang
2015-10-28 9:12 ` Yakir Yang
2015-10-28 9:12 ` Yakir Yang
2015-10-28 9:13 ` [PATCH v8 17/17] drm: bridge: analogix/dp: add edid modes parse in get_modes method Yakir Yang
2015-10-28 9:13 ` Yakir Yang
2015-10-29 1:58 ` [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY Yakir Yang
2015-10-29 1:58 ` Yakir Yang
2015-11-03 4:38 ` Brian Norris
2015-11-03 4:38 ` Brian Norris
2015-11-03 4:38 ` Brian Norris
2015-11-04 0:48 ` Yakir Yang
2015-11-04 0:48 ` Yakir Yang
2015-11-04 0:48 ` Yakir Yang
2015-11-04 1:13 ` Brian Norris [this message]
2015-11-04 1:13 ` Brian Norris
2015-11-04 1:13 ` Brian Norris
2015-11-05 23:45 ` Brian Norris
2015-11-05 23:45 ` Brian Norris
2015-11-05 23:45 ` Brian Norris
2015-11-17 12:58 ` Yakir Yang
2015-11-17 12:58 ` Yakir Yang
2015-11-17 12:58 ` Yakir Yang
2015-10-29 17:49 ` [PATCH v8 0/17] Add Analogix Core Display Port Driver Heiko Stuebner
2015-10-29 17:49 ` Heiko Stuebner
2015-10-29 17:49 ` Heiko Stuebner
2015-10-30 1:05 ` Yakir Yang
2015-10-30 1:05 ` Yakir Yang
2015-10-30 1:05 ` Yakir Yang
2015-10-30 1:09 ` [PATCH v9 15/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang
2015-10-30 1:09 ` Yakir Yang
2015-11-11 23:10 ` Rob Herring
2015-11-11 23:10 ` Rob Herring
2015-11-11 23:10 ` Rob Herring
2015-11-12 1:27 ` Yakir Yang
2015-11-12 23:38 ` Rob Herring
2015-11-12 23:38 ` Rob Herring
2015-11-12 23:38 ` Rob Herring
2015-11-13 7:31 ` Yakir Yang
2015-10-31 6:30 ` [PATCH v9 09/17] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang
2015-10-31 6:30 ` Yakir Yang
2015-10-31 6:30 ` Yakir Yang
2015-10-31 6:40 ` Yakir Yang
2015-10-31 6:40 ` Yakir Yang
2015-10-31 6:42 ` [PATCH v10 " Yakir Yang
2015-10-31 6:42 ` Yakir Yang
2015-10-31 18:37 ` Rob Herring
2015-10-31 18:37 ` Rob Herring
2015-10-31 18:37 ` Rob Herring
2015-11-02 0:41 ` Yakir Yang
2015-11-02 0:41 ` Yakir Yang
2015-11-02 0:41 ` Yakir Yang
2015-11-17 13:09 ` [PATCH v10 10/17] phy: Add driver for rockchip Display Port PHY Yakir Yang
2015-11-17 13:09 ` Yakir Yang
2015-11-17 13:09 ` Yakir Yang
2015-11-17 13:31 ` [PATCH v8 0/17] Add Analogix Core Display Port Driver Yakir Yang
2015-11-17 13:31 ` Yakir Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104011348.GL7274@google.com \
--to=computersforpeace@gmail.com \
--cc=a.hajda@samsung.com \
--cc=ajaynumb@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=galak@codeaurora.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=javier@osg.samsung.com \
--cc=jingoohan1@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kishon@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.yao@rock-chips.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=seanpaul@chromium.org \
--cc=sw0312.kim@samsung.com \
--cc=treding@nvidia.com \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.