All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Yakir Yang <ykk@rock-chips.com>
Cc: Inki Dae <inki.dae@samsung.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Thierry Reding <treding@nvidia.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Yao <mark.yao@rock-chips.com>,
	Russell King <linux@arm.linux.org.uk>,
	djkurtz@chromium.org, dianders@chromium.org,
	Sean Paul <seanpaul@chromium.org>, Kukjin Kim <kgene@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	emil.l.velikov@gmail.com,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Pawel Moll <pawel.moll@arm.com>,
	ajaynumb@gmail.com, robherring2@gmail.com,
	javier@osg.samsung.com, Andy Yan <andy.yan@rock-chips.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 08/17] drm: rockchip: dp: add rockchip platform dp driver
Date: Fri, 27 Nov 2015 09:41:42 +0100	[thread overview]
Message-ID: <4247009.9cF1Z5lRXe@diego> (raw)
In-Reply-To: <1446020865-10625-1-git-send-email-ykk@rock-chips.com>

Hi Yakir,

Am Mittwoch, 28. Oktober 2015, 16:27:45 schrieb Yakir Yang:
> Rockchip have three clocks for dp controller, we leave pclk_edp
> to analogix_dp driver control, and keep the sclk_edp_24m and
> sclk_edp in platform driver.
> 
> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---

> diff --git a/drivers/gpu/drm/rockchip/Kconfig
> b/drivers/gpu/drm/rockchip/Kconfig index 35215f6..c2ba945 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -25,3 +25,12 @@ config ROCKCHIP_DW_HDMI
>  	  for the Synopsys DesignWare HDMI driver. If you want to
>  	  enable HDMI on RK3288 based SoC, you should selet this
>  	  option.
> +
> +config ROCKCHIP_ANALOGIX_DP
> +        tristate "Rockchip specific extensions for Analogix DP driver"
> +        depends on DRM_ROCKCHIP
> +        select DRM_ANALOGIX_DP
> +        help

the indentation should probably be tabs here, ROCKCHIP_DW_HDMI also does it 
wrong it seems, but DRM_ROCKCHIP looks correct :-)


Heiko

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Yakir Yang <ykk@rock-chips.com>
Cc: Inki Dae <inki.dae@samsung.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Thierry Reding <treding@nvidia.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Yao <mark.yao@rock-chips.com>,
	Russell King <linux@arm.linux.org.uk>,
	djkurtz@chromium.org, dianders@chromium.org,
	Sean Paul <seanpaul@chromium.org>, Kukjin Kim <kgene@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	emil.l.velikov@gmail.com,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Pawel Moll <pawel.moll@arm.com>,
	ajaynumb@gmail.com, robherring2@gmail.com,
	javier@osg.samsung.com, Andy Yan <andy.yan@rock-chips.com>,
	dri-deve
Subject: Re: [PATCH v8 08/17] drm: rockchip: dp: add rockchip platform dp driver
Date: Fri, 27 Nov 2015 09:41:42 +0100	[thread overview]
Message-ID: <4247009.9cF1Z5lRXe@diego> (raw)
In-Reply-To: <1446020865-10625-1-git-send-email-ykk@rock-chips.com>

Hi Yakir,

Am Mittwoch, 28. Oktober 2015, 16:27:45 schrieb Yakir Yang:
> Rockchip have three clocks for dp controller, we leave pclk_edp
> to analogix_dp driver control, and keep the sclk_edp_24m and
> sclk_edp in platform driver.
> 
> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---

> diff --git a/drivers/gpu/drm/rockchip/Kconfig
> b/drivers/gpu/drm/rockchip/Kconfig index 35215f6..c2ba945 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -25,3 +25,12 @@ config ROCKCHIP_DW_HDMI
>  	  for the Synopsys DesignWare HDMI driver. If you want to
>  	  enable HDMI on RK3288 based SoC, you should selet this
>  	  option.
> +
> +config ROCKCHIP_ANALOGIX_DP
> +        tristate "Rockchip specific extensions for Analogix DP driver"
> +        depends on DRM_ROCKCHIP
> +        select DRM_ANALOGIX_DP
> +        help

the indentation should probably be tabs here, ROCKCHIP_DW_HDMI also does it 
wrong it seems, but DRM_ROCKCHIP looks correct :-)


Heiko

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 08/17] drm: rockchip: dp: add rockchip platform dp driver
Date: Fri, 27 Nov 2015 09:41:42 +0100	[thread overview]
Message-ID: <4247009.9cF1Z5lRXe@diego> (raw)
In-Reply-To: <1446020865-10625-1-git-send-email-ykk@rock-chips.com>

Hi Yakir,

Am Mittwoch, 28. Oktober 2015, 16:27:45 schrieb Yakir Yang:
> Rockchip have three clocks for dp controller, we leave pclk_edp
> to analogix_dp driver control, and keep the sclk_edp_24m and
> sclk_edp in platform driver.
> 
> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---

> diff --git a/drivers/gpu/drm/rockchip/Kconfig
> b/drivers/gpu/drm/rockchip/Kconfig index 35215f6..c2ba945 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -25,3 +25,12 @@ config ROCKCHIP_DW_HDMI
>  	  for the Synopsys DesignWare HDMI driver. If you want to
>  	  enable HDMI on RK3288 based SoC, you should selet this
>  	  option.
> +
> +config ROCKCHIP_ANALOGIX_DP
> +        tristate "Rockchip specific extensions for Analogix DP driver"
> +        depends on DRM_ROCKCHIP
> +        select DRM_ANALOGIX_DP
> +        help

the indentation should probably be tabs here, ROCKCHIP_DW_HDMI also does it 
wrong it seems, but DRM_ROCKCHIP looks correct :-)


Heiko

  reply	other threads:[~2015-11-27  8:42 UTC|newest]

Thread overview: 146+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28  8:15 [PATCH v8 0/17] Add Analogix Core Display Port Driver Yakir Yang
2015-10-28  8:15 ` Yakir Yang
2015-10-28  8:15 ` Yakir Yang
2015-10-28  8:19 ` [PATCH v8 01/17] drm: exynos: dp: convert to drm bridge mode Yakir Yang
2015-10-28  8:19   ` Yakir Yang
2016-03-22 22:22   ` Inki Dae
2016-03-22 22:22     ` Inki Dae
2015-10-28  8:21 ` [PATCH v8 02/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory Yakir Yang
2015-10-28  8:21   ` Yakir Yang
2015-11-26 17:30   ` Heiko Stübner
2015-11-26 17:30     ` Heiko Stübner
2015-11-26 17:30     ` Heiko Stübner
2015-11-27  1:20     ` Yakir Yang
2015-11-27  1:20       ` Yakir Yang
2015-11-27  1:20       ` Yakir Yang
2015-11-27  8:42       ` Heiko Stübner
2015-11-27  8:42         ` Heiko Stübner
2015-11-27  8:42         ` Heiko Stübner
2015-10-28  8:23 ` [PATCH v8 03/17] drm: bridge: analogix/dp: fix some obvious code style Yakir Yang
2015-10-28  8:23   ` Yakir Yang
2015-10-28  8:23   ` Yakir Yang
2015-10-28  8:24 ` [PATCH v8 04/17] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count Yakir Yang
2015-10-28  8:24   ` Yakir Yang
2015-10-28  8:24   ` Yakir Yang
2015-10-28  8:25 ` [PATCH v8 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range Yakir Yang
2015-10-28  8:25   ` Yakir Yang
2015-10-28  8:26 ` [PATCH v8 06/17] dt-bindings: add document for analogix display port driver Yakir Yang
2015-10-28  8:26   ` Yakir Yang
2015-10-28  8:26   ` Yakir Yang
2015-10-28 20:02   ` Heiko Stuebner
2015-10-28 20:02     ` Heiko Stuebner
2015-10-28 20:02     ` Heiko Stuebner
2015-10-29  1:12     ` Yakir Yang
2015-10-29  1:12       ` Yakir Yang
2015-10-29  1:12       ` Yakir Yang
2015-10-29  8:40       ` Heiko Stuebner
2015-10-29  8:40         ` Heiko Stuebner
2015-10-29  8:40         ` Heiko Stuebner
2015-10-29  8:56         ` Yakir Yang
2015-10-28  8:27 ` [PATCH v8 07/17] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver Yakir Yang
2015-10-28  8:27   ` Yakir Yang
2015-10-28  8:27 ` [PATCH v8 08/17] drm: rockchip: dp: add rockchip platform dp driver Yakir Yang
2015-10-28  8:27   ` Yakir Yang
2015-11-27  8:41   ` Heiko Stübner [this message]
2015-11-27  8:41     ` Heiko Stübner
2015-11-27  8:41     ` Heiko Stübner
2015-10-28  8:28 ` [PATCH v8 09/17] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang
2015-10-28  8:28   ` Yakir Yang
2015-10-30 16:46   ` Rob Herring
2015-10-30 16:46     ` Rob Herring
2015-10-30 16:46     ` Rob Herring
2015-10-31  3:15     ` Yakir Yang
2015-10-31  3:15       ` Yakir Yang
2015-10-31  3:15       ` Yakir Yang
2015-10-28  8:30 ` [PATCH v8 10/17] phy: Add driver for rockchip Display Port PHY Yakir Yang
2015-10-28  8:30   ` Yakir Yang
2015-10-28 20:36   ` Heiko Stuebner
2015-10-28 20:36     ` Heiko Stuebner
2015-10-28 20:36     ` Heiko Stuebner
2015-10-29  1:14     ` Yakir Yang
2015-10-29  1:14       ` Yakir Yang
2015-10-29  1:14       ` Yakir Yang
2015-11-11 23:23   ` Heiko Stuebner
2015-11-11 23:23     ` Heiko Stuebner
2015-11-11 23:23     ` Heiko Stuebner
2015-11-12  2:36     ` Yakir Yang
2015-11-12  9:21       ` Heiko Stuebner
2015-11-12  9:21         ` Heiko Stuebner
2015-11-12  9:21         ` Heiko Stuebner
2015-10-28  8:31 ` [PATCH v8 11/17] dt-bindings: add document for rockchip dp phy Yakir Yang
2015-10-28  8:31   ` Yakir Yang
2015-10-30 16:42   ` Rob Herring
2015-10-30 16:42     ` Rob Herring
2015-10-30 16:42     ` Rob Herring
2015-10-31  3:13     ` Yakir Yang
2015-10-31  3:13       ` Yakir Yang
2015-10-31  3:13       ` Yakir Yang
2015-10-28  8:52 ` [PATCH v8 12/17] drm: rockchip: vop: add bpc and color mode setting Yakir Yang
2015-10-28  8:52   ` Yakir Yang
2015-10-28  8:52   ` Yakir Yang
2015-10-28  8:55 ` [PATCH v8 13/17] drm: bridge: analogix/dp: add some rk3288 special registers setting Yakir Yang
2015-10-28  8:55   ` Yakir Yang
2015-10-28  8:56 ` [PATCH v8 14/17] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 Yakir Yang
2015-10-28  8:56   ` Yakir Yang
2015-11-27 13:32   ` Heiko Stübner
2015-11-27 13:32     ` Heiko Stübner
2015-11-27 13:32     ` Heiko Stübner
2015-12-02 10:46     ` Yakir Yang
2015-12-02 10:46       ` Yakir Yang
2015-12-02 10:46       ` Yakir Yang
2015-10-28  9:12 ` [PATCH v8 16/17] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang
2015-10-28  9:12   ` Yakir Yang
2015-10-28  9:12   ` Yakir Yang
2015-10-28  9:13 ` [PATCH v8 17/17] drm: bridge: analogix/dp: add edid modes parse in get_modes method Yakir Yang
2015-10-28  9:13   ` Yakir Yang
2015-10-29  1:58 ` [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY Yakir Yang
2015-10-29  1:58   ` Yakir Yang
2015-11-03  4:38   ` Brian Norris
2015-11-03  4:38     ` Brian Norris
2015-11-03  4:38     ` Brian Norris
2015-11-04  0:48     ` Yakir Yang
2015-11-04  0:48       ` Yakir Yang
2015-11-04  0:48       ` Yakir Yang
2015-11-04  1:13       ` Brian Norris
2015-11-04  1:13         ` Brian Norris
2015-11-04  1:13         ` Brian Norris
2015-11-05 23:45         ` Brian Norris
2015-11-05 23:45           ` Brian Norris
2015-11-05 23:45           ` Brian Norris
2015-11-17 12:58           ` Yakir Yang
2015-11-17 12:58             ` Yakir Yang
2015-11-17 12:58             ` Yakir Yang
2015-10-29 17:49 ` [PATCH v8 0/17] Add Analogix Core Display Port Driver Heiko Stuebner
2015-10-29 17:49   ` Heiko Stuebner
2015-10-29 17:49   ` Heiko Stuebner
2015-10-30  1:05   ` Yakir Yang
2015-10-30  1:05     ` Yakir Yang
2015-10-30  1:05     ` Yakir Yang
2015-10-30  1:09 ` [PATCH v9 15/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang
2015-10-30  1:09   ` Yakir Yang
2015-11-11 23:10   ` Rob Herring
2015-11-11 23:10     ` Rob Herring
2015-11-11 23:10     ` Rob Herring
2015-11-12  1:27     ` Yakir Yang
2015-11-12 23:38       ` Rob Herring
2015-11-12 23:38         ` Rob Herring
2015-11-12 23:38         ` Rob Herring
2015-11-13  7:31         ` Yakir Yang
2015-10-31  6:30 ` [PATCH v9 09/17] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang
2015-10-31  6:30   ` Yakir Yang
2015-10-31  6:30   ` Yakir Yang
2015-10-31  6:40   ` Yakir Yang
2015-10-31  6:40     ` Yakir Yang
2015-10-31  6:42 ` [PATCH v10 " Yakir Yang
2015-10-31  6:42   ` Yakir Yang
2015-10-31 18:37   ` Rob Herring
2015-10-31 18:37     ` Rob Herring
2015-10-31 18:37     ` Rob Herring
2015-11-02  0:41     ` Yakir Yang
2015-11-02  0:41       ` Yakir Yang
2015-11-02  0:41       ` Yakir Yang
2015-11-17 13:09 ` [PATCH v10 10/17] phy: Add driver for rockchip Display Port PHY Yakir Yang
2015-11-17 13:09   ` Yakir Yang
2015-11-17 13:09   ` Yakir Yang
2015-11-17 13:31 ` [PATCH v8 0/17] Add Analogix Core Display Port Driver Yakir Yang
2015-11-17 13:31   ` Yakir Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4247009.9cF1Z5lRXe@diego \
    --to=heiko@sntech.de \
    --cc=a.hajda@samsung.com \
    --cc=ajaynumb@gmail.com \
    --cc=andy.yan@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=djkurtz@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=inki.dae@samsung.com \
    --cc=javier@osg.samsung.com \
    --cc=jingoohan1@gmail.com \
    --cc=jy0922.shim@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kishon@ti.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.yao@rock-chips.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=robherring2@gmail.com \
    --cc=seanpaul@chromium.org \
    --cc=sw0312.kim@samsung.com \
    --cc=treding@nvidia.com \
    --cc=ykk@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.