From: Chris Wilson <chris@chris-wilson.co.uk>
To: akash.goel@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] igt/gem_trtt: Exercise the TRTT hardware
Date: Fri, 22 Jan 2016 20:41:02 +0000 [thread overview]
Message-ID: <20160122204102.GX16147@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1453477067-27587-1-git-send-email-akash.goel@intel.com>
On Fri, Jan 22, 2016 at 09:07:47PM +0530, akash.goel@intel.com wrote:
> +static int emit_store_dword(int fd, uint32_t *cmd_buf, uint32_t dw_offset,
> + uint64_t vaddr, uint32_t data)
> +{
> + cmd_buf[dw_offset++] = MI_STORE_DWORD_IMM;
> + cmd_buf[dw_offset++] = vaddr & 0xFFFFFFFC;
> + cmd_buf[dw_offset++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
To violate this would be a severe bug in the caller. To mask it here
does something that the caller does not expect, very dangerous when
playing with PT. Either way does not serve well as a demonstration.
assert((vaddr & (-(1<<48)|3)) == 0); or hex equivalent.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-22 20:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 11:31 [PATCH] igt/gem_trtt: Exercise the TRTT hardware akash.goel
2016-01-11 12:32 ` Chris Wilson
2016-01-11 12:37 ` Chris Wilson
2016-01-20 10:24 ` Goel, Akash
2016-01-22 15:37 ` [PATCH v2] " akash.goel
2016-01-22 20:41 ` Chris Wilson [this message]
2016-03-03 4:55 ` [PATCH v3] " akash.goel
2016-03-03 10:04 ` Chris Wilson
2016-03-03 15:38 ` Goel, Akash
2016-03-03 15:46 ` Chris Wilson
2016-03-03 16:47 ` Goel, Akash
2016-03-09 11:31 ` [PATCH v4] " akash.goel
2016-03-10 14:26 ` Michel Thierry
2016-03-11 5:59 ` Goel, Akash
2016-03-11 11:48 ` [PATCH v5] " akash.goel
2016-03-17 10:14 ` Michel Thierry
2016-03-18 8:37 ` [PATCH v6] " akash.goel
2016-03-18 8:36 ` Chris Wilson
2016-03-18 9:01 ` Goel, Akash
2016-03-18 9:22 ` Chris Wilson
2016-03-18 9:52 ` Goel, Akash
2016-03-18 10:25 ` [PATCH v7] " akash.goel
2016-03-18 10:32 ` [PATCH v6] " Chris Wilson
2016-03-18 15:49 ` Goel, Akash
2016-03-18 16:01 ` Chris Wilson
2016-03-21 10:00 ` Goel, Akash
2016-03-21 10:11 ` Chris Wilson
2016-03-22 8:37 ` [PATCH v8] " akash.goel
2016-10-27 15:35 ` [PATCH v9] " akash.goel
2016-01-12 6:00 ` [PATCH] " Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160122204102.GX16147@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=akash.goel@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.