From: "Goel, Akash" <akash.goel@intel.com>
To: Michel Thierry <michel.thierry@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: akash.goel@intel.com
Subject: Re: [PATCH v4] igt/gem_trtt: Exercise the TRTT hardware
Date: Fri, 11 Mar 2016 11:29:21 +0530 [thread overview]
Message-ID: <56E25EB9.6030204@intel.com> (raw)
In-Reply-To: <56E1840C.4040902@intel.com>
On 3/10/2016 7:56 PM, Michel Thierry wrote:
> On 3/9/2016 11:31 AM, akash.goel@intel.com wrote:
>> From: Akash Goel <akash.goel@intel.com>
>>
>> This patch provides the testcase to exercise the TRTT hardware.
>>
> ...
>> --- /dev/null
>> +++ b/tests/gem_trtt.c
>> @@ -0,0 +1,498 @@
> ...
>> +
>> +/* gen8_canonical_addr
>> + * Used to convert any address into canonical form, i.e. [63:48] ==
>> [47].
>> + * Based on kernel's sign_extend64 implementation.
>> + * @address - a virtual address
>> + */
>> +#define GEN8_HIGH_ADDRESS_BIT 47
>> +static uint64_t gen8_canonical_addr(uint64_t address)
>> +{
>> + __u8 shift = 63 - GEN8_HIGH_ADDRESS_BIT;
>> + return (__s64)(address << shift) >> shift;
>> +}
>
> ^^^ These came from gem_softpin, didnt they?
> [https://cgit.freedesktop.org/xorg/app/intel-gpu-tools/commit/?id=7cb35109645e6495f67981b9930587c1ddfe4f90]
Yes copied as is from gem_softpin.
> Would you consider moving them to lib/?
> (I think igt_aux is a good place).
Can I move it to igt_aux.h then ?
Best regards
Akash
>
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-11 5:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 11:31 [PATCH] igt/gem_trtt: Exercise the TRTT hardware akash.goel
2016-01-11 12:32 ` Chris Wilson
2016-01-11 12:37 ` Chris Wilson
2016-01-20 10:24 ` Goel, Akash
2016-01-22 15:37 ` [PATCH v2] " akash.goel
2016-01-22 20:41 ` Chris Wilson
2016-03-03 4:55 ` [PATCH v3] " akash.goel
2016-03-03 10:04 ` Chris Wilson
2016-03-03 15:38 ` Goel, Akash
2016-03-03 15:46 ` Chris Wilson
2016-03-03 16:47 ` Goel, Akash
2016-03-09 11:31 ` [PATCH v4] " akash.goel
2016-03-10 14:26 ` Michel Thierry
2016-03-11 5:59 ` Goel, Akash [this message]
2016-03-11 11:48 ` [PATCH v5] " akash.goel
2016-03-17 10:14 ` Michel Thierry
2016-03-18 8:37 ` [PATCH v6] " akash.goel
2016-03-18 8:36 ` Chris Wilson
2016-03-18 9:01 ` Goel, Akash
2016-03-18 9:22 ` Chris Wilson
2016-03-18 9:52 ` Goel, Akash
2016-03-18 10:25 ` [PATCH v7] " akash.goel
2016-03-18 10:32 ` [PATCH v6] " Chris Wilson
2016-03-18 15:49 ` Goel, Akash
2016-03-18 16:01 ` Chris Wilson
2016-03-21 10:00 ` Goel, Akash
2016-03-21 10:11 ` Chris Wilson
2016-03-22 8:37 ` [PATCH v8] " akash.goel
2016-10-27 15:35 ` [PATCH v9] " akash.goel
2016-01-12 6:00 ` [PATCH] " Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E25EB9.6030204@intel.com \
--to=akash.goel@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michel.thierry@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.