All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: linux-block@vger.kernel.org
Cc: linux-nvdimm@lists.01.org, Dave Chinner <david@fromorbit.com>,
	linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	axboe@fb.com, Jeff Moyer <jmoyer@redhat.com>,
	Jan Kara <jack@suse.com>,
	linux-fsdevel@vger.kernel.org,
	Matthew Wilcox <willy@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: [PATCH 0/2] block: fix raw block device dax support
Date: Fri, 29 Jan 2016 07:18:35 -0800	[thread overview]
Message-ID: <20160129151835.18752.9423.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)

The dax support for a raw block device did not account for page cache
entries established by the kernel for partition reads.  This breaks dax
as it assumes that page cache entries are limited to covering holes in
files, or are exceptional entries marking dirty pages.

Additionally, the facility to toggle dax at runtime fails to handle
evacuating the page cache when switching from non-dax-mode to dax-mode.
It needs to be rethought as enabling dax needs to be atomic with
flushing the page cache.

---

Dan Williams (2):
      block: revert runtime dax control of the raw block device
      block: use DAX for partition table reads


 block/ioctl.c             |   38 --------------------------------------
 block/partition-generic.c |   18 +++++++++++++++---
 fs/block_dev.c            |   28 ----------------------------
 fs/dax.c                  |   20 ++++++++++++++++++++
 include/linux/blkdev.h    |   10 ++++++++++
 include/linux/fs.h        |    3 ---
 include/uapi/linux/fs.h   |    1 -
 7 files changed, 45 insertions(+), 73 deletions(-)

WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: linux-block@vger.kernel.org
Cc: linux-nvdimm@ml01.01.org, Dave Chinner <david@fromorbit.com>,
	linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	axboe@fb.com, Jeff Moyer <jmoyer@redhat.com>,
	Jan Kara <jack@suse.com>,
	linux-fsdevel@vger.kernel.org,
	Matthew Wilcox <willy@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: [PATCH 0/2] block: fix raw block device dax support
Date: Fri, 29 Jan 2016 07:18:35 -0800	[thread overview]
Message-ID: <20160129151835.18752.9423.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)

The dax support for a raw block device did not account for page cache
entries established by the kernel for partition reads.  This breaks dax
as it assumes that page cache entries are limited to covering holes in
files, or are exceptional entries marking dirty pages.

Additionally, the facility to toggle dax at runtime fails to handle
evacuating the page cache when switching from non-dax-mode to dax-mode.
It needs to be rethought as enabling dax needs to be atomic with
flushing the page cache.

---

Dan Williams (2):
      block: revert runtime dax control of the raw block device
      block: use DAX for partition table reads


 block/ioctl.c             |   38 --------------------------------------
 block/partition-generic.c |   18 +++++++++++++++---
 fs/block_dev.c            |   28 ----------------------------
 fs/dax.c                  |   20 ++++++++++++++++++++
 include/linux/blkdev.h    |   10 ++++++++++
 include/linux/fs.h        |    3 ---
 include/uapi/linux/fs.h   |    1 -
 7 files changed, 45 insertions(+), 73 deletions(-)

             reply	other threads:[~2016-01-29 15:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 15:18 Dan Williams [this message]
2016-01-29 15:18 ` [PATCH 0/2] block: fix raw block device dax support Dan Williams
2016-01-29 15:18 ` [PATCH 1/2] block: revert runtime dax control of the raw block device Dan Williams
2016-01-29 15:18   ` Dan Williams
2016-01-29 17:54   ` Ross Zwisler
2016-01-29 17:54     ` Ross Zwisler
2016-01-29 15:18 ` [PATCH 2/2] block: use DAX for partition table reads Dan Williams
2016-01-29 15:18   ` Dan Williams
2016-01-29 17:46   ` Jens Axboe
2016-01-29 17:46     ` Jens Axboe
2016-01-29 17:46     ` Jens Axboe
2016-01-29 17:54     ` Dan Williams
2016-01-29 17:54       ` Dan Williams
2016-01-29 19:24   ` Ross Zwisler
2016-01-29 19:24     ` Ross Zwisler
2016-01-29 22:45   ` Matthew Wilcox
2016-01-29 22:45     ` Matthew Wilcox
2016-01-30  0:33   ` [PATCH v2] " Dan Williams
2016-01-30  0:33     ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160129151835.18752.9423.stgit@dwillia2-desk3.amr.corp.intel.com \
    --to=dan.j.williams@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@fb.com \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=jack@suse.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=ross.zwisler@linux.intel.com \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.