From: Matthew Wilcox <willy@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-block@vger.kernel.org, linux-nvdimm@lists.01.org,
Dave Chinner <david@fromorbit.com>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
axboe@fb.com, Jeff Moyer <jmoyer@redhat.com>,
Jan Kara <jack@suse.com>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: Re: [PATCH 2/2] block: use DAX for partition table reads
Date: Fri, 29 Jan 2016 17:45:56 -0500 [thread overview]
Message-ID: <20160129224556.GX2948@linux.intel.com> (raw)
In-Reply-To: <20160129151846.18752.48460.stgit@dwillia2-desk3.amr.corp.intel.com>
On Fri, Jan 29, 2016 at 07:18:46AM -0800, Dan Williams wrote:
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 29189aeace19..b1452c04f1a9 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1633,6 +1633,16 @@ struct blk_dax_ctl {
> pfn_t pfn;
> };
>
> +#ifdef CONFIG_FS_DAX
> +struct page *read_dax_sector(struct block_device *bdev, sector_t n);
> +#else
> +static inline struct page *read_dax_sector(struct block_device *bdev,
> + sector_t n)
> +{
> + return ERR_PTR(-ENXIO);
> +}
> +#endif
> +
Can you move this to include/linux/dax.h? I'd like to keep it that all
functions in dax.c have a prototype in dax.h.
With that change, Reviewed-by: Matthew Wilcox <willy@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-block@vger.kernel.org, linux-nvdimm@ml01.01.org,
Dave Chinner <david@fromorbit.com>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
axboe@fb.com, Jeff Moyer <jmoyer@redhat.com>,
Jan Kara <jack@suse.com>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: Re: [PATCH 2/2] block: use DAX for partition table reads
Date: Fri, 29 Jan 2016 17:45:56 -0500 [thread overview]
Message-ID: <20160129224556.GX2948@linux.intel.com> (raw)
In-Reply-To: <20160129151846.18752.48460.stgit@dwillia2-desk3.amr.corp.intel.com>
On Fri, Jan 29, 2016 at 07:18:46AM -0800, Dan Williams wrote:
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 29189aeace19..b1452c04f1a9 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1633,6 +1633,16 @@ struct blk_dax_ctl {
> pfn_t pfn;
> };
>
> +#ifdef CONFIG_FS_DAX
> +struct page *read_dax_sector(struct block_device *bdev, sector_t n);
> +#else
> +static inline struct page *read_dax_sector(struct block_device *bdev,
> + sector_t n)
> +{
> + return ERR_PTR(-ENXIO);
> +}
> +#endif
> +
Can you move this to include/linux/dax.h? I'd like to keep it that all
functions in dax.c have a prototype in dax.h.
With that change, Reviewed-by: Matthew Wilcox <willy@linux.intel.com>
next prev parent reply other threads:[~2016-01-29 22:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 15:18 [PATCH 0/2] block: fix raw block device dax support Dan Williams
2016-01-29 15:18 ` Dan Williams
2016-01-29 15:18 ` [PATCH 1/2] block: revert runtime dax control of the raw block device Dan Williams
2016-01-29 15:18 ` Dan Williams
2016-01-29 17:54 ` Ross Zwisler
2016-01-29 17:54 ` Ross Zwisler
2016-01-29 15:18 ` [PATCH 2/2] block: use DAX for partition table reads Dan Williams
2016-01-29 15:18 ` Dan Williams
2016-01-29 17:46 ` Jens Axboe
2016-01-29 17:46 ` Jens Axboe
2016-01-29 17:46 ` Jens Axboe
2016-01-29 17:54 ` Dan Williams
2016-01-29 17:54 ` Dan Williams
2016-01-29 19:24 ` Ross Zwisler
2016-01-29 19:24 ` Ross Zwisler
2016-01-29 22:45 ` Matthew Wilcox [this message]
2016-01-29 22:45 ` Matthew Wilcox
2016-01-30 0:33 ` [PATCH v2] " Dan Williams
2016-01-30 0:33 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129224556.GX2948@linux.intel.com \
--to=willy@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.com \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.