From: Dave Chinner <david@fromorbit.com> To: "Darrick J. Wong" <darrick.wong@oracle.com> Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org, xfs@oss.sgi.com Subject: Re: [PATCH 10/23] xfs: more reflink tests Date: Tue, 9 Feb 2016 18:36:22 +1100 [thread overview] Message-ID: <20160209073622.GI19486@dastard> (raw) In-Reply-To: <20160209011250.23099.50000.stgit@birch.djwong.org> On Mon, Feb 08, 2016 at 05:12:50PM -0800, Darrick J. Wong wrote: > Create a couple of XFS-specific tests -- one to check that growing > and shrinking the refcount btree works and a second one to check > what happens when we hit maximum refcount. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> ..... > +# real QA test starts here > +_supported_os Linux > +_supported_fs xfs > +_require_scratch_reflink > +_require_cp_reflink .... > + > +test -x "$here/src/punch-alternating" || _notrun "punch-alternating not built" I suspect we need a _require rule for checking that something in the test src directory has been built. > +echo "Check scratch fs" > +umount "$SCRATCH_MNT" > +echo "check refcount after removing all files" >> "$seqres.full" > +"$XFS_DB_PROG" -c 'agf 0' -c 'addr refcntroot' -c 'p recs[1]' "$SCRATCH_DEV" >> "$seqres.full" > +"$XFS_REPAIR_PROG" -o force_geometry -n "$SCRATCH_DEV" >> "$seqres.full" 2>&1 > +res=$? > +if [ $res -eq 0 ]; then > + # If repair succeeds then format the device so that the post-test > + # check doesn't fail due to the single AG. > + _scratch_mkfs >> "$seqres.full" 2>&1 > +else > + _fail "xfs_repair fails" > +fi > + > +# success, all done > +status=0 > +exit This is what _require_scratch_nocheck avoids. i.e. do this instead: _require_scratch_nocheck ..... "$XFS_REPAIR_PROG" -o force_geometry -n "$SCRATCH_DEV" >> "$seqres.full" 2>&1 status=$? exit Also, we really don't need the quotes around these global variables. They are just noise and lots of stuff will break if those variables are set to something that requires them to be quoted. Cheers, Dave. -- Dave Chinner david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com> To: "Darrick J. Wong" <darrick.wong@oracle.com> Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, xfs@oss.sgi.com Subject: Re: [PATCH 10/23] xfs: more reflink tests Date: Tue, 9 Feb 2016 18:36:22 +1100 [thread overview] Message-ID: <20160209073622.GI19486@dastard> (raw) In-Reply-To: <20160209011250.23099.50000.stgit@birch.djwong.org> On Mon, Feb 08, 2016 at 05:12:50PM -0800, Darrick J. Wong wrote: > Create a couple of XFS-specific tests -- one to check that growing > and shrinking the refcount btree works and a second one to check > what happens when we hit maximum refcount. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> ..... > +# real QA test starts here > +_supported_os Linux > +_supported_fs xfs > +_require_scratch_reflink > +_require_cp_reflink .... > + > +test -x "$here/src/punch-alternating" || _notrun "punch-alternating not built" I suspect we need a _require rule for checking that something in the test src directory has been built. > +echo "Check scratch fs" > +umount "$SCRATCH_MNT" > +echo "check refcount after removing all files" >> "$seqres.full" > +"$XFS_DB_PROG" -c 'agf 0' -c 'addr refcntroot' -c 'p recs[1]' "$SCRATCH_DEV" >> "$seqres.full" > +"$XFS_REPAIR_PROG" -o force_geometry -n "$SCRATCH_DEV" >> "$seqres.full" 2>&1 > +res=$? > +if [ $res -eq 0 ]; then > + # If repair succeeds then format the device so that the post-test > + # check doesn't fail due to the single AG. > + _scratch_mkfs >> "$seqres.full" 2>&1 > +else > + _fail "xfs_repair fails" > +fi > + > +# success, all done > +status=0 > +exit This is what _require_scratch_nocheck avoids. i.e. do this instead: _require_scratch_nocheck ..... "$XFS_REPAIR_PROG" -o force_geometry -n "$SCRATCH_DEV" >> "$seqres.full" 2>&1 status=$? exit Also, we really don't need the quotes around these global variables. They are just noise and lots of stuff will break if those variables are set to something that requires them to be quoted. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-09 7:51 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-09 1:11 [PATCH v4.1 00/23] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls Darrick J. Wong 2016-02-09 1:11 ` Darrick J. Wong 2016-02-09 1:11 ` [PATCH 01/23] generic/182: this is a dedupe test, check for dedupe Darrick J. Wong 2016-02-09 1:11 ` Darrick J. Wong 2016-02-09 1:11 ` [PATCH 02/23] xfstests: filter whitespace in 128 and 132 Darrick J. Wong 2016-02-09 1:11 ` Darrick J. Wong 2016-02-09 1:12 ` [PATCH 03/23] xfstests: make _scratch_mkfs_blocksized usable Darrick J. Wong 2016-02-09 1:12 ` Darrick J. Wong 2016-02-09 1:12 ` [PATCH 04/23] reflink: remove redundant filesystem checks from the end of the tests Darrick J. Wong 2016-02-09 1:12 ` Darrick J. Wong 2016-02-09 1:12 ` [PATCH 05/23] common/dmerror: add some more dmerror routines Darrick J. Wong 2016-02-09 1:12 ` Darrick J. Wong 2016-02-09 1:12 ` [PATCH 06/23] dio unwritten conversion bug tests Darrick J. Wong 2016-02-09 1:12 ` Darrick J. Wong 2016-02-09 7:37 ` Dave Chinner 2016-02-09 7:37 ` Dave Chinner 2016-02-09 8:08 ` Darrick J. Wong 2016-02-09 8:08 ` Darrick J. Wong 2016-02-09 1:12 ` [PATCH 07/23] reflink: test intersecting CoW and falloc/fpunch/fzero/fcollapse/finsert/ftrunc Darrick J. Wong 2016-02-09 1:12 ` Darrick J. Wong 2016-02-09 1:12 ` [PATCH 08/23] reflink: test CoW behavior with IO errors Darrick J. Wong 2016-02-09 1:12 ` Darrick J. Wong 2016-02-09 1:12 ` [PATCH 09/23] reflink: test CoW operations against the source file Darrick J. Wong 2016-02-09 1:12 ` Darrick J. Wong 2016-02-09 1:12 ` [PATCH 10/23] xfs: more reflink tests Darrick J. Wong 2016-02-09 1:12 ` Darrick J. Wong 2016-02-09 7:36 ` Dave Chinner [this message] 2016-02-09 7:36 ` Dave Chinner 2016-02-09 8:16 ` Darrick J. Wong 2016-02-09 8:16 ` Darrick J. Wong 2016-02-09 1:12 ` [PATCH 11/23] reflink: ensure that we can handle reflinking a lot of extents Darrick J. Wong 2016-02-09 1:12 ` Darrick J. Wong 2016-02-09 1:13 ` [PATCH 12/23] xfs/122: support refcount/rmap data structures Darrick J. Wong 2016-02-09 1:13 ` Darrick J. Wong 2016-02-09 7:43 ` Dave Chinner 2016-02-09 7:43 ` Dave Chinner 2016-02-09 7:55 ` Darrick J. Wong 2016-02-09 7:55 ` Darrick J. Wong 2016-02-09 8:53 ` Dave Chinner 2016-02-09 8:53 ` Dave Chinner 2016-02-09 1:13 ` [PATCH 13/23] xfs: test fragmentation characteristics of copy-on-write Darrick J. Wong 2016-02-09 1:13 ` Darrick J. Wong 2016-02-09 8:01 ` Dave Chinner 2016-02-09 8:01 ` Dave Chinner 2016-02-10 1:02 ` Darrick J. Wong 2016-02-10 1:02 ` Darrick J. Wong 2016-02-09 1:13 ` [PATCH 14/23] reflink: high offset reflink and dedupe tests Darrick J. Wong 2016-02-09 1:13 ` Darrick J. Wong 2016-02-09 1:13 ` [PATCH 15/23] reflink: test xfs cow behavior when the filesystem crashes Darrick J. Wong 2016-02-09 1:13 ` Darrick J. Wong 2016-02-09 1:13 ` [PATCH 16/23] reflink: test quota accounting Darrick J. Wong 2016-02-09 1:13 ` Darrick J. Wong 2016-02-09 1:13 ` [PATCH 17/23] reflink: test CoW across a mixed range of block types with cowextsize set Darrick J. Wong 2016-02-09 1:13 ` Darrick J. Wong 2016-02-09 8:09 ` Dave Chinner 2016-02-09 8:09 ` Dave Chinner 2016-02-10 1:03 ` Darrick J. Wong 2016-02-10 1:03 ` Darrick J. Wong 2016-02-09 1:13 ` [PATCH 18/23] xfs: test the automatic cowextsize extent garbage collector Darrick J. Wong 2016-02-09 1:13 ` Darrick J. Wong 2016-02-09 8:15 ` Dave Chinner 2016-02-09 8:15 ` Dave Chinner 2016-02-10 1:06 ` Darrick J. Wong 2016-02-10 1:06 ` Darrick J. Wong 2016-02-09 1:13 ` [PATCH 19/23] xfs: test rmapbt functionality Darrick J. Wong 2016-02-09 1:13 ` Darrick J. Wong 2016-02-09 8:26 ` Dave Chinner 2016-02-09 8:26 ` Dave Chinner 2016-02-10 1:07 ` Darrick J. Wong 2016-02-10 1:07 ` Darrick J. Wong 2016-02-09 1:13 ` [PATCH 20/23] reflink: test aio copy on write Darrick J. Wong 2016-02-09 1:13 ` Darrick J. Wong 2016-02-09 1:14 ` [PATCH 21/23] xfs: aio cow tests Darrick J. Wong 2016-02-09 1:14 ` Darrick J. Wong 2016-02-09 8:32 ` Dave Chinner 2016-02-09 8:32 ` Dave Chinner 2016-02-09 21:51 ` Darrick J. Wong 2016-02-09 21:51 ` Darrick J. Wong 2016-02-09 1:14 ` [PATCH 22/23] xfs: test xfs_getbmapx behavior with shared extents Darrick J. Wong 2016-02-09 1:14 ` Darrick J. Wong 2016-02-09 1:14 ` [PATCH 23/23] reflink: test reflink+cow+enospc all at the same time Darrick J. Wong 2016-02-09 1:14 ` Darrick J. Wong 2016-02-09 7:21 ` [PATCH v4.1 00/23] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls Dave Chinner 2016-02-09 7:21 ` Dave Chinner 2016-02-09 7:25 ` Darrick J. Wong 2016-02-09 7:25 ` Darrick J. Wong 2016-02-09 7:50 ` Darrick J. Wong 2016-02-09 7:50 ` Darrick J. Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160209073622.GI19486@dastard \ --to=david@fromorbit.com \ --cc=darrick.wong@oracle.com \ --cc=fstests@vger.kernel.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.