From: Sakari Ailus <sakari.ailus@iki.fi> To: Shuah Khan <shuahkh@osg.samsung.com> Cc: mchehab@osg.samsung.com, tiwai@suse.com, clemens@ladisch.de, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, javier@osg.samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, perex@perex.cz, arnd@arndb.de, dan.carpenter@oracle.com, tvboxspy@gmail.com, crope@iki.fi, ruchandani.tina@gmail.com, corbet@lwn.net, chehabrafael@gmail.com, k.kozlowski@samsung.com, stefanr@s5r6.in-berlin.de, inki.dae@samsung.com, jh1009.sung@samsung.com, elfring@users.sourceforge.net, prabhakar.csengg@gmail.com, sw0312.kim@samsung.com, p.zabel@pengutronix.de, ricardo.ribalda@gmail.com, labbott@fedoraproject.org, pierre-louis.bossart@linux.intel.com, ricard.wanderlof@axis.com, julian@jusst.de, takamichiho@gmail.com, dominic.sacre@gmx.de, misterpib@gmail.com, daniel@zonque.org, gtmkramer@xs4all.nl, normalperson@yhbt.net, joe@oampo.co.uk, linuxbugs@vittgam.net, johan@oljud.se, klock.android@gmail.com, nenggun.kim@samsung.com, j.anaszewski@samsung.com, geliangtang@163.com, albert@huitsing.nl, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v3 06/22] media: Media Controller enable/disable source handler API Date: Thu, 10 Mar 2016 09:35:00 +0200 [thread overview] Message-ID: <20160310073500.GK11084@valkosipuli.retiisi.org.uk> (raw) In-Reply-To: <2d8b035ec723346dfeed5db859aba67738e049cc.1455233153.git.shuahkh@osg.samsung.com> Hi Shuah, On Thu, Feb 11, 2016 at 04:41:22PM -0700, Shuah Khan wrote: > Add new fields to struct media_device to add enable_source, and > disable_source handlers, and source_priv to stash driver private > data that is used to run these handlers. The enable_source handler > finds source entity for the passed in entity and checks if it is > available. When link is found, it activates it. Disable source > handler deactivates the link. > > Bridge driver is expected to implement and set these handlers. > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > include/media/media-device.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/include/media/media-device.h b/include/media/media-device.h > index 075a482..1a04644 100644 > --- a/include/media/media-device.h > +++ b/include/media/media-device.h > @@ -302,6 +302,11 @@ struct media_entity_notify { > * @entity_notify: List of registered entity_notify callbacks > * @lock: Entities list lock > * @graph_mutex: Entities graph operation lock > + * > + * @source_priv: Driver Private data for enable/disable source handlers > + * @enable_source: Enable Source Handler function pointer > + * @disable_source: Disable Source Handler function pointer > + * > * @link_notify: Link state change notification callback > * > * This structure represents an abstract high-level media device. It allows easy > @@ -313,6 +318,26 @@ struct media_entity_notify { > * > * @model is a descriptive model name exported through sysfs. It doesn't have to > * be unique. > + * > + * @enable_source is a handler to find source entity for the > + * sink entity and activate the link between them if source > + * entity is free. Drivers should call this handler before > + * accessing the source. > + * > + * @disable_source is a handler to find source entity for the > + * sink entity and deactivate the link between them. Drivers > + * should call this handler to release the source. > + * Is there a particular reason you're not simply (de)activating the link, but instead add a new callback? > + * Note: Bridge driver is expected to implement and set the > + * handler when media_device is registered or when > + * bridge driver finds the media_device during probe. > + * Bridge driver sets source_priv with information > + * necessary to run enable/disable source handlers. > + * > + * Use-case: find tuner entity connected to the decoder > + * entity and check if it is available, and activate the > + * the link between them from enable_source and deactivate > + * from disable_source. > */ > struct media_device { > /* dev->driver_data points to this struct. */ > @@ -344,6 +369,11 @@ struct media_device { > /* Serializes graph operations. */ > struct mutex graph_mutex; > > + void *source_priv; > + int (*enable_source)(struct media_entity *entity, > + struct media_pipeline *pipe); > + void (*disable_source)(struct media_entity *entity); > + > int (*link_notify)(struct media_link *link, u32 flags, > unsigned int notification); > }; -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
WARNING: multiple messages have this Message-ID (diff)
From: Sakari Ailus <sakari.ailus@iki.fi> To: Shuah Khan <shuahkh@osg.samsung.com> Cc: mchehab@osg.samsung.com, tiwai@suse.com, clemens@ladisch.de, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, javier@osg.samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, perex@perex.cz, arnd@arndb.de, dan.carpenter@oracle.com, tvboxspy@gmail.com, crope@iki.fi, ruchandani.tina@gmail.com, corbet@lwn.net, chehabrafael@gmail.com, k.kozlowski@samsung.com, stefanr@s5r6.in-berlin.de, inki.dae@samsung.com, jh1009.sung@samsung.com, elfring@users.sourceforge.net, prabhakar.csengg@gmail.com, sw0312.kim@samsung.com, p.zabel@pengutronix.de, ricardo.ribalda@gmail.com, labbott@fedoraproject.org, pierre-louis.bossart@linux.intel.com, ricard.wanderlof@axis.com, julian@jusst.de, takamichiho@gmail.com, dominic.sacre@gmx.de, misterpib@gmail.com, daniel@zonque.org, gtmkramer@xs4all.nl, normalperson@yhbt.net, joe@oam Subject: Re: [PATCH v3 06/22] media: Media Controller enable/disable source handler API Date: Thu, 10 Mar 2016 09:35:00 +0200 [thread overview] Message-ID: <20160310073500.GK11084@valkosipuli.retiisi.org.uk> (raw) In-Reply-To: <2d8b035ec723346dfeed5db859aba67738e049cc.1455233153.git.shuahkh@osg.samsung.com> Hi Shuah, On Thu, Feb 11, 2016 at 04:41:22PM -0700, Shuah Khan wrote: > Add new fields to struct media_device to add enable_source, and > disable_source handlers, and source_priv to stash driver private > data that is used to run these handlers. The enable_source handler > finds source entity for the passed in entity and checks if it is > available. When link is found, it activates it. Disable source > handler deactivates the link. > > Bridge driver is expected to implement and set these handlers. > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > include/media/media-device.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/include/media/media-device.h b/include/media/media-device.h > index 075a482..1a04644 100644 > --- a/include/media/media-device.h > +++ b/include/media/media-device.h > @@ -302,6 +302,11 @@ struct media_entity_notify { > * @entity_notify: List of registered entity_notify callbacks > * @lock: Entities list lock > * @graph_mutex: Entities graph operation lock > + * > + * @source_priv: Driver Private data for enable/disable source handlers > + * @enable_source: Enable Source Handler function pointer > + * @disable_source: Disable Source Handler function pointer > + * > * @link_notify: Link state change notification callback > * > * This structure represents an abstract high-level media device. It allows easy > @@ -313,6 +318,26 @@ struct media_entity_notify { > * > * @model is a descriptive model name exported through sysfs. It doesn't have to > * be unique. > + * > + * @enable_source is a handler to find source entity for the > + * sink entity and activate the link between them if source > + * entity is free. Drivers should call this handler before > + * accessing the source. > + * > + * @disable_source is a handler to find source entity for the > + * sink entity and deactivate the link between them. Drivers > + * should call this handler to release the source. > + * Is there a particular reason you're not simply (de)activating the link, but instead add a new callback? > + * Note: Bridge driver is expected to implement and set the > + * handler when media_device is registered or when > + * bridge driver finds the media_device during probe. > + * Bridge driver sets source_priv with information > + * necessary to run enable/disable source handlers. > + * > + * Use-case: find tuner entity connected to the decoder > + * entity and check if it is available, and activate the > + * the link between them from enable_source and deactivate > + * from disable_source. > */ > struct media_device { > /* dev->driver_data points to this struct. */ > @@ -344,6 +369,11 @@ struct media_device { > /* Serializes graph operations. */ > struct mutex graph_mutex; > > + void *source_priv; > + int (*enable_source)(struct media_entity *entity, > + struct media_pipeline *pipe); > + void (*disable_source)(struct media_entity *entity); > + > int (*link_notify)(struct media_link *link, u32 flags, > unsigned int notification); > }; -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2016-03-10 7:35 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-11 23:41 [PATCH v3 00/22] Sharing media resources across ALSA and au0828 drivers Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 01/22] [media] Docbook: media-types.xml: Add ALSA Media Controller Intf types Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-17 12:19 ` Mauro Carvalho Chehab 2016-02-17 12:19 ` Mauro Carvalho Chehab 2016-02-17 14:59 ` Shuah Khan 2016-02-17 14:59 ` Shuah Khan 2016-02-26 19:28 ` Shuah Khan 2016-02-26 19:28 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 02/22] uapi/media.h: Declare interface types for ALSA Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-17 12:21 ` Mauro Carvalho Chehab 2016-02-17 12:21 ` Mauro Carvalho Chehab 2016-02-26 19:30 ` Shuah Khan 2016-02-26 19:30 ` Shuah Khan 2016-02-26 19:38 ` Takashi Iwai 2016-02-26 19:38 ` Takashi Iwai 2016-03-03 14:59 ` Hans Verkuil 2016-03-03 14:59 ` Hans Verkuil 2016-03-03 15:57 ` Shuah Khan 2016-03-03 15:57 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 03/22] [media] Docbook: media-types.xml: Add Audio Function Entities Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-17 12:23 ` Mauro Carvalho Chehab 2016-02-17 12:23 ` Mauro Carvalho Chehab 2016-02-26 19:40 ` Takashi Iwai 2016-02-26 19:40 ` Takashi Iwai 2016-02-29 2:46 ` Laurent Pinchart 2016-03-03 22:50 ` Shuah Khan 2016-03-03 22:50 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 04/22] media: Add ALSA Media Controller function entities Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-17 12:25 ` Mauro Carvalho Chehab 2016-02-17 12:25 ` Mauro Carvalho Chehab 2016-02-26 19:40 ` Takashi Iwai 2016-02-26 19:40 ` Takashi Iwai 2016-02-11 23:41 ` [PATCH v3 05/22] media: Media Controller register/unregister entity_notify API Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 06/22] media: Media Controller enable/disable source handler API Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-03-10 7:35 ` Sakari Ailus [this message] 2016-03-10 7:35 ` Sakari Ailus 2016-03-10 14:29 ` Shuah Khan 2016-03-10 14:29 ` Shuah Khan 2016-03-13 20:11 ` Sakari Ailus 2016-03-13 20:11 ` Sakari Ailus 2016-03-14 15:22 ` Shuah Khan 2016-03-14 15:22 ` Shuah Khan 2016-03-17 9:30 ` Sakari Ailus 2016-03-17 9:30 ` Sakari Ailus 2016-02-11 23:41 ` [PATCH v3 07/22] media: Media Controller export non locking __media_entity_setup_link() Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 08/22] media: Media Controller non-locking __media_entity_pipeline_start/stop() Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 09/22] media: v4l-core add enable/disable source common interfaces Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 10/22] media: Move au8522_media_pads enum to au8522.h from au8522_priv.h Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 11/22] media: au8522 change to create MC pad for ALSA Audio Out Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 12/22] media: au0828 Use au8522_media_pads enum for pad defines Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 13/22] media: Change v4l-core to check if source is free Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-03-03 20:39 ` Olli Salonen 2016-03-03 21:18 ` Shuah Khan 2016-03-03 21:21 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 14/22] media: au0828 change to use Managed Media Controller API Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 15/22] media: au0828 handle media_init and media_register window Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 16/22] media: au0828 create tuner to decoder link in disabled state Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 17/22] media: au0828 disable tuner to demod link Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 18/22] media: au0828-core register entity_notify hook Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 19/22] media: au0828 add enable, disable source handlers Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 20/22] media: dvb-frontend invoke enable/disable_source handlers Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 21/22] media: au0828 video change to use v4l_enable_media_source() Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-11 23:41 ` [PATCH v3 22/22] sound/usb: Use Media Controller API to share media resources Shuah Khan 2016-02-11 23:41 ` Shuah Khan 2016-02-26 19:33 ` Shuah Khan 2016-02-26 19:33 ` Shuah Khan 2016-02-26 19:55 ` Takashi Iwai 2016-02-26 19:55 ` Takashi Iwai 2016-02-26 20:08 ` Shuah Khan 2016-02-26 20:08 ` Shuah Khan 2016-02-26 20:50 ` Takashi Iwai 2016-02-26 20:50 ` Takashi Iwai 2016-02-27 2:55 ` Shuah Khan 2016-02-27 2:55 ` Shuah Khan 2016-02-27 7:48 ` Takashi Iwai 2016-02-27 7:48 ` Takashi Iwai 2016-02-27 12:41 ` Mauro Carvalho Chehab 2016-02-27 12:41 ` Mauro Carvalho Chehab 2016-02-29 6:01 ` Shuah Khan 2016-02-29 6:01 ` Shuah Khan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160310073500.GK11084@valkosipuli.retiisi.org.uk \ --to=sakari.ailus@iki.fi \ --cc=albert@huitsing.nl \ --cc=alsa-devel@alsa-project.org \ --cc=arnd@arndb.de \ --cc=chehabrafael@gmail.com \ --cc=clemens@ladisch.de \ --cc=corbet@lwn.net \ --cc=crope@iki.fi \ --cc=dan.carpenter@oracle.com \ --cc=daniel@zonque.org \ --cc=dominic.sacre@gmx.de \ --cc=elfring@users.sourceforge.net \ --cc=geliangtang@163.com \ --cc=gtmkramer@xs4all.nl \ --cc=hans.verkuil@cisco.com \ --cc=inki.dae@samsung.com \ --cc=j.anaszewski@samsung.com \ --cc=javier@osg.samsung.com \ --cc=jh1009.sung@samsung.com \ --cc=joe@oampo.co.uk \ --cc=johan@oljud.se \ --cc=julian@jusst.de \ --cc=k.kozlowski@samsung.com \ --cc=klock.android@gmail.com \ --cc=kyungmin.park@samsung.com \ --cc=labbott@fedoraproject.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linuxbugs@vittgam.net \ --cc=m.szyprowski@samsung.com \ --cc=mchehab@osg.samsung.com \ --cc=misterpib@gmail.com \ --cc=nenggun.kim@samsung.com \ --cc=normalperson@yhbt.net \ --cc=p.zabel@pengutronix.de \ --cc=pawel@osciak.com \ --cc=perex@perex.cz \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=prabhakar.csengg@gmail.com \ --cc=ricard.wanderlof@axis.com \ --cc=ricardo.ribalda@gmail.com \ --cc=ruchandani.tina@gmail.com \ --cc=sakari.ailus@linux.intel.com \ --cc=shuahkh@osg.samsung.com \ --cc=stefanr@s5r6.in-berlin.de \ --cc=sw0312.kim@samsung.com \ --cc=takamichiho@gmail.com \ --cc=tiwai@suse.com \ --cc=tvboxspy@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.