All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: axboe@kernel.dk, torvalds@linux-foundation.org,
	hch@infradead.org, tytso@mit.edu, martin.petersen@oracle.com,
	linux-api@vger.kernel.org, david@fromorbit.com,
	linux-kernel@vger.kernel.org, shane.seymour@hpe.com,
	bfields@fieldses.org, linux-fsdevel@vger.kernel.org,
	jlayton@poochiereds.net, akpm@linux-foundation.org
Subject: Re: [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT.
Date: Tue, 15 Mar 2016 00:35:22 -0700	[thread overview]
Message-ID: <20160315073522.GI11669@infradead.org> (raw)
In-Reply-To: <20160305005603.29738.58460.stgit@birch.djwong.org>

On Fri, Mar 04, 2016 at 04:56:03PM -0800, Darrick J. Wong wrote:
> Invalidate the page cache (as a regular O_DIRECT write would do) to avoid
> returning stale cache contents at a later time.
> 
> v5: Refactor the 4.4 refactoring of the ioctl code into separate functions.
> Split the page invalidation and the new ioctl into separate patches.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Didn't I review this already?  If not:

Reviewed-by: Christoph Hellwig <hch@lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: "Darrick J. Wong" <darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
	torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	tytso-3s7WtUTddSA@public.gmane.org,
	martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	shane.seymour-ZPxbGqLxI0U@public.gmane.org,
	bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Subject: Re: [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT.
Date: Tue, 15 Mar 2016 00:35:22 -0700	[thread overview]
Message-ID: <20160315073522.GI11669@infradead.org> (raw)
In-Reply-To: <20160305005603.29738.58460.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>

On Fri, Mar 04, 2016 at 04:56:03PM -0800, Darrick J. Wong wrote:
> Invalidate the page cache (as a regular O_DIRECT write would do) to avoid
> returning stale cache contents at a later time.
> 
> v5: Refactor the 4.4 refactoring of the ioctl code into separate functions.
> Split the page invalidation and the new ioctl into separate patches.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

Didn't I review this already?  If not:

Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>

  reply	other threads:[~2016-03-15  7:36 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-05  0:55 [PATCH v6 0/3] fallocate for block devices to provide zero-out Darrick J. Wong
2016-03-05  0:55 ` Darrick J. Wong
2016-03-05  0:56 ` [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT Darrick J. Wong
2016-03-05  0:56   ` Darrick J. Wong
2016-03-15  7:35   ` Christoph Hellwig [this message]
2016-03-15  7:35     ` Christoph Hellwig
2016-03-05  0:56 ` [PATCH 2/3] block: require write_same and discard requests align to logical block size Darrick J. Wong
2016-03-05  3:02   ` Linus Torvalds
2016-03-15  7:34   ` Christoph Hellwig
2016-03-05  0:56 ` [PATCH 3/3] block: implement (some of) fallocate for block devices Darrick J. Wong
2016-03-05  3:06   ` Linus Torvalds
2016-03-05  3:06     ` Linus Torvalds
2016-03-05 20:57     ` Christoph Hellwig
2016-03-05 20:57       ` Christoph Hellwig
2016-03-05  3:13   ` Linus Torvalds
2016-03-05  3:13     ` Linus Torvalds
2016-03-05 20:58     ` Christoph Hellwig
2016-03-05 20:58       ` Christoph Hellwig
2016-03-05  3:17 ` [PATCH v6 0/3] fallocate for block devices to provide zero-out Linus Torvalds
2016-03-05  3:17   ` Linus Torvalds
2016-03-15 19:42 [PATCH v7 " Darrick J. Wong
2016-03-15 19:42 ` [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT Darrick J. Wong
2016-03-15 19:42   ` Darrick J. Wong
2016-04-13  4:01 [RFC DONOTMERGE v8 0/3] fallocate for block devices Darrick J. Wong
2016-04-13  4:01 ` [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT Darrick J. Wong
2016-04-13  4:01   ` Darrick J. Wong
2016-04-13  4:01   ` Darrick J. Wong
2016-06-17  1:17 [PATCH v9 0/3] fallocate for block devices Darrick J. Wong
2016-06-17  1:17 ` [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT Darrick J. Wong
2016-06-17  1:17   ` Darrick J. Wong
2016-06-20 12:35   ` Bart Van Assche
2016-06-20 12:35     ` Bart Van Assche
2016-06-28 19:13     ` Darrick J. Wong
2016-06-28 19:13       ` Darrick J. Wong
2016-06-28 19:13       ` Darrick J. Wong
2016-06-29  4:57   ` Martin K. Petersen
2016-06-29  4:57     ` Martin K. Petersen
2016-08-26  0:02 [PATCH v10 0/3] fallocate for block devices Darrick J. Wong
2016-08-26  0:02 ` [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT Darrick J. Wong
2016-08-26  0:02   ` Darrick J. Wong
2016-09-29  0:39 [PATCH v10 0/3] fallocate for block devices Darrick J. Wong
2016-09-29  0:39 ` [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT Darrick J. Wong
2016-09-29  0:39   ` Darrick J. Wong
2016-09-29  0:39   ` Darrick J. Wong
2016-09-29  1:16   ` Bart Van Assche
2016-09-29  1:16     ` Bart Van Assche
2016-09-29  5:56   ` Hannes Reinecke
2016-09-29  5:56     ` Hannes Reinecke
2016-09-29 21:16 [PATCH v11 0/3] fallocate for block devices Darrick J. Wong
2016-09-29 21:16 ` [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT Darrick J. Wong
2016-09-29 21:16   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160315073522.GI11669@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=bfields@fieldses.org \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=jlayton@poochiereds.net \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=shane.seymour@hpe.com \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.