From: Dan Williams <dan.j.williams@intel.com> To: linux-nvdimm@lists.01.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH 13/13] libnvdimm, pmem: kill ->pmem_queue and ->pmem_disk Date: Wed, 23 Mar 2016 18:26:29 -0700 [thread overview] Message-ID: <20160324012629.21436.58603.stgit@dwillia2-desk3.jf.intel.com> (raw) In-Reply-To: <20160324012520.21436.22505.stgit@dwillia2-desk3.jf.intel.com> The devm conversion obviates the need to continue to remember the queue and disk locally in the driver. Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/nvdimm/pmem.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 616a16cd655b..0cd7c6529497 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -33,9 +33,6 @@ #include "nd.h" struct pmem_device { - struct request_queue *pmem_queue; - struct gendisk *pmem_disk; - /* One contiguous memory region per device */ phys_addr_t phys_addr; /* when non-zero this device is hosting a 'pfn' instance */ @@ -52,7 +49,7 @@ struct pmem_device { static void pmem_clear_poison(struct pmem_device *pmem, phys_addr_t offset, unsigned int len) { - struct device *dev = disk_to_dev(pmem->pmem_disk); + struct device *dev = pmem->bb.dev; sector_t sector; long cleared; @@ -227,7 +224,6 @@ static int pmem_attach_disk(struct device *dev, q = blk_alloc_queue_node(GFP_KERNEL, dev_to_node(dev)); if (!q) return -ENOMEM; - pmem->pmem_queue = q; pmem->pfn_flags = PFN_DEV; if (is_nd_pfn(dev)) { @@ -260,12 +256,12 @@ static int pmem_attach_disk(struct device *dev, return PTR_ERR(addr); pmem->virt_addr = (void __pmem *) addr; - blk_queue_make_request(pmem->pmem_queue, pmem_make_request); - blk_queue_physical_block_size(pmem->pmem_queue, PAGE_SIZE); - blk_queue_max_hw_sectors(pmem->pmem_queue, UINT_MAX); - blk_queue_bounce_limit(pmem->pmem_queue, BLK_BOUNCE_ANY); - queue_flag_set_unlocked(QUEUE_FLAG_NONROT, pmem->pmem_queue); - pmem->pmem_queue->queuedata = pmem; + blk_queue_make_request(q, pmem_make_request); + blk_queue_physical_block_size(q, PAGE_SIZE); + blk_queue_max_hw_sectors(q, UINT_MAX); + blk_queue_bounce_limit(q, BLK_BOUNCE_ANY); + queue_flag_set_unlocked(QUEUE_FLAG_NONROT, q); + q->queuedata = pmem; disk = alloc_disk_node(0, nid); if (!disk) @@ -276,13 +272,12 @@ static int pmem_attach_disk(struct device *dev, } disk->fops = &pmem_fops; - disk->queue = pmem->pmem_queue; + disk->queue = q; disk->flags = GENHD_FL_EXT_DEVT; nvdimm_namespace_disk_name(ndns, disk->disk_name); disk->driverfs_dev = dev; set_capacity(disk, (pmem->size - pmem->pfn_pad - pmem->data_offset) / 512); - pmem->pmem_disk = disk; if (devm_init_badblocks(dev, &pmem->bb)) return -ENOMEM; nvdimm_badblocks_populate(to_nd_region(dev->parent), &pmem->bb, res); _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com> To: linux-nvdimm@ml01.01.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH 13/13] libnvdimm, pmem: kill ->pmem_queue and ->pmem_disk Date: Wed, 23 Mar 2016 18:26:29 -0700 [thread overview] Message-ID: <20160324012629.21436.58603.stgit@dwillia2-desk3.jf.intel.com> (raw) In-Reply-To: <20160324012520.21436.22505.stgit@dwillia2-desk3.jf.intel.com> The devm conversion obviates the need to continue to remember the queue and disk locally in the driver. Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/nvdimm/pmem.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 616a16cd655b..0cd7c6529497 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -33,9 +33,6 @@ #include "nd.h" struct pmem_device { - struct request_queue *pmem_queue; - struct gendisk *pmem_disk; - /* One contiguous memory region per device */ phys_addr_t phys_addr; /* when non-zero this device is hosting a 'pfn' instance */ @@ -52,7 +49,7 @@ struct pmem_device { static void pmem_clear_poison(struct pmem_device *pmem, phys_addr_t offset, unsigned int len) { - struct device *dev = disk_to_dev(pmem->pmem_disk); + struct device *dev = pmem->bb.dev; sector_t sector; long cleared; @@ -227,7 +224,6 @@ static int pmem_attach_disk(struct device *dev, q = blk_alloc_queue_node(GFP_KERNEL, dev_to_node(dev)); if (!q) return -ENOMEM; - pmem->pmem_queue = q; pmem->pfn_flags = PFN_DEV; if (is_nd_pfn(dev)) { @@ -260,12 +256,12 @@ static int pmem_attach_disk(struct device *dev, return PTR_ERR(addr); pmem->virt_addr = (void __pmem *) addr; - blk_queue_make_request(pmem->pmem_queue, pmem_make_request); - blk_queue_physical_block_size(pmem->pmem_queue, PAGE_SIZE); - blk_queue_max_hw_sectors(pmem->pmem_queue, UINT_MAX); - blk_queue_bounce_limit(pmem->pmem_queue, BLK_BOUNCE_ANY); - queue_flag_set_unlocked(QUEUE_FLAG_NONROT, pmem->pmem_queue); - pmem->pmem_queue->queuedata = pmem; + blk_queue_make_request(q, pmem_make_request); + blk_queue_physical_block_size(q, PAGE_SIZE); + blk_queue_max_hw_sectors(q, UINT_MAX); + blk_queue_bounce_limit(q, BLK_BOUNCE_ANY); + queue_flag_set_unlocked(QUEUE_FLAG_NONROT, q); + q->queuedata = pmem; disk = alloc_disk_node(0, nid); if (!disk) @@ -276,13 +272,12 @@ static int pmem_attach_disk(struct device *dev, } disk->fops = &pmem_fops; - disk->queue = pmem->pmem_queue; + disk->queue = q; disk->flags = GENHD_FL_EXT_DEVT; nvdimm_namespace_disk_name(ndns, disk->disk_name); disk->driverfs_dev = dev; set_capacity(disk, (pmem->size - pmem->pfn_pad - pmem->data_offset) / 512); - pmem->pmem_disk = disk; if (devm_init_badblocks(dev, &pmem->bb)) return -ENOMEM; nvdimm_badblocks_populate(to_nd_region(dev->parent), &pmem->bb, res);
next prev parent reply other threads:[~2016-03-24 1:27 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-24 1:25 [PATCH 00/13] prep for device-dax, untangle pfn-device setup Dan Williams 2016-03-24 1:25 ` Dan Williams 2016-03-24 1:25 ` Dan Williams 2016-03-24 1:25 ` [PATCH 01/13] libnvdimm, pfn: fix nvdimm_namespace_add_poison() vs section alignment Dan Williams 2016-03-24 1:25 ` Dan Williams 2016-03-24 1:25 ` Dan Williams 2016-03-24 10:10 ` Johannes Thumshirn 2016-03-24 10:10 ` Johannes Thumshirn 2016-03-24 10:10 ` Johannes Thumshirn 2016-03-24 14:48 ` Dan Williams 2016-03-24 14:48 ` Dan Williams 2016-03-24 14:48 ` Dan Williams 2016-03-24 1:25 ` [PATCH 02/13] libnvdimm, pmem: kill pmem->ndns Dan Williams 2016-03-24 1:25 ` Dan Williams 2016-03-24 10:31 ` Johannes Thumshirn 2016-03-24 10:31 ` Johannes Thumshirn 2016-03-24 1:25 ` [PATCH 03/13] libnvdimm, pfn, convert nd_pfn_probe() to devm Dan Williams 2016-03-24 1:25 ` Dan Williams 2016-03-24 10:45 ` Johannes Thumshirn 2016-03-24 10:45 ` Johannes Thumshirn 2016-03-24 1:25 ` [PATCH 04/13] libnvdimm, btt, convert nd_btt_probe() " Dan Williams 2016-03-24 1:25 ` Dan Williams 2016-03-24 11:05 ` Johannes Thumshirn 2016-03-24 11:05 ` Johannes Thumshirn 2016-03-24 1:25 ` [PATCH 05/13] libnvdimm, blk: use devm_add_action to release bdev resources Dan Williams 2016-03-24 1:25 ` Dan Williams 2016-03-24 11:48 ` Johannes Thumshirn 2016-03-24 11:48 ` Johannes Thumshirn 2016-03-24 15:14 ` Dan Williams 2016-03-24 15:14 ` Dan Williams 2016-03-24 15:15 ` Johannes Thumshirn 2016-03-24 15:15 ` Johannes Thumshirn 2016-03-24 15:21 ` Dan Williams 2016-03-24 15:21 ` Dan Williams 2016-03-24 1:25 ` [PATCH 06/13] libnvdimm, blk: use ->queuedata for driver private data Dan Williams 2016-03-24 1:25 ` Dan Williams 2016-03-24 11:51 ` Johannes Thumshirn 2016-03-24 11:51 ` Johannes Thumshirn 2016-03-24 1:25 ` [PATCH 07/13] libnvdimm, pmem: " Dan Williams 2016-03-24 1:25 ` Dan Williams 2016-03-24 12:06 ` Johannes Thumshirn 2016-03-24 12:06 ` Johannes Thumshirn 2016-03-24 1:26 ` [PATCH 08/13] libnvdimm, blk: move i/o infrastructure to nd_namespace_blk Dan Williams 2016-03-24 1:26 ` Dan Williams 2016-03-24 12:22 ` Johannes Thumshirn 2016-03-24 12:22 ` Johannes Thumshirn 2016-03-24 15:21 ` Dan Williams 2016-03-24 15:21 ` Dan Williams 2016-03-24 15:22 ` Johannes Thumshirn 2016-03-24 15:22 ` Johannes Thumshirn 2016-03-25 22:02 ` [PATCH v2] " Dan Williams 2016-03-25 22:02 ` Dan Williams 2016-03-24 1:26 ` [PATCH 09/13] libnvdimm, pmem: use devm_add_action to release bdev resources Dan Williams 2016-03-24 1:26 ` Dan Williams 2016-03-24 12:35 ` Johannes Thumshirn 2016-03-24 12:35 ` Johannes Thumshirn 2016-03-24 1:26 ` [PATCH 10/13] libnvdimm, pmem: clean up resource print / request Dan Williams 2016-03-24 1:26 ` Dan Williams 2016-03-24 13:42 ` Johannes Thumshirn 2016-03-24 13:42 ` Johannes Thumshirn 2016-03-24 1:26 ` [PATCH 11/13] libnvdimm, pmem, pfn: make pmem_rw_bytes generic and refactor pfn setup Dan Williams 2016-03-24 1:26 ` Dan Williams 2016-03-24 13:50 ` Johannes Thumshirn 2016-03-24 13:50 ` Johannes Thumshirn 2016-03-25 22:13 ` [PATCH v2] " Dan Williams 2016-03-25 22:13 ` Dan Williams 2016-03-24 1:26 ` [PATCH 12/13] libnvdimm, pmem, pfn: move pfn setup to the core Dan Williams 2016-03-24 1:26 ` Dan Williams 2016-03-24 14:36 ` Johannes Thumshirn 2016-03-24 14:36 ` Johannes Thumshirn 2016-03-24 15:26 ` Dan Williams 2016-03-24 15:26 ` Dan Williams 2016-03-25 22:15 ` [PATCH v2] " Dan Williams 2016-03-25 22:15 ` Dan Williams 2016-03-29 8:30 ` Johannes Thumshirn 2016-03-29 8:30 ` Johannes Thumshirn 2016-03-24 1:26 ` Dan Williams [this message] 2016-03-24 1:26 ` [PATCH 13/13] libnvdimm, pmem: kill ->pmem_queue and ->pmem_disk Dan Williams 2016-03-24 14:38 ` Johannes Thumshirn 2016-03-24 14:38 ` Johannes Thumshirn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160324012629.21436.58603.stgit@dwillia2-desk3.jf.intel.com \ --to=dan.j.williams@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.