From: Dan Williams <dan.j.williams@intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH 08/13] libnvdimm, blk: move i/o infrastructure to nd_namespace_blk
Date: Thu, 24 Mar 2016 08:21:20 -0700 [thread overview]
Message-ID: <CAPcyv4jVtFtvPZkW3N8uevOfRPvs6nL=F8TWgw2tE15Xhf3RyA@mail.gmail.com> (raw)
In-Reply-To: <7155730.1PoRE68eiN@c203>
On Thu, Mar 24, 2016 at 5:22 AM, Johannes Thumshirn <jthumshirn@suse.de> wrote:
> On Mittwoch, 23. März 2016 18:26:03 CET Dan Williams wrote:
>> Consolidate the information for issuing i/o to a blk-namespace, and
>> eliminate some pointer chasing.
>>
>> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
>> ---
> [...]
>> BUG_ON(len > PAGE_SIZE);
>> - err = nd_blk_do_bvec(blk_dev, bip, bvec.bv_page, len,
>> - bvec.bv_offset, rw, iter.bi_sector);
>> + err = nsblk_do_bvec(nsblk, bip, bvec.bv_page, len,
>> + bvec.bv_offset, rw, iter.bi_sector);
>> if (err) {
>> - dev_info(&blk_dev->nsblk->common.dev,
>> + dev_dbg(&nsblk->common.dev,
>> "io error in %s sector %lld, len %d,\n",
>> (rw == READ) ? "READ" : "WRITE",
>> (unsigned long long) iter.bi_sector, len);
>
> Why is an I/O error suddently a debug message instead of an error?
True, that's a jarring change not described in the log, should
probably be its own patch. The rationale is that upper layers already
have error prints for failed commands and this one is redundant.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 08/13] libnvdimm, blk: move i/o infrastructure to nd_namespace_blk
Date: Thu, 24 Mar 2016 08:21:20 -0700 [thread overview]
Message-ID: <CAPcyv4jVtFtvPZkW3N8uevOfRPvs6nL=F8TWgw2tE15Xhf3RyA@mail.gmail.com> (raw)
In-Reply-To: <7155730.1PoRE68eiN@c203>
On Thu, Mar 24, 2016 at 5:22 AM, Johannes Thumshirn <jthumshirn@suse.de> wrote:
> On Mittwoch, 23. März 2016 18:26:03 CET Dan Williams wrote:
>> Consolidate the information for issuing i/o to a blk-namespace, and
>> eliminate some pointer chasing.
>>
>> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
>> ---
> [...]
>> BUG_ON(len > PAGE_SIZE);
>> - err = nd_blk_do_bvec(blk_dev, bip, bvec.bv_page, len,
>> - bvec.bv_offset, rw, iter.bi_sector);
>> + err = nsblk_do_bvec(nsblk, bip, bvec.bv_page, len,
>> + bvec.bv_offset, rw, iter.bi_sector);
>> if (err) {
>> - dev_info(&blk_dev->nsblk->common.dev,
>> + dev_dbg(&nsblk->common.dev,
>> "io error in %s sector %lld, len %d,\n",
>> (rw == READ) ? "READ" : "WRITE",
>> (unsigned long long) iter.bi_sector, len);
>
> Why is an I/O error suddently a debug message instead of an error?
True, that's a jarring change not described in the log, should
probably be its own patch. The rationale is that upper layers already
have error prints for failed commands and this one is redundant.
next prev parent reply other threads:[~2016-03-24 15:21 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 1:25 [PATCH 00/13] prep for device-dax, untangle pfn-device setup Dan Williams
2016-03-24 1:25 ` Dan Williams
2016-03-24 1:25 ` Dan Williams
2016-03-24 1:25 ` [PATCH 01/13] libnvdimm, pfn: fix nvdimm_namespace_add_poison() vs section alignment Dan Williams
2016-03-24 1:25 ` Dan Williams
2016-03-24 1:25 ` Dan Williams
2016-03-24 10:10 ` Johannes Thumshirn
2016-03-24 10:10 ` Johannes Thumshirn
2016-03-24 10:10 ` Johannes Thumshirn
2016-03-24 14:48 ` Dan Williams
2016-03-24 14:48 ` Dan Williams
2016-03-24 14:48 ` Dan Williams
2016-03-24 1:25 ` [PATCH 02/13] libnvdimm, pmem: kill pmem->ndns Dan Williams
2016-03-24 1:25 ` Dan Williams
2016-03-24 10:31 ` Johannes Thumshirn
2016-03-24 10:31 ` Johannes Thumshirn
2016-03-24 1:25 ` [PATCH 03/13] libnvdimm, pfn, convert nd_pfn_probe() to devm Dan Williams
2016-03-24 1:25 ` Dan Williams
2016-03-24 10:45 ` Johannes Thumshirn
2016-03-24 10:45 ` Johannes Thumshirn
2016-03-24 1:25 ` [PATCH 04/13] libnvdimm, btt, convert nd_btt_probe() " Dan Williams
2016-03-24 1:25 ` Dan Williams
2016-03-24 11:05 ` Johannes Thumshirn
2016-03-24 11:05 ` Johannes Thumshirn
2016-03-24 1:25 ` [PATCH 05/13] libnvdimm, blk: use devm_add_action to release bdev resources Dan Williams
2016-03-24 1:25 ` Dan Williams
2016-03-24 11:48 ` Johannes Thumshirn
2016-03-24 11:48 ` Johannes Thumshirn
2016-03-24 15:14 ` Dan Williams
2016-03-24 15:14 ` Dan Williams
2016-03-24 15:15 ` Johannes Thumshirn
2016-03-24 15:15 ` Johannes Thumshirn
2016-03-24 15:21 ` Dan Williams
2016-03-24 15:21 ` Dan Williams
2016-03-24 1:25 ` [PATCH 06/13] libnvdimm, blk: use ->queuedata for driver private data Dan Williams
2016-03-24 1:25 ` Dan Williams
2016-03-24 11:51 ` Johannes Thumshirn
2016-03-24 11:51 ` Johannes Thumshirn
2016-03-24 1:25 ` [PATCH 07/13] libnvdimm, pmem: " Dan Williams
2016-03-24 1:25 ` Dan Williams
2016-03-24 12:06 ` Johannes Thumshirn
2016-03-24 12:06 ` Johannes Thumshirn
2016-03-24 1:26 ` [PATCH 08/13] libnvdimm, blk: move i/o infrastructure to nd_namespace_blk Dan Williams
2016-03-24 1:26 ` Dan Williams
2016-03-24 12:22 ` Johannes Thumshirn
2016-03-24 12:22 ` Johannes Thumshirn
2016-03-24 15:21 ` Dan Williams [this message]
2016-03-24 15:21 ` Dan Williams
2016-03-24 15:22 ` Johannes Thumshirn
2016-03-24 15:22 ` Johannes Thumshirn
2016-03-25 22:02 ` [PATCH v2] " Dan Williams
2016-03-25 22:02 ` Dan Williams
2016-03-24 1:26 ` [PATCH 09/13] libnvdimm, pmem: use devm_add_action to release bdev resources Dan Williams
2016-03-24 1:26 ` Dan Williams
2016-03-24 12:35 ` Johannes Thumshirn
2016-03-24 12:35 ` Johannes Thumshirn
2016-03-24 1:26 ` [PATCH 10/13] libnvdimm, pmem: clean up resource print / request Dan Williams
2016-03-24 1:26 ` Dan Williams
2016-03-24 13:42 ` Johannes Thumshirn
2016-03-24 13:42 ` Johannes Thumshirn
2016-03-24 1:26 ` [PATCH 11/13] libnvdimm, pmem, pfn: make pmem_rw_bytes generic and refactor pfn setup Dan Williams
2016-03-24 1:26 ` Dan Williams
2016-03-24 13:50 ` Johannes Thumshirn
2016-03-24 13:50 ` Johannes Thumshirn
2016-03-25 22:13 ` [PATCH v2] " Dan Williams
2016-03-25 22:13 ` Dan Williams
2016-03-24 1:26 ` [PATCH 12/13] libnvdimm, pmem, pfn: move pfn setup to the core Dan Williams
2016-03-24 1:26 ` Dan Williams
2016-03-24 14:36 ` Johannes Thumshirn
2016-03-24 14:36 ` Johannes Thumshirn
2016-03-24 15:26 ` Dan Williams
2016-03-24 15:26 ` Dan Williams
2016-03-25 22:15 ` [PATCH v2] " Dan Williams
2016-03-25 22:15 ` Dan Williams
2016-03-29 8:30 ` Johannes Thumshirn
2016-03-29 8:30 ` Johannes Thumshirn
2016-03-24 1:26 ` [PATCH 13/13] libnvdimm, pmem: kill ->pmem_queue and ->pmem_disk Dan Williams
2016-03-24 1:26 ` Dan Williams
2016-03-24 14:38 ` Johannes Thumshirn
2016-03-24 14:38 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4jVtFtvPZkW3N8uevOfRPvs6nL=F8TWgw2tE15Xhf3RyA@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.