From: Minchan Kim <minchan@kernel.org> To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>, <jlayton@poochiereds.net>, <bfields@fieldses.org>, Vlastimil Babka <vbabka@suse.cz>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, <koct9i@gmail.com>, <aquini@redhat.com>, <virtualization@lists.linux-foundation.org>, Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Rik van Riel <riel@redhat.com>, <rknize@motorola.com>, Gioh Kim <gi-oh.kim@profitbricks.com>, Sangseok Lee <sangseok.lee@lge.com>, Chan Gyun Jeong <chan.jeong@lge.com>, Al Viro <viro@ZenIV.linux.org.uk>, YiPing Xu <xuyiping@hisilicon.com> Subject: Re: [PATCH v3 11/16] zsmalloc: separate free_zspage from putback_zspage Date: Tue, 19 Apr 2016 16:51:18 +0900 [thread overview] Message-ID: <20160419075118.GD18448@bbox> (raw) In-Reply-To: <20160418010408.GB5882@swordfish> Hi Sergey, On Mon, Apr 18, 2016 at 10:04:08AM +0900, Sergey Senozhatsky wrote: > Hello Minchan, > > On (03/30/16 16:12), Minchan Kim wrote: > [..] > > @@ -1835,23 +1827,31 @@ static void __zs_compact(struct zs_pool *pool, struct size_class *class) > > if (!migrate_zspage(pool, class, &cc)) > > break; > > > > - putback_zspage(pool, class, dst_page); > > + VM_BUG_ON_PAGE(putback_zspage(pool, class, > > + dst_page) == ZS_EMPTY, dst_page); > > can this VM_BUG_ON_PAGE() condition ever be true? I guess it is remained thing after I rebased to catch any mistake. But I'm heavily chainging this part. Please review next version instead of this after a few days. :) > > > } > > /* Stop if we couldn't find slot */ > > if (dst_page == NULL) > > break; > > - putback_zspage(pool, class, dst_page); > > - if (putback_zspage(pool, class, src_page) == ZS_EMPTY) > > + VM_BUG_ON_PAGE(putback_zspage(pool, class, > > + dst_page) == ZS_EMPTY, dst_page); > > hm... this VM_BUG_ON_PAGE(dst_page) is sort of confusing. under what > circumstances it can be true? > > a minor nit, it took me some time (need some coffee I guess) to > correctly parse this macro wrapper > > VM_BUG_ON_PAGE(putback_zspage(pool, class, > dst_page) == ZS_EMPTY, dst_page); > > may be do it like: > fullness = putback_zspage(pool, class, dst_page); > VM_BUG_ON_PAGE(fullness == ZS_EMPTY, dst_page); > > > well, if we want to VM_BUG_ON_PAGE() at all. there haven't been any > problems with compaction, is there any specific reason these macros > were added? > > > > > + if (putback_zspage(pool, class, src_page) == ZS_EMPTY) { > > pool->stats.pages_compacted += class->pages_per_zspage; > > - spin_unlock(&class->lock); > > + spin_unlock(&class->lock); > > + free_zspage(pool, class, src_page); > > do we really need to free_zspage() out of class->lock? > wouldn't something like this > > if (putback_zspage(pool, class, src_page) == ZS_EMPTY) { > pool->stats.pages_compacted += class->pages_per_zspage; > free_zspage(pool, class, src_page); > } > spin_unlock(&class->lock); > > be simpler? The reason I did out of class->lock is deadlock between page_lock and class->lock with upcoming page migration. However, as I said, I'm now heavily changing the part. :) > > besides, free_zspage() now updates class stats out of class lock, > not critical but still. > > -ss > > > + } else { > > + spin_unlock(&class->lock); > > + } > > + > > cond_resched(); > > spin_lock(&class->lock); > > } > > > > if (src_page) > > - putback_zspage(pool, class, src_page); > > + VM_BUG_ON_PAGE(putback_zspage(pool, class, > > + src_page) == ZS_EMPTY, src_page); > > > > spin_unlock(&class->lock); > > }
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org> To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jlayton@poochiereds.net, bfields@fieldses.org, Vlastimil Babka <vbabka@suse.cz>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, koct9i@gmail.com, aquini@redhat.com, virtualization@lists.linux-foundation.org, Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Rik van Riel <riel@redhat.com>, rknize@motorola.com, Gioh Kim <gi-oh.kim@profitbricks.com>, Sangseok Lee <sangseok.lee@lge.com>, Chan Gyun Jeong <chan.jeong@lge.com>, Al Viro <viro@ZenIV.linux.org.uk>, YiPing Xu <xuyiping@hisilicon.com> Subject: Re: [PATCH v3 11/16] zsmalloc: separate free_zspage from putback_zspage Date: Tue, 19 Apr 2016 16:51:18 +0900 [thread overview] Message-ID: <20160419075118.GD18448@bbox> (raw) In-Reply-To: <20160418010408.GB5882@swordfish> Hi Sergey, On Mon, Apr 18, 2016 at 10:04:08AM +0900, Sergey Senozhatsky wrote: > Hello Minchan, > > On (03/30/16 16:12), Minchan Kim wrote: > [..] > > @@ -1835,23 +1827,31 @@ static void __zs_compact(struct zs_pool *pool, struct size_class *class) > > if (!migrate_zspage(pool, class, &cc)) > > break; > > > > - putback_zspage(pool, class, dst_page); > > + VM_BUG_ON_PAGE(putback_zspage(pool, class, > > + dst_page) == ZS_EMPTY, dst_page); > > can this VM_BUG_ON_PAGE() condition ever be true? I guess it is remained thing after I rebased to catch any mistake. But I'm heavily chainging this part. Please review next version instead of this after a few days. :) > > > } > > /* Stop if we couldn't find slot */ > > if (dst_page == NULL) > > break; > > - putback_zspage(pool, class, dst_page); > > - if (putback_zspage(pool, class, src_page) == ZS_EMPTY) > > + VM_BUG_ON_PAGE(putback_zspage(pool, class, > > + dst_page) == ZS_EMPTY, dst_page); > > hm... this VM_BUG_ON_PAGE(dst_page) is sort of confusing. under what > circumstances it can be true? > > a minor nit, it took me some time (need some coffee I guess) to > correctly parse this macro wrapper > > VM_BUG_ON_PAGE(putback_zspage(pool, class, > dst_page) == ZS_EMPTY, dst_page); > > may be do it like: > fullness = putback_zspage(pool, class, dst_page); > VM_BUG_ON_PAGE(fullness == ZS_EMPTY, dst_page); > > > well, if we want to VM_BUG_ON_PAGE() at all. there haven't been any > problems with compaction, is there any specific reason these macros > were added? > > > > > + if (putback_zspage(pool, class, src_page) == ZS_EMPTY) { > > pool->stats.pages_compacted += class->pages_per_zspage; > > - spin_unlock(&class->lock); > > + spin_unlock(&class->lock); > > + free_zspage(pool, class, src_page); > > do we really need to free_zspage() out of class->lock? > wouldn't something like this > > if (putback_zspage(pool, class, src_page) == ZS_EMPTY) { > pool->stats.pages_compacted += class->pages_per_zspage; > free_zspage(pool, class, src_page); > } > spin_unlock(&class->lock); > > be simpler? The reason I did out of class->lock is deadlock between page_lock and class->lock with upcoming page migration. However, as I said, I'm now heavily changing the part. :) > > besides, free_zspage() now updates class stats out of class lock, > not critical but still. > > -ss > > > + } else { > > + spin_unlock(&class->lock); > > + } > > + > > cond_resched(); > > spin_lock(&class->lock); > > } > > > > if (src_page) > > - putback_zspage(pool, class, src_page); > > + VM_BUG_ON_PAGE(putback_zspage(pool, class, > > + src_page) == ZS_EMPTY, src_page); > > > > spin_unlock(&class->lock); > > } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-04-19 7:50 UTC|newest] Thread overview: 185+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-30 7:11 [PATCH v3 00/16] Support non-lru page migration Minchan Kim 2016-03-30 7:11 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 01/16] mm: use put_page to free page instead of putback_lru_page Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-01 12:58 ` Vlastimil Babka 2016-04-01 12:58 ` Vlastimil Babka 2016-04-01 12:58 ` Vlastimil Babka 2016-04-04 1:39 ` Minchan Kim 2016-04-04 1:39 ` Minchan Kim 2016-04-04 1:39 ` Minchan Kim 2016-04-04 4:45 ` Naoya Horiguchi 2016-04-04 4:45 ` Naoya Horiguchi 2016-04-04 14:46 ` Vlastimil Babka 2016-04-04 14:46 ` Vlastimil Babka 2016-04-04 14:46 ` Vlastimil Babka 2016-04-05 1:54 ` Naoya Horiguchi 2016-04-05 1:54 ` Naoya Horiguchi 2016-04-05 1:54 ` Naoya Horiguchi 2016-04-05 8:20 ` Vlastimil Babka 2016-04-05 8:20 ` Vlastimil Babka 2016-04-05 8:20 ` Vlastimil Babka 2016-04-06 0:54 ` Naoya Horiguchi 2016-04-06 0:54 ` Naoya Horiguchi 2016-04-06 0:54 ` Naoya Horiguchi 2016-04-06 7:57 ` Vlastimil Babka 2016-04-06 7:57 ` Vlastimil Babka 2016-04-06 7:57 ` Vlastimil Babka 2016-04-04 4:45 ` Naoya Horiguchi 2016-04-04 5:53 ` Balbir Singh 2016-04-04 5:53 ` Balbir Singh 2016-04-04 5:53 ` Balbir Singh 2016-04-04 6:01 ` Minchan Kim 2016-04-04 6:01 ` Minchan Kim 2016-04-04 6:01 ` Minchan Kim 2016-04-05 3:10 ` Balbir Singh 2016-04-05 3:10 ` Balbir Singh 2016-04-05 3:10 ` Balbir Singh 2016-03-30 7:12 ` [PATCH v3 02/16] mm/compaction: support non-lru movable page migration Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-01 21:29 ` Vlastimil Babka 2016-04-01 21:29 ` Vlastimil Babka 2016-04-04 5:12 ` Minchan Kim 2016-04-04 5:12 ` Minchan Kim 2016-04-04 13:24 ` Vlastimil Babka 2016-04-04 13:24 ` Vlastimil Babka 2016-04-04 13:24 ` Vlastimil Babka 2016-04-07 2:35 ` Minchan Kim 2016-04-07 2:35 ` Minchan Kim 2016-04-07 2:35 ` Minchan Kim 2016-04-04 13:24 ` Vlastimil Babka 2016-04-04 5:12 ` Minchan Kim 2016-04-01 21:29 ` Vlastimil Babka 2016-04-12 8:00 ` Chulmin Kim 2016-04-12 8:00 ` Chulmin Kim 2016-04-12 14:25 ` Minchan Kim 2016-04-12 14:25 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 03/16] mm: add non-lru movable page support document Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-01 14:38 ` Vlastimil Babka 2016-04-01 14:38 ` Vlastimil Babka 2016-04-01 14:38 ` Vlastimil Babka 2016-04-04 2:25 ` Minchan Kim 2016-04-04 2:25 ` Minchan Kim 2016-04-04 2:25 ` Minchan Kim 2016-04-04 13:09 ` Vlastimil Babka 2016-04-04 13:09 ` Vlastimil Babka 2016-04-04 13:09 ` Vlastimil Babka 2016-04-07 2:27 ` Minchan Kim 2016-04-07 2:27 ` Minchan Kim 2016-04-07 2:27 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 04/16] mm/balloon: use general movable page feature into balloon Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-05 12:03 ` Vlastimil Babka 2016-04-05 12:03 ` Vlastimil Babka 2016-04-05 12:03 ` Vlastimil Babka 2016-04-11 4:29 ` Minchan Kim 2016-04-11 4:29 ` Minchan Kim 2016-04-11 4:29 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 05/16] zsmalloc: keep max_object in size_class Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-17 15:08 ` Sergey Senozhatsky 2016-04-17 15:08 ` Sergey Senozhatsky 2016-04-17 15:08 ` Sergey Senozhatsky 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 06/16] zsmalloc: squeeze inuse into page->mapping Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-17 15:08 ` Sergey Senozhatsky 2016-04-17 15:08 ` Sergey Senozhatsky 2016-04-17 15:08 ` Sergey Senozhatsky 2016-04-19 7:40 ` Minchan Kim 2016-04-19 7:40 ` Minchan Kim 2016-04-19 7:40 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 07/16] zsmalloc: remove page_mapcount_reset Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-17 15:11 ` Sergey Senozhatsky 2016-04-17 15:11 ` Sergey Senozhatsky 2016-04-17 15:11 ` Sergey Senozhatsky 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 08/16] zsmalloc: squeeze freelist into page->mapping Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-17 15:56 ` Sergey Senozhatsky 2016-04-17 15:56 ` Sergey Senozhatsky 2016-04-17 15:56 ` Sergey Senozhatsky 2016-04-19 7:42 ` Minchan Kim 2016-04-19 7:42 ` Minchan Kim 2016-04-19 7:42 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 09/16] zsmalloc: move struct zs_meta from mapping to freelist Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-17 15:22 ` Sergey Senozhatsky 2016-04-17 15:22 ` Sergey Senozhatsky 2016-04-17 15:22 ` Sergey Senozhatsky 2016-03-30 7:12 ` [PATCH v3 10/16] zsmalloc: factor page chain functionality out Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-18 0:33 ` Sergey Senozhatsky 2016-04-18 0:33 ` Sergey Senozhatsky 2016-04-19 7:46 ` Minchan Kim 2016-04-19 7:46 ` Minchan Kim 2016-04-19 7:46 ` Minchan Kim 2016-04-18 0:33 ` Sergey Senozhatsky 2016-03-30 7:12 ` [PATCH v3 11/16] zsmalloc: separate free_zspage from putback_zspage Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-18 1:04 ` Sergey Senozhatsky 2016-04-18 1:04 ` Sergey Senozhatsky 2016-04-19 7:51 ` Minchan Kim [this message] 2016-04-19 7:51 ` Minchan Kim 2016-04-19 7:53 ` Sergey Senozhatsky 2016-04-19 7:53 ` Sergey Senozhatsky 2016-04-19 7:53 ` Sergey Senozhatsky 2016-04-19 7:51 ` Minchan Kim 2016-04-18 1:04 ` Sergey Senozhatsky 2016-03-30 7:12 ` [PATCH v3 12/16] zsmalloc: zs_compact refactoring Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-04 8:04 ` Chulmin Kim 2016-04-04 8:04 ` Chulmin Kim 2016-04-04 9:01 ` Minchan Kim 2016-04-04 9:01 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 13/16] zsmalloc: migrate head page of zspage Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-04-06 13:01 ` Chulmin Kim 2016-04-06 13:01 ` Chulmin Kim 2016-04-07 0:34 ` Chulmin Kim 2016-04-07 0:34 ` Chulmin Kim 2016-04-07 0:43 ` Minchan Kim 2016-04-07 0:43 ` Minchan Kim 2016-04-19 6:08 ` Chulmin Kim 2016-04-19 6:08 ` Chulmin Kim 2016-04-19 6:15 ` Minchan Kim 2016-04-19 6:15 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 14/16] zsmalloc: use single linked list for page chain Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 15/16] zsmalloc: migrate tail pages in zspage Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` [PATCH v3 16/16] zram: use __GFP_MOVABLE for memory allocation Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 7:12 ` Minchan Kim 2016-03-30 23:11 ` [PATCH v3 00/16] Support non-lru page migration Andrew Morton 2016-03-30 23:11 ` Andrew Morton 2016-03-30 23:11 ` Andrew Morton 2016-03-31 0:29 ` Sergey Senozhatsky 2016-03-31 0:29 ` Sergey Senozhatsky 2016-03-31 0:29 ` Sergey Senozhatsky 2016-03-31 0:57 ` Minchan Kim 2016-03-31 0:57 ` Minchan Kim 2016-03-31 0:57 ` Minchan Kim 2016-03-31 0:57 ` Minchan Kim 2016-03-31 0:57 ` Minchan Kim 2016-03-31 0:57 ` Minchan Kim 2016-04-04 13:17 ` John Einar Reitan 2016-04-04 13:17 ` John Einar Reitan 2016-04-11 4:35 ` Minchan Kim 2016-04-11 4:35 ` Minchan Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160419075118.GD18448@bbox \ --to=minchan@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=aquini@redhat.com \ --cc=bfields@fieldses.org \ --cc=chan.jeong@lge.com \ --cc=gi-oh.kim@profitbricks.com \ --cc=hughd@google.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=jlayton@poochiereds.net \ --cc=koct9i@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=riel@redhat.com \ --cc=rknize@motorola.com \ --cc=sangseok.lee@lge.com \ --cc=sergey.senozhatsky.work@gmail.com \ --cc=sergey.senozhatsky@gmail.com \ --cc=vbabka@suse.cz \ --cc=viro@ZenIV.linux.org.uk \ --cc=virtualization@lists.linux-foundation.org \ --cc=xuyiping@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.