From: Lee Jones <lee.jones@linaro.org> To: linux-hwmon@vger.kernel.org Subject: Re: [PATCH 09/11] mfd: altr_a10sr: Add Altera A10-SR power supply alarms Date: Mon, 09 May 2016 08:56:54 -0700 [thread overview] Message-ID: <20160509155616.GE19473@dell> (raw) In-Reply-To: <1461339219-15255-1-git-send-email-tthayer@opensource.altera.com> On Mon, 09 May 2016, Lee Jones wrote: > On Fri, 22 Apr 2016, ttha...@opensource.altera.com wrote: > > > From: Thor Thayer <ttha...@opensource.altera.com> > > > > Add support for power supply alarms to the Altera Arria10 > > Development Kit System Resource chip. > > > > Signed-off-by: Thor Thayer <ttha...@opensource.altera.com> > > --- > > drivers/mfd/altera-a10sr.c | 4 ++++ > > include/linux/mfd/altera-a10sr.h | 24 ++++++++++++++++++++++++ > > 2 files changed, 28 insertions(+) > > For my own reference: > Acked-by: Lee Jones <lee.jo...@linaro.org> Change of plan, this should really be squashed into patch 3. > > diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c > > index 2ff08e3..2b2a90c 100644 > > --- a/drivers/mfd/altera-a10sr.c > > +++ b/drivers/mfd/altera-a10sr.c > > @@ -31,6 +31,10 @@ static const struct mfd_cell altr_a10sr_subdev_info[] = { > > .name = "altr_a10sr_gpio", > > .of_compatible = "altr,a10sr-gpio", > > }, > > + { > > + .name = "altr_a10sr_hwmon", > > + .of_compatible = "altr,a10sr-hwmon", > > + }, > > }; > > > > static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg) > > diff --git a/include/linux/mfd/altera-a10sr.h > > b/include/linux/mfd/altera-a10sr.h > > index c869fe7..22aa830 100644 > > --- a/include/linux/mfd/altera-a10sr.h > > +++ b/include/linux/mfd/altera-a10sr.h > > @@ -62,8 +62,32 @@ > > #define ALTR_A10SR_IN_VALID_RANGE_HI 15 > > > > #define ALTR_A10SR_PWR_GOOD1_REG 0x08 /* Power Good1 Read */ > > +/* Power Good #1 Register Bit Definitions */ > > +#define ALTR_A10SR_PG1_OP_FLAG_SHIFT 7 /* Power On Complete */ > > +#define ALTR_A10SR_PG1_1V8_SHIFT 6 /* 1.8V Power Good */ > > +#define ALTR_A10SR_PG1_2V5_SHIFT 5 /* 2.5V Power Good */ > > +#define ALTR_A10SR_PG1_3V3_SHIFT 4 /* 3.3V Power Good */ > > +#define ALTR_A10SR_PG1_5V0_SHIFT 3 /* 5.0V Power Good */ > > +#define ALTR_A10SR_PG1_0V9_SHIFT 2 /* 0.9V Power Good */ > > +#define ALTR_A10SR_PG1_0V95_SHIFT 1 /* 0.95V Power Good */ > > +#define ALTR_A10SR_PG1_1V0_SHIFT 0 /* 1.0V Power Good */ > > + > > #define ALTR_A10SR_PWR_GOOD2_REG 0x0A /* Power Good2 Read */ > > +/* Power Good #2 Register Bit Definitions */ > > +#define ALTR_A10SR_PG2_HPS_SHIFT 7 /* HPS Power Good */ > > +#define ALTR_A10SR_PG2_HL_HPS_SHIFT 6 /* HILOHPS_VDD Power Good > > */ > > +#define ALTR_A10SR_PG2_HL_VDD_SHIFT 5 /* HILO VDD Power Good */ > > +#define ALTR_A10SR_PG2_HL_VDDQ_SHIFT 4 /* HILO VDDQ Power Good */ > > +#define ALTR_A10SR_PG2_FMCAVADJ_SHIFT 3 /* FMCA VADJ Power Good */ > > +#define ALTR_A10SR_PG2_FMCBVADJ_SHIFT 2 /* FMCB VADJ Power Good */ > > +#define ALTR_A10SR_PG2_FAC2MP_SHIFT 1 /* FAC2MP Power Good */ > > +#define ALTR_A10SR_PG2_FBC2MP_SHIFT 0 /* FBC2MP Power Good */ > > + > > #define ALTR_A10SR_PWR_GOOD3_REG 0x0C /* Power Good3 Read */ > > +/* Power Good #3 Register Bit Definitions */ > > +#define ALTR_A10SR_PG3_FAM2C_SHIFT 7 /* FAM2C Power Good */ > > +#define ALTR_A10SR_PG3_10V_FAIL_SHIFT 6 /* 10V Fail n */ > > + > > #define ALTR_A10SR_FMCAB_REG 0x0E /* FMCA/B & PCIe Pwr Enable > > */ > > #define ALTR_A10SR_HPS_RST_REG 0x10 /* HPS Reset */ > > #define ALTR_A10SR_USB_QSPI_REG 0x12 /* USB, BQSPI, FILE Reset */ > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org â Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: tthayer@opensource.altera.com Cc: linus.walleij@linaro.org, gnurou@gmail.com, jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, dinguyen@opensource.altera.com, linux-gpio@vger.kernel.org, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 09/11] mfd: altr_a10sr: Add Altera A10-SR power supply alarms Date: Mon, 9 May 2016 16:56:16 +0100 [thread overview] Message-ID: <20160509155616.GE19473@dell> (raw) In-Reply-To: <20160509155353.GD19473@dell> On Mon, 09 May 2016, Lee Jones wrote: > On Fri, 22 Apr 2016, tthayer@opensource.altera.com wrote: > > > From: Thor Thayer <tthayer@opensource.altera.com> > > > > Add support for power supply alarms to the Altera Arria10 > > Development Kit System Resource chip. > > > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > > --- > > drivers/mfd/altera-a10sr.c | 4 ++++ > > include/linux/mfd/altera-a10sr.h | 24 ++++++++++++++++++++++++ > > 2 files changed, 28 insertions(+) > > For my own reference: > Acked-by: Lee Jones <lee.jones@linaro.org> Change of plan, this should really be squashed into patch 3. > > diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c > > index 2ff08e3..2b2a90c 100644 > > --- a/drivers/mfd/altera-a10sr.c > > +++ b/drivers/mfd/altera-a10sr.c > > @@ -31,6 +31,10 @@ static const struct mfd_cell altr_a10sr_subdev_info[] = { > > .name = "altr_a10sr_gpio", > > .of_compatible = "altr,a10sr-gpio", > > }, > > + { > > + .name = "altr_a10sr_hwmon", > > + .of_compatible = "altr,a10sr-hwmon", > > + }, > > }; > > > > static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg) > > diff --git a/include/linux/mfd/altera-a10sr.h b/include/linux/mfd/altera-a10sr.h > > index c869fe7..22aa830 100644 > > --- a/include/linux/mfd/altera-a10sr.h > > +++ b/include/linux/mfd/altera-a10sr.h > > @@ -62,8 +62,32 @@ > > #define ALTR_A10SR_IN_VALID_RANGE_HI 15 > > > > #define ALTR_A10SR_PWR_GOOD1_REG 0x08 /* Power Good1 Read */ > > +/* Power Good #1 Register Bit Definitions */ > > +#define ALTR_A10SR_PG1_OP_FLAG_SHIFT 7 /* Power On Complete */ > > +#define ALTR_A10SR_PG1_1V8_SHIFT 6 /* 1.8V Power Good */ > > +#define ALTR_A10SR_PG1_2V5_SHIFT 5 /* 2.5V Power Good */ > > +#define ALTR_A10SR_PG1_3V3_SHIFT 4 /* 3.3V Power Good */ > > +#define ALTR_A10SR_PG1_5V0_SHIFT 3 /* 5.0V Power Good */ > > +#define ALTR_A10SR_PG1_0V9_SHIFT 2 /* 0.9V Power Good */ > > +#define ALTR_A10SR_PG1_0V95_SHIFT 1 /* 0.95V Power Good */ > > +#define ALTR_A10SR_PG1_1V0_SHIFT 0 /* 1.0V Power Good */ > > + > > #define ALTR_A10SR_PWR_GOOD2_REG 0x0A /* Power Good2 Read */ > > +/* Power Good #2 Register Bit Definitions */ > > +#define ALTR_A10SR_PG2_HPS_SHIFT 7 /* HPS Power Good */ > > +#define ALTR_A10SR_PG2_HL_HPS_SHIFT 6 /* HILOHPS_VDD Power Good */ > > +#define ALTR_A10SR_PG2_HL_VDD_SHIFT 5 /* HILO VDD Power Good */ > > +#define ALTR_A10SR_PG2_HL_VDDQ_SHIFT 4 /* HILO VDDQ Power Good */ > > +#define ALTR_A10SR_PG2_FMCAVADJ_SHIFT 3 /* FMCA VADJ Power Good */ > > +#define ALTR_A10SR_PG2_FMCBVADJ_SHIFT 2 /* FMCB VADJ Power Good */ > > +#define ALTR_A10SR_PG2_FAC2MP_SHIFT 1 /* FAC2MP Power Good */ > > +#define ALTR_A10SR_PG2_FBC2MP_SHIFT 0 /* FBC2MP Power Good */ > > + > > #define ALTR_A10SR_PWR_GOOD3_REG 0x0C /* Power Good3 Read */ > > +/* Power Good #3 Register Bit Definitions */ > > +#define ALTR_A10SR_PG3_FAM2C_SHIFT 7 /* FAM2C Power Good */ > > +#define ALTR_A10SR_PG3_10V_FAIL_SHIFT 6 /* 10V Fail n */ > > + > > #define ALTR_A10SR_FMCAB_REG 0x0E /* FMCA/B & PCIe Pwr Enable */ > > #define ALTR_A10SR_HPS_RST_REG 0x10 /* HPS Reset */ > > #define ALTR_A10SR_USB_QSPI_REG 0x12 /* USB, BQSPI, FILE Reset */ > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-05-09 15:56 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-22 15:33 [PATCH 00/11] Addition of Altera Arria10 System Resource Chip tthayer 2016-04-22 15:33 ` tthayer 2016-04-22 15:33 ` [PATCH 01/11] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings tthayer 2016-04-22 15:33 ` tthayer 2016-04-25 12:55 ` Rob Herring 2016-04-25 12:55 ` Rob Herring 2016-04-25 15:01 ` Thor Thayer 2016-04-25 15:01 ` Thor Thayer 2016-04-26 12:33 ` Rob Herring 2016-04-26 12:34 ` Rob Herring 2016-04-22 15:33 ` [PATCH 02/11] MAINTAINERS: Add Altera Arria10 System Resource Chip tthayer 2016-04-22 15:33 ` tthayer 2016-05-09 15:36 ` Lee Jones 2016-05-09 15:37 ` Lee Jones 2016-04-22 15:33 ` [PATCH 03/11] mfd: altr_a10sr: Add Altera Arria10 DevKit " tthayer 2016-04-22 15:33 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 2016-05-09 16:02 ` Lee Jones 2016-05-09 16:02 ` Lee Jones 2016-04-22 15:33 ` [PATCH 04/11] gpio: altera-a10sr: Add A10 System Resource Chip GPIO support tthayer 2016-04-22 15:33 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 2016-04-29 9:29 ` Linus Walleij 2016-04-29 9:31 ` Linus Walleij 2016-04-22 15:33 ` [PATCH 05/11] ARM: socfpga: dts: Add SPI Master1 for Arria10 System Resource chip tthayer 2016-04-22 15:33 ` tthayer 2016-04-22 15:33 ` [PATCH 06/11] ARM: socfpga: dts: Add Devkit A10-SR fields for Arria10 tthayer 2016-04-22 15:33 ` tthayer 2016-04-22 15:33 ` [PATCH 07/11] ARM: socfpga: dts: Add LED framework to A10-SR GPIO tthayer 2016-04-22 15:33 ` tthayer 2016-04-22 15:33 ` [PATCH 08/11] dt-bindings: mfd: Add Altera A10-SR power supply alarm tthayer 2016-04-22 15:33 ` tthayer 2016-04-25 12:57 ` Rob Herring 2016-04-25 12:58 ` Rob Herring 2016-04-25 15:04 ` Thor Thayer 2016-04-25 15:04 ` Thor Thayer 2016-04-22 15:33 ` [PATCH 09/11] mfd: altr_a10sr: Add Altera A10-SR power supply alarms tthayer 2016-04-22 15:33 ` tthayer 2016-05-09 15:53 ` Lee Jones 2016-05-09 15:55 ` Lee Jones 2016-05-09 15:56 ` Lee Jones [this message] 2016-05-09 15:56 ` Lee Jones 2016-04-22 15:33 ` [PATCH 10/11] hwmon: " tthayer 2016-04-22 15:33 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 2016-04-22 22:24 ` Guenter Roeck 2016-04-22 22:24 ` Guenter Roeck 2016-04-25 14:41 ` Thor Thayer 2016-04-25 14:41 ` Thor Thayer 2016-04-25 14:58 ` Guenter Roeck 2016-04-25 15:18 ` Thor Thayer 2016-04-25 15:18 ` Thor Thayer 2016-04-22 15:33 ` [PATCH 11/11] ARM: socfpga: dts: Add A10-SR Devkit " tthayer 2016-04-22 15:33 ` tthayer 2016-04-26 13:51 ` [PATCH 01/11] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings Thor Thayer 2016-04-26 13:54 ` Thor Thayer 2016-05-09 16:44 ` [PATCH 03/11] mfd: altr_a10sr: Add Altera Arria10 DevKit System Resource Chip Thor Thayer 2016-05-09 16:48 ` Thor Thayer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160509155616.GE19473@dell \ --to=lee.jones@linaro.org \ --cc=linux-hwmon@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.