From: Andy Gross <andy.gross@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
devicetree@vger.kernel.org, jilai wang <jilaiw@codeaurora.org>
Subject: Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS
Date: Mon, 16 May 2016 00:08:04 -0500 [thread overview]
Message-ID: <20160516050804.GB32019@hector> (raw)
In-Reply-To: <20160513234852.GH1256@tuxbot>
On Fri, May 13, 2016 at 04:48:52PM -0700, Bjorn Andersson wrote:
> > + cmd->len = cpu_to_le32(alloc_len);
> > + cmd->buf_offset = cpu_to_le32(sizeof(*cmd));
> > + cmd->resp_hdr_offset = cpu_to_le32(sizeof(*cmd) + cmd_len);
> > +
> > cmd->id = cpu_to_le32((svc_id << 10) | cmd_id);
> > if (cmd_buf)
> > - memcpy(qcom_scm_get_command_buffer(cmd), cmd_buf, cmd_len);
> > + memcpy(cmd->buf, cmd_buf, cmd_len);
> > +
> > + rsp = (void *)cmd->buf + le32_to_cpu(cmd->resp_hdr_offset);
>
> I believe resp_hdr_offset counts from the beginning of the buffer and
> that this therefor is supposed to be:
>
> rsp = (void *)cmd + le32_to_cpu(cmd->resp_hdr_offset);
>
> With that corrected, feel free to add:
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
I'll fix that up. Thanks for the review.
Andy
WARNING: multiple messages have this Message-ID (diff)
From: andy.gross@linaro.org (Andy Gross)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS
Date: Mon, 16 May 2016 00:08:04 -0500 [thread overview]
Message-ID: <20160516050804.GB32019@hector> (raw)
In-Reply-To: <20160513234852.GH1256@tuxbot>
On Fri, May 13, 2016 at 04:48:52PM -0700, Bjorn Andersson wrote:
> > + cmd->len = cpu_to_le32(alloc_len);
> > + cmd->buf_offset = cpu_to_le32(sizeof(*cmd));
> > + cmd->resp_hdr_offset = cpu_to_le32(sizeof(*cmd) + cmd_len);
> > +
> > cmd->id = cpu_to_le32((svc_id << 10) | cmd_id);
> > if (cmd_buf)
> > - memcpy(qcom_scm_get_command_buffer(cmd), cmd_buf, cmd_len);
> > + memcpy(cmd->buf, cmd_buf, cmd_len);
> > +
> > + rsp = (void *)cmd->buf + le32_to_cpu(cmd->resp_hdr_offset);
>
> I believe resp_hdr_offset counts from the beginning of the buffer and
> that this therefor is supposed to be:
>
> rsp = (void *)cmd + le32_to_cpu(cmd->resp_hdr_offset);
>
> With that corrected, feel free to add:
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
I'll fix that up. Thanks for the review.
Andy
next prev parent reply other threads:[~2016-05-16 5:08 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 3:46 [Patch v5 0/8] Qualcomm SCM Rework Andy Gross
2016-05-13 3:46 ` Andy Gross
2016-05-13 3:46 ` Andy Gross
2016-05-13 3:46 ` [Patch v5 1/8] dt/bindings: firmware: Add Qualcomm SCM binding Andy Gross
2016-05-13 3:46 ` Andy Gross
2016-05-13 23:32 ` Bjorn Andersson
2016-05-13 23:32 ` Bjorn Andersson
2016-05-16 16:09 ` Rob Herring
2016-05-16 16:09 ` Rob Herring
2016-06-02 22:14 ` Stephen Boyd
2016-06-02 22:14 ` Stephen Boyd
2016-05-13 3:46 ` [Patch v5 2/8] firmware: qcom: scm: Convert SCM to platform driver Andy Gross
2016-05-13 3:46 ` Andy Gross
2016-05-13 3:46 ` Andy Gross
2016-05-13 23:33 ` Bjorn Andersson
2016-05-13 23:33 ` Bjorn Andersson
2016-06-02 22:14 ` Stephen Boyd
2016-06-02 22:14 ` Stephen Boyd
2016-06-03 3:45 ` Andy Gross
2016-06-03 3:45 ` Andy Gross
2016-05-13 3:46 ` [Patch v5 3/8] firmware: qcom: scm: Use atomic SCM for cold boot Andy Gross
2016-05-13 3:46 ` Andy Gross
2016-05-13 23:37 ` Bjorn Andersson
2016-05-13 23:37 ` Bjorn Andersson
[not found] ` <1463111221-6963-4-git-send-email-andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-06-02 22:15 ` Stephen Boyd
2016-06-02 22:15 ` Stephen Boyd
2016-06-02 22:15 ` Stephen Boyd
2016-05-13 3:46 ` [Patch v5 4/8] firmware: qcom: scm: Generalize shared error map Andy Gross
2016-05-13 3:46 ` Andy Gross
2016-05-13 3:46 ` Andy Gross
2016-05-13 3:46 ` [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Andy Gross
2016-05-13 3:46 ` Andy Gross
2016-05-13 23:48 ` Bjorn Andersson
2016-05-13 23:48 ` Bjorn Andersson
2016-05-16 5:08 ` Andy Gross [this message]
2016-05-16 5:08 ` Andy Gross
2016-05-23 19:26 ` Kevin Hilman
2016-05-23 19:26 ` Kevin Hilman
2016-05-23 21:02 ` Andy Gross
2016-05-23 21:02 ` Andy Gross
2016-05-25 3:37 ` Andy Gross
2016-05-25 3:37 ` Andy Gross
2016-05-25 20:50 ` Kevin Hilman
2016-05-25 20:50 ` Kevin Hilman
[not found] ` <7hbn3tg8ul.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-05-25 21:15 ` Andy Gross
2016-05-25 21:15 ` Andy Gross
2016-05-25 21:15 ` Andy Gross
2016-06-02 23:26 ` Stephen Boyd
2016-06-02 23:26 ` Stephen Boyd
2016-06-03 3:57 ` Andy Gross
2016-06-03 3:57 ` Andy Gross
2016-05-13 3:46 ` [Patch v5 6/8] firmware: qcom: scm: Add support for ARM64 SoCs Andy Gross
2016-05-13 3:46 ` Andy Gross
2016-05-13 23:50 ` Bjorn Andersson
2016-05-13 23:50 ` Bjorn Andersson
2016-06-02 22:28 ` Stephen Boyd
2016-06-02 22:28 ` Stephen Boyd
2016-06-03 3:48 ` Andy Gross
2016-06-03 3:48 ` Andy Gross
2016-05-13 3:47 ` [Patch v5 7/8] dts: qcom: apq8084: Add SCM firmware node Andy Gross
2016-05-13 3:47 ` Andy Gross
2016-06-02 22:28 ` Stephen Boyd
2016-06-02 22:28 ` Stephen Boyd
2016-05-13 3:47 ` [Patch v5 8/8] arm64: dts: msm8916: " Andy Gross
2016-05-13 3:47 ` Andy Gross
2016-06-02 22:29 ` Stephen Boyd
2016-06-02 22:29 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516050804.GB32019@hector \
--to=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jilaiw@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.