From: Stephen Boyd <sboyd@codeaurora.org> To: Andy Gross <andy.gross@linaro.org> Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>, devicetree@vger.kernel.org, jilai wang <jilaiw@codeaurora.org> Subject: Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Date: Thu, 2 Jun 2016 16:26:02 -0700 [thread overview] Message-ID: <20160602232602.GS28218@codeaurora.org> (raw) In-Reply-To: <1463111221-6963-6-git-send-email-andy.gross@linaro.org> On 05/12, Andy Gross wrote: > This patch converts the Qualcomm SCM driver to use the streaming DMA APIs > for communication buffers. Yes, but why? > > Signed-off-by: Andy Gross <andy.gross@linaro.org> > --- > drivers/firmware/qcom_scm-32.c | 189 +++++++++++------------------------------ > drivers/firmware/qcom_scm.c | 6 +- > drivers/firmware/qcom_scm.h | 10 ++- > 3 files changed, 59 insertions(+), 146 deletions(-) > > diff --git a/drivers/firmware/qcom_scm-32.c b/drivers/firmware/qcom_scm-32.c > index 4388d13..e92bf7a 100644 > --- a/drivers/firmware/qcom_scm-32.c > +++ b/drivers/firmware/qcom_scm-32.c > @@ -64,11 +63,11 @@ static DEFINE_MUTEX(qcom_scm_lock); > * > * ------------------- <--- struct qcom_scm_command > * | command header | > - * ------------------- <--- qcom_scm_get_command_buffer() > + * ------------------- <--- buf[0] > * | command buffer | > - * ------------------- <--- struct qcom_scm_response and > - * | response header | qcom_scm_command_to_response() > - * ------------------- <--- qcom_scm_get_response_buffer() > + * ------------------- <--- struct qcom_scm_response > + * | response header | > + * ------------------- You don't like my convenience functions? :) I always thought qcom_scm_get_response_buffer() read better than (void *)cmd->buf + le32_to_cpu(cmd->resp_hdr_offset); > * | response buffer | > * ------------------- > * > @@ -96,79 +95,7 @@ struct qcom_scm_response { > __le32 is_complete; > }; > > - > -/** > - * free_qcom_scm_command() - Free an SCM command > - * @cmd: command to free > - * > - * Free an SCM command. > - */ > -static inline void free_qcom_scm_command(struct qcom_scm_command *cmd) > -{ > - kfree(cmd); > -} > - > -/** > - * qcom_scm_command_to_response() - Get a pointer to a qcom_scm_response > - * @cmd: command > - * > - * Returns a pointer to a response for a command. > - */ > -static inline struct qcom_scm_response *qcom_scm_command_to_response( > - const struct qcom_scm_command *cmd) > -{ > - return (void *)cmd + le32_to_cpu(cmd->resp_hdr_offset); > -} > - > -/** > - * qcom_scm_get_command_buffer() - Get a pointer to a command buffer > - * @cmd: command > - * > - * Returns a pointer to the command buffer of a command. > - */ > -static inline void *qcom_scm_get_command_buffer(const struct qcom_scm_command *cmd) > -{ > - return (void *)cmd->buf; > -} > - > -/** > - * qcom_scm_get_response_buffer() - Get a pointer to a response buffer > - * @rsp: response > - * > - * Returns a pointer to a response buffer of a response. > - */ > -static inline void *qcom_scm_get_response_buffer(const struct qcom_scm_response *rsp) > -{ > - return (void *)rsp + le32_to_cpu(rsp->buf_offset); > -} At the least the diff would be more concentrated on what really is happening in this patch if we left these functions as is. > - > -static u32 smc(u32 cmd_addr) > +static u32 smc(dma_addr_t cmd_addr) Please leave this as u32, the interface doesn't support anything wider here so we shouldn't let this change on LPAE. > { > int context_id; > register u32 r0 asm("r0") = 1; > @@ -192,45 +119,9 @@ static u32 smc(u32 cmd_addr) > return r0; > } > > -static int __qcom_scm_call(const struct qcom_scm_command *cmd) > -{ > - int ret; > - u32 cmd_addr = virt_to_phys(cmd); > - > - /* > - * Flush the command buffer so that the secure world sees > - * the correct data. > - */ > - secure_flush_area(cmd, cmd->len); Yay we should delete secure_flush_area() too. > - > - ret = smc(cmd_addr); > - if (ret < 0) > - ret = qcom_scm_remap_error(ret); > - > - return ret; > -} > - > - > @@ -143,7 +143,7 @@ int qcom_scm_hdcp_req(struct qcom_scm_hdcp_req *req, u32 req_cnt, u32 *resp) > if (ret) > return ret; > > - ret = __qcom_scm_hdcp_req(req, req_cnt, resp); > + ret = __qcom_scm_hdcp_req(__scm->dev, req, req_cnt, resp); Hmm maybe we should pass __scm instead of dev? Is there any advantage to that? > qcom_scm_clk_disable(); > return ret; > } -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd) To: linux-arm-kernel@lists.infradead.org Subject: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Date: Thu, 2 Jun 2016 16:26:02 -0700 [thread overview] Message-ID: <20160602232602.GS28218@codeaurora.org> (raw) In-Reply-To: <1463111221-6963-6-git-send-email-andy.gross@linaro.org> On 05/12, Andy Gross wrote: > This patch converts the Qualcomm SCM driver to use the streaming DMA APIs > for communication buffers. Yes, but why? > > Signed-off-by: Andy Gross <andy.gross@linaro.org> > --- > drivers/firmware/qcom_scm-32.c | 189 +++++++++++------------------------------ > drivers/firmware/qcom_scm.c | 6 +- > drivers/firmware/qcom_scm.h | 10 ++- > 3 files changed, 59 insertions(+), 146 deletions(-) > > diff --git a/drivers/firmware/qcom_scm-32.c b/drivers/firmware/qcom_scm-32.c > index 4388d13..e92bf7a 100644 > --- a/drivers/firmware/qcom_scm-32.c > +++ b/drivers/firmware/qcom_scm-32.c > @@ -64,11 +63,11 @@ static DEFINE_MUTEX(qcom_scm_lock); > * > * ------------------- <--- struct qcom_scm_command > * | command header | > - * ------------------- <--- qcom_scm_get_command_buffer() > + * ------------------- <--- buf[0] > * | command buffer | > - * ------------------- <--- struct qcom_scm_response and > - * | response header | qcom_scm_command_to_response() > - * ------------------- <--- qcom_scm_get_response_buffer() > + * ------------------- <--- struct qcom_scm_response > + * | response header | > + * ------------------- You don't like my convenience functions? :) I always thought qcom_scm_get_response_buffer() read better than (void *)cmd->buf + le32_to_cpu(cmd->resp_hdr_offset); > * | response buffer | > * ------------------- > * > @@ -96,79 +95,7 @@ struct qcom_scm_response { > __le32 is_complete; > }; > > - > -/** > - * free_qcom_scm_command() - Free an SCM command > - * @cmd: command to free > - * > - * Free an SCM command. > - */ > -static inline void free_qcom_scm_command(struct qcom_scm_command *cmd) > -{ > - kfree(cmd); > -} > - > -/** > - * qcom_scm_command_to_response() - Get a pointer to a qcom_scm_response > - * @cmd: command > - * > - * Returns a pointer to a response for a command. > - */ > -static inline struct qcom_scm_response *qcom_scm_command_to_response( > - const struct qcom_scm_command *cmd) > -{ > - return (void *)cmd + le32_to_cpu(cmd->resp_hdr_offset); > -} > - > -/** > - * qcom_scm_get_command_buffer() - Get a pointer to a command buffer > - * @cmd: command > - * > - * Returns a pointer to the command buffer of a command. > - */ > -static inline void *qcom_scm_get_command_buffer(const struct qcom_scm_command *cmd) > -{ > - return (void *)cmd->buf; > -} > - > -/** > - * qcom_scm_get_response_buffer() - Get a pointer to a response buffer > - * @rsp: response > - * > - * Returns a pointer to a response buffer of a response. > - */ > -static inline void *qcom_scm_get_response_buffer(const struct qcom_scm_response *rsp) > -{ > - return (void *)rsp + le32_to_cpu(rsp->buf_offset); > -} At the least the diff would be more concentrated on what really is happening in this patch if we left these functions as is. > - > -static u32 smc(u32 cmd_addr) > +static u32 smc(dma_addr_t cmd_addr) Please leave this as u32, the interface doesn't support anything wider here so we shouldn't let this change on LPAE. > { > int context_id; > register u32 r0 asm("r0") = 1; > @@ -192,45 +119,9 @@ static u32 smc(u32 cmd_addr) > return r0; > } > > -static int __qcom_scm_call(const struct qcom_scm_command *cmd) > -{ > - int ret; > - u32 cmd_addr = virt_to_phys(cmd); > - > - /* > - * Flush the command buffer so that the secure world sees > - * the correct data. > - */ > - secure_flush_area(cmd, cmd->len); Yay we should delete secure_flush_area() too. > - > - ret = smc(cmd_addr); > - if (ret < 0) > - ret = qcom_scm_remap_error(ret); > - > - return ret; > -} > - > - > @@ -143,7 +143,7 @@ int qcom_scm_hdcp_req(struct qcom_scm_hdcp_req *req, u32 req_cnt, u32 *resp) > if (ret) > return ret; > > - ret = __qcom_scm_hdcp_req(req, req_cnt, resp); > + ret = __qcom_scm_hdcp_req(__scm->dev, req, req_cnt, resp); Hmm maybe we should pass __scm instead of dev? Is there any advantage to that? > qcom_scm_clk_disable(); > return ret; > } -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-06-02 23:26 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-13 3:46 [Patch v5 0/8] Qualcomm SCM Rework Andy Gross 2016-05-13 3:46 ` Andy Gross 2016-05-13 3:46 ` Andy Gross 2016-05-13 3:46 ` [Patch v5 1/8] dt/bindings: firmware: Add Qualcomm SCM binding Andy Gross 2016-05-13 3:46 ` Andy Gross 2016-05-13 23:32 ` Bjorn Andersson 2016-05-13 23:32 ` Bjorn Andersson 2016-05-16 16:09 ` Rob Herring 2016-05-16 16:09 ` Rob Herring 2016-06-02 22:14 ` Stephen Boyd 2016-06-02 22:14 ` Stephen Boyd 2016-05-13 3:46 ` [Patch v5 2/8] firmware: qcom: scm: Convert SCM to platform driver Andy Gross 2016-05-13 3:46 ` Andy Gross 2016-05-13 3:46 ` Andy Gross 2016-05-13 23:33 ` Bjorn Andersson 2016-05-13 23:33 ` Bjorn Andersson 2016-06-02 22:14 ` Stephen Boyd 2016-06-02 22:14 ` Stephen Boyd 2016-06-03 3:45 ` Andy Gross 2016-06-03 3:45 ` Andy Gross 2016-05-13 3:46 ` [Patch v5 3/8] firmware: qcom: scm: Use atomic SCM for cold boot Andy Gross 2016-05-13 3:46 ` Andy Gross 2016-05-13 23:37 ` Bjorn Andersson 2016-05-13 23:37 ` Bjorn Andersson [not found] ` <1463111221-6963-4-git-send-email-andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-06-02 22:15 ` Stephen Boyd 2016-06-02 22:15 ` Stephen Boyd 2016-06-02 22:15 ` Stephen Boyd 2016-05-13 3:46 ` [Patch v5 4/8] firmware: qcom: scm: Generalize shared error map Andy Gross 2016-05-13 3:46 ` Andy Gross 2016-05-13 3:46 ` Andy Gross 2016-05-13 3:46 ` [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Andy Gross 2016-05-13 3:46 ` Andy Gross 2016-05-13 23:48 ` Bjorn Andersson 2016-05-13 23:48 ` Bjorn Andersson 2016-05-16 5:08 ` Andy Gross 2016-05-16 5:08 ` Andy Gross 2016-05-23 19:26 ` Kevin Hilman 2016-05-23 19:26 ` Kevin Hilman 2016-05-23 21:02 ` Andy Gross 2016-05-23 21:02 ` Andy Gross 2016-05-25 3:37 ` Andy Gross 2016-05-25 3:37 ` Andy Gross 2016-05-25 20:50 ` Kevin Hilman 2016-05-25 20:50 ` Kevin Hilman [not found] ` <7hbn3tg8ul.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 2016-05-25 21:15 ` Andy Gross 2016-05-25 21:15 ` Andy Gross 2016-05-25 21:15 ` Andy Gross 2016-06-02 23:26 ` Stephen Boyd [this message] 2016-06-02 23:26 ` Stephen Boyd 2016-06-03 3:57 ` Andy Gross 2016-06-03 3:57 ` Andy Gross 2016-05-13 3:46 ` [Patch v5 6/8] firmware: qcom: scm: Add support for ARM64 SoCs Andy Gross 2016-05-13 3:46 ` Andy Gross 2016-05-13 23:50 ` Bjorn Andersson 2016-05-13 23:50 ` Bjorn Andersson 2016-06-02 22:28 ` Stephen Boyd 2016-06-02 22:28 ` Stephen Boyd 2016-06-03 3:48 ` Andy Gross 2016-06-03 3:48 ` Andy Gross 2016-05-13 3:47 ` [Patch v5 7/8] dts: qcom: apq8084: Add SCM firmware node Andy Gross 2016-05-13 3:47 ` Andy Gross 2016-06-02 22:28 ` Stephen Boyd 2016-06-02 22:28 ` Stephen Boyd 2016-05-13 3:47 ` [Patch v5 8/8] arm64: dts: msm8916: " Andy Gross 2016-05-13 3:47 ` Andy Gross 2016-06-02 22:29 ` Stephen Boyd 2016-06-02 22:29 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160602232602.GS28218@codeaurora.org \ --to=sboyd@codeaurora.org \ --cc=andy.gross@linaro.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=jilaiw@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.