All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Paauwe <bob.j.paauwe@intel.com>
To: Vidya Srinivas <vidya.srinivas@intel.com>
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/9] drm/i915: Check for platform specific GPIO config
Date: Wed, 15 Feb 2017 10:05:51 -0800	[thread overview]
Message-ID: <20170215100551.721a629b@bpaauwe-desk.fm.intel.com> (raw)
In-Reply-To: <1486551058-22596-2-git-send-email-vidya.srinivas@intel.com>

On Wed, 8 Feb 2017 16:20:50 +0530
Vidya Srinivas <vidya.srinivas@intel.com> wrote:

> From: Uma Shankar <uma.shankar@intel.com>
> 
> Panel GPIO control should be done based on platform. Add a check
> to restrict VLV and CHT specific GPIO confirguration, so that
> they dont apply to other platforms.
> 
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dsi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index c98234e..c297ea9 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -1584,7 +1584,8 @@ void intel_dsi_init(struct drm_i915_private *dev_priv)
>  	 * In case of BYT with CRC PMIC, we need to use GPIO for
>  	 * Panel control.
>  	 */
> -	if (dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC) {
> +	if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
> +		(dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC)) {
>  		intel_dsi->gpio_panel =
>  			gpiod_get(dev->dev, "panel", GPIOD_OUT_HIGH);
>  

It makes sense to restrict this as it isn't valid for other platforms
as written. But is there something similar for other platforms that we
should set up here?

Since it makes sense to limit this today..
Reviewed-by: Bob Paauwe <bob.j.paauwe@intel.com>

-- 
--
Bob Paauwe                  
Bob.J.Paauwe@intel.com
IOTG / PED Software Organization
Intel Corp.  Folsom, CA
(916) 356-6193    

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-02-15 18:06 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-08 10:50 [PATCH 0/9] Broxton DSI dual-link and sequence fixes Vidya Srinivas
2017-02-08 10:50 ` [PATCH 1/9] drm/i915: Check for platform specific GPIO config Vidya Srinivas
2017-02-15 18:05   ` Bob Paauwe [this message]
2017-02-08 10:50 ` [PATCH 2/9] drm/i915: Fix PLL 8x/3 divider for MIPI video mode Vidya Srinivas
2017-02-15 15:34   ` Jani Nikula
2017-02-08 10:50 ` [PATCH 3/9] drm: Add DSI panel power on/off sequence programming Vidya Srinivas
2017-02-08 10:50 ` [PATCH 4/9] drm/i915: Add DSI panel power on/off sequence callbacks Vidya Srinivas
2017-02-15 18:44   ` Bob Paauwe
2017-02-08 10:50 ` [PATCH 5/9] drm/i915/bxt: Fix BXT DSI ULPS sequence Vidya Srinivas
2017-02-15 18:11   ` Bob Paauwe
2017-02-16 15:23     ` Jani Nikula
2017-02-08 10:50 ` [PATCH 6/9] drm/i915/bxt: Fix BXT DSI disable sequence Vidya Srinivas
2017-02-15 18:24   ` Bob Paauwe
2017-02-20  9:39     ` Srinivas, Vidya
2017-02-08 10:50 ` [PATCH 7/9] drm/i915/bxt: Disable device ready before shutdown command Vidya Srinivas
2017-02-15 18:27   ` Bob Paauwe
2017-02-16 15:23     ` Jani Nikula
2017-02-08 10:50 ` [PATCH 8/9] drm/i915/bxt: Enable BXT DSI dual link Vidya Srinivas
2017-02-15 18:33   ` Bob Paauwe
2017-02-16 15:26     ` Jani Nikula
2017-02-20  9:49       ` Srinivas, Vidya
2017-02-20 11:00         ` Jani Nikula
2017-02-20 11:40           ` Hans de Goede
2017-02-20 11:55             ` Jani Nikula
2017-02-20 19:19             ` Jani Nikula
2017-02-21  6:21               ` Srinivas, Vidya
2017-02-21  7:30                 ` Hans de Goede
2017-02-08 10:50 ` [PATCH 9/9] drm/i915/bxt: Fix the DSI enable sequence Vidya Srinivas
2017-02-15 19:00   ` Bob Paauwe
2017-02-20  9:43     ` Srinivas, Vidya
2017-02-08 11:02 ` ✓ Fi.CI.BAT: success for Broxton DSI dual-link and sequence fixes Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170215100551.721a629b@bpaauwe-desk.fm.intel.com \
    --to=bob.j.paauwe@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=vidya.srinivas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.