From: Mark Brown <broonie@kernel.org> To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com> Cc: gnurou@gmail.com, alsa-devel@alsa-project.org, jason@lakedaemon.net, devicetree@vger.kernel.org, linus.walleij@linaro.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, robh+dt@kernel.org, tglx@linutronix.de, lee.jones@linaro.org Subject: Re: [PATCH 07/16] regulator: madera-micsupp: Mic supply for Cirrus Logic Madera codecs Date: Thu, 6 Apr 2017 11:57:44 +0100 [thread overview] Message-ID: <20170406105744.f5qpmmi2pjvc7n2z@sirena.org.uk> (raw) In-Reply-To: <1491400437.4096.5.camel@rf-debian.wolfsonmicro.main> [-- Attachment #1.1: Type: text/plain, Size: 650 bytes --] On Wed, Apr 05, 2017 at 02:53:57PM +0100, Richard Fitzgerald wrote: > On Wed, 2017-04-05 at 14:40 +0100, Mark Brown wrote: > > Again, this appears to have only data and minor code style changes > > relative to the existing arizona driver - is there no opportunity for > > code sharing here? > I'll have a look at how it would work out. > My thought was that these two regulator drivers are so small it wasn't > worth creating an entanglement between arizona and madera for so little > code. It's a fairly small amount of code but it's an extremely high proportion of the code in the driver and doing something a bit unusual, not just boilerplate. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com> Cc: linus.walleij@linaro.org, gnurou@gmail.com, robh+dt@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, lee.jones@linaro.org, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/16] regulator: madera-micsupp: Mic supply for Cirrus Logic Madera codecs Date: Thu, 6 Apr 2017 11:57:44 +0100 [thread overview] Message-ID: <20170406105744.f5qpmmi2pjvc7n2z@sirena.org.uk> (raw) In-Reply-To: <1491400437.4096.5.camel@rf-debian.wolfsonmicro.main> [-- Attachment #1: Type: text/plain, Size: 650 bytes --] On Wed, Apr 05, 2017 at 02:53:57PM +0100, Richard Fitzgerald wrote: > On Wed, 2017-04-05 at 14:40 +0100, Mark Brown wrote: > > Again, this appears to have only data and minor code style changes > > relative to the existing arizona driver - is there no opportunity for > > code sharing here? > I'll have a look at how it would work out. > My thought was that these two regulator drivers are so small it wasn't > worth creating an entanglement between arizona and madera for so little > code. It's a fairly small amount of code but it's an extremely high proportion of the code in the driver and doing something a bit unusual, not just boilerplate. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-04-06 10:57 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-05 10:07 [PATCH 00/16] Add support for Cirrus Logic CS47L35/L85/L90/L91 codecs Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-05 10:07 ` [PATCH 01/16] mfd: madera: Add register definitions for Cirrus Logic Madera codecs Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-07 8:27 ` Linus Walleij 2017-04-07 8:27 ` Linus Walleij 2017-04-07 8:30 ` Linus Walleij 2017-04-07 8:30 ` Linus Walleij 2017-04-07 8:48 ` Charles Keepax 2017-04-07 8:48 ` Charles Keepax 2017-04-07 9:12 ` Linus Walleij 2017-04-07 9:12 ` Linus Walleij [not found] ` <CACRpkdZLfL+dxMN-uaRp57u4yW4cLfLFoZVkNWFZL4eECOyR1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-07 11:14 ` Mark Brown 2017-04-07 11:14 ` Mark Brown 2017-04-12 12:06 ` Lee Jones 2017-04-05 10:07 ` [PATCH 02/16] mfd: madera: Add common support " Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-12 12:54 ` Lee Jones 2017-04-19 16:42 ` Richard Fitzgerald 2017-04-19 16:42 ` Richard Fitzgerald [not found] ` <1492620124.4826.47.camel-WeElTRBN8n0bEPBeyYQi64iQ8/zYDDdY1BehtkLrGTY@public.gmane.org> 2017-04-24 10:03 ` Lee Jones 2017-04-24 10:03 ` Lee Jones 2017-04-05 10:07 ` [PATCH 03/16] mfd: madera: Register map tables for Cirrus Logic CS47L35 Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-12 13:30 ` Lee Jones 2017-04-05 10:07 ` [PATCH 04/16] mfd: madera: Register map tables for Cirrus Logic CS47L85 Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-12 13:31 ` Lee Jones 2017-04-05 10:07 ` [PATCH 05/16] mfd: madera: Register map tables for Cirrus Logic CS47L90/91 Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald [not found] ` <1491386884-30689-6-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> 2017-04-12 13:31 ` Lee Jones 2017-04-12 13:31 ` Lee Jones 2017-04-05 10:07 ` [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus Logic Madera codecs Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-05 13:28 ` Mark Brown 2017-04-05 13:28 ` Mark Brown 2017-04-10 17:49 ` Rob Herring 2017-04-10 18:11 ` Mark Brown 2017-04-10 18:11 ` Mark Brown [not found] ` <20170410181136.btpvcat2ijwiebvm-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2017-04-11 19:20 ` Rob Herring 2017-04-11 19:20 ` Rob Herring [not found] ` <CAL_JsqLYi8txm2xb5emGvbC0P2cvtW2wXLdA=2qCO-wt_4JXXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-11 20:03 ` Mark Brown 2017-04-11 20:03 ` Mark Brown 2017-04-05 10:07 ` [PATCH 07/16] regulator: madera-micsupp: Mic supply " Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-05 13:40 ` Mark Brown 2017-04-05 13:40 ` Mark Brown 2017-04-05 13:53 ` Richard Fitzgerald 2017-04-05 13:53 ` Richard Fitzgerald 2017-04-06 10:57 ` Mark Brown [this message] 2017-04-06 10:57 ` Mark Brown 2017-04-05 10:07 ` [PATCH 08/16] irqchip: Add driver " Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-10 17:53 ` Rob Herring 2017-04-10 17:53 ` Rob Herring 2017-04-05 10:07 ` [PATCH 09/16] pinctrl: madera: " Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-07 8:54 ` Linus Walleij 2017-04-07 8:54 ` Linus Walleij [not found] ` <CACRpkdZK3QXu4t2jud0-LPDj0LDVruAm33N4Lazjk44C3ndwwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-07 9:43 ` Richard Fitzgerald 2017-04-07 9:43 ` Richard Fitzgerald 2017-04-10 17:56 ` Rob Herring 2017-04-10 17:56 ` Rob Herring 2017-04-05 10:07 ` [PATCH 10/16] gpio: madera: Support Cirrus Logic Madera class codecs Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-07 9:11 ` Linus Walleij 2017-04-07 9:11 ` Linus Walleij [not found] ` <CACRpkdatoJOg1U218Q-NteRdz6B+w_yr1PWvnfa1P1EgGm7zug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-07 9:54 ` Richard Fitzgerald 2017-04-07 9:54 ` Richard Fitzgerald 2017-04-05 10:07 ` [PATCH 11/16] ASoC: wm_adsp: Add support for ADSP2V2 Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-05 17:31 ` Applied "ASoC: wm_adsp: Add support for ADSP2V2" to the asoc tree Mark Brown 2017-04-05 17:31 ` Mark Brown 2017-04-05 10:08 ` [PATCH 12/16] ASoC: wm_adsp: add support for DSP region lock Richard Fitzgerald 2017-04-05 10:08 ` Richard Fitzgerald [not found] ` <1491386884-30689-13-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> 2017-04-05 17:31 ` Applied "ASoC: wm_adsp: add support for DSP region lock" to the asoc tree Mark Brown 2017-04-05 17:31 ` Mark Brown [not found] ` <1491386884-30689-1-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> 2017-04-05 10:08 ` [PATCH 13/16] ASoC: madera: Add common support for Cirrus Logic Madera codecs Richard Fitzgerald 2017-04-05 10:08 ` Richard Fitzgerald 2017-04-10 18:03 ` Rob Herring 2017-04-14 21:01 ` kbuild test robot 2017-04-14 21:01 ` kbuild test robot 2017-04-05 10:08 ` [PATCH 14/16] ASoC: cs47l35: Add codec driver for Cirrus Logic CS47L35 Richard Fitzgerald 2017-04-05 10:08 ` Richard Fitzgerald 2017-04-05 10:08 ` [PATCH 15/16] ASoC: cs47l85: Add codec driver for Cirrus Logic CS47L85 Richard Fitzgerald 2017-04-05 10:08 ` Richard Fitzgerald 2017-04-05 10:08 ` [PATCH 16/16] ASoC: cs47l90: Add codec driver for Cirrus Logic CS47L90 Richard Fitzgerald 2017-04-05 10:08 ` Richard Fitzgerald
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170406105744.f5qpmmi2pjvc7n2z@sirena.org.uk \ --to=broonie@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=devicetree@vger.kernel.org \ --cc=gnurou@gmail.com \ --cc=jason@lakedaemon.net \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=patches@opensource.wolfsonmicro.com \ --cc=rf@opensource.wolfsonmicro.com \ --cc=robh+dt@kernel.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.