From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Cc: Charles Keepax <ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>, Richard Fitzgerald <rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>, Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, "alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org" <alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org>, "open list:WOLFSON MICROELECTRONICS DRIVERS" <patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>, "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH 01/16] mfd: madera: Add register definitions for Cirrus Logic Madera codecs Date: Fri, 7 Apr 2017 12:14:58 +0100 [thread overview] Message-ID: <20170407111458.vw7oxemasqhcfepq@sirena.org.uk> (raw) In-Reply-To: <CACRpkdZLfL+dxMN-uaRp57u4yW4cLfLFoZVkNWFZL4eECOyR1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> [-- Attachment #1: Type: text/plain, Size: 1385 bytes --] On Fri, Apr 07, 2017 at 11:12:53AM +0200, Linus Walleij wrote: > On Fri, Apr 7, 2017 at 10:48 AM, Charles Keepax > > On Fri, Apr 07, 2017 at 10:30:12AM +0200, Linus Walleij wrote: > >> > Get included in all subdrivers I suppose? > >> > So you are broadcasting 8800+ lines into every subdriver across the > >> > entire kernel. > >> > Just the time spent in the preprocessor parsing this will affect compilation > >> > time. > >> Or maybe this is a necessary sacrifice to get the regmap cache > >> centralized in MFD. I don't know. I feel stupid. > >> I guess I should focus on "my" subsystems... > > This only gets included in files that are part of this driver, it > > shouldn't affect compilation time for anyone not building the > > madera driver and even then it should only affect compilation > > times for the 10 or so C files that make up the driver. Also I > > don't really see any other way to specify the registers for the > > device. > No when using regmap cache this seems necessary. > I was just wrong. Right. The other thing to bear in mind with things like this is that often if it's the chip vendor they've got mechanisms to generate the register definitions directly from the chip design so if we take the complete thing with minimal edits it's a great way of ensuring we've got information about the chip in the upstream kernel to support future development. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Linus Walleij <linus.walleij@linaro.org> Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>, Richard Fitzgerald <rf@opensource.wolfsonmicro.com>, Alexandre Courbot <gnurou@gmail.com>, Rob Herring <robh+dt@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, Lee Jones <lee.jones@linaro.org>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, "open list:WOLFSON MICROELECTRONICS DRIVERS" <patches@opensource.wolfsonmicro.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 01/16] mfd: madera: Add register definitions for Cirrus Logic Madera codecs Date: Fri, 7 Apr 2017 12:14:58 +0100 [thread overview] Message-ID: <20170407111458.vw7oxemasqhcfepq@sirena.org.uk> (raw) In-Reply-To: <CACRpkdZLfL+dxMN-uaRp57u4yW4cLfLFoZVkNWFZL4eECOyR1A@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 1385 bytes --] On Fri, Apr 07, 2017 at 11:12:53AM +0200, Linus Walleij wrote: > On Fri, Apr 7, 2017 at 10:48 AM, Charles Keepax > > On Fri, Apr 07, 2017 at 10:30:12AM +0200, Linus Walleij wrote: > >> > Get included in all subdrivers I suppose? > >> > So you are broadcasting 8800+ lines into every subdriver across the > >> > entire kernel. > >> > Just the time spent in the preprocessor parsing this will affect compilation > >> > time. > >> Or maybe this is a necessary sacrifice to get the regmap cache > >> centralized in MFD. I don't know. I feel stupid. > >> I guess I should focus on "my" subsystems... > > This only gets included in files that are part of this driver, it > > shouldn't affect compilation time for anyone not building the > > madera driver and even then it should only affect compilation > > times for the 10 or so C files that make up the driver. Also I > > don't really see any other way to specify the registers for the > > device. > No when using regmap cache this seems necessary. > I was just wrong. Right. The other thing to bear in mind with things like this is that often if it's the chip vendor they've got mechanisms to generate the register definitions directly from the chip design so if we take the complete thing with minimal edits it's a great way of ensuring we've got information about the chip in the upstream kernel to support future development. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-04-07 11:14 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-05 10:07 [PATCH 00/16] Add support for Cirrus Logic CS47L35/L85/L90/L91 codecs Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-05 10:07 ` [PATCH 01/16] mfd: madera: Add register definitions for Cirrus Logic Madera codecs Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-07 8:27 ` Linus Walleij 2017-04-07 8:27 ` Linus Walleij 2017-04-07 8:30 ` Linus Walleij 2017-04-07 8:30 ` Linus Walleij 2017-04-07 8:48 ` Charles Keepax 2017-04-07 8:48 ` Charles Keepax 2017-04-07 9:12 ` Linus Walleij 2017-04-07 9:12 ` Linus Walleij [not found] ` <CACRpkdZLfL+dxMN-uaRp57u4yW4cLfLFoZVkNWFZL4eECOyR1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-07 11:14 ` Mark Brown [this message] 2017-04-07 11:14 ` Mark Brown 2017-04-12 12:06 ` Lee Jones 2017-04-05 10:07 ` [PATCH 02/16] mfd: madera: Add common support " Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-12 12:54 ` Lee Jones 2017-04-19 16:42 ` Richard Fitzgerald 2017-04-19 16:42 ` Richard Fitzgerald [not found] ` <1492620124.4826.47.camel-WeElTRBN8n0bEPBeyYQi64iQ8/zYDDdY1BehtkLrGTY@public.gmane.org> 2017-04-24 10:03 ` Lee Jones 2017-04-24 10:03 ` Lee Jones 2017-04-05 10:07 ` [PATCH 03/16] mfd: madera: Register map tables for Cirrus Logic CS47L35 Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-12 13:30 ` Lee Jones 2017-04-05 10:07 ` [PATCH 04/16] mfd: madera: Register map tables for Cirrus Logic CS47L85 Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-12 13:31 ` Lee Jones 2017-04-05 10:07 ` [PATCH 05/16] mfd: madera: Register map tables for Cirrus Logic CS47L90/91 Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald [not found] ` <1491386884-30689-6-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> 2017-04-12 13:31 ` Lee Jones 2017-04-12 13:31 ` Lee Jones 2017-04-05 10:07 ` [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus Logic Madera codecs Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-05 13:28 ` Mark Brown 2017-04-05 13:28 ` Mark Brown 2017-04-10 17:49 ` Rob Herring 2017-04-10 18:11 ` Mark Brown 2017-04-10 18:11 ` Mark Brown [not found] ` <20170410181136.btpvcat2ijwiebvm-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2017-04-11 19:20 ` Rob Herring 2017-04-11 19:20 ` Rob Herring [not found] ` <CAL_JsqLYi8txm2xb5emGvbC0P2cvtW2wXLdA=2qCO-wt_4JXXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-11 20:03 ` Mark Brown 2017-04-11 20:03 ` Mark Brown 2017-04-05 10:07 ` [PATCH 07/16] regulator: madera-micsupp: Mic supply " Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-05 13:40 ` Mark Brown 2017-04-05 13:40 ` Mark Brown 2017-04-05 13:53 ` Richard Fitzgerald 2017-04-05 13:53 ` Richard Fitzgerald 2017-04-06 10:57 ` Mark Brown 2017-04-06 10:57 ` Mark Brown 2017-04-05 10:07 ` [PATCH 08/16] irqchip: Add driver " Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-10 17:53 ` Rob Herring 2017-04-10 17:53 ` Rob Herring 2017-04-05 10:07 ` [PATCH 09/16] pinctrl: madera: " Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-07 8:54 ` Linus Walleij 2017-04-07 8:54 ` Linus Walleij [not found] ` <CACRpkdZK3QXu4t2jud0-LPDj0LDVruAm33N4Lazjk44C3ndwwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-07 9:43 ` Richard Fitzgerald 2017-04-07 9:43 ` Richard Fitzgerald 2017-04-10 17:56 ` Rob Herring 2017-04-10 17:56 ` Rob Herring 2017-04-05 10:07 ` [PATCH 10/16] gpio: madera: Support Cirrus Logic Madera class codecs Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-07 9:11 ` Linus Walleij 2017-04-07 9:11 ` Linus Walleij [not found] ` <CACRpkdatoJOg1U218Q-NteRdz6B+w_yr1PWvnfa1P1EgGm7zug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-07 9:54 ` Richard Fitzgerald 2017-04-07 9:54 ` Richard Fitzgerald 2017-04-05 10:07 ` [PATCH 11/16] ASoC: wm_adsp: Add support for ADSP2V2 Richard Fitzgerald 2017-04-05 10:07 ` Richard Fitzgerald 2017-04-05 17:31 ` Applied "ASoC: wm_adsp: Add support for ADSP2V2" to the asoc tree Mark Brown 2017-04-05 17:31 ` Mark Brown 2017-04-05 10:08 ` [PATCH 12/16] ASoC: wm_adsp: add support for DSP region lock Richard Fitzgerald 2017-04-05 10:08 ` Richard Fitzgerald [not found] ` <1491386884-30689-13-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> 2017-04-05 17:31 ` Applied "ASoC: wm_adsp: add support for DSP region lock" to the asoc tree Mark Brown 2017-04-05 17:31 ` Mark Brown [not found] ` <1491386884-30689-1-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> 2017-04-05 10:08 ` [PATCH 13/16] ASoC: madera: Add common support for Cirrus Logic Madera codecs Richard Fitzgerald 2017-04-05 10:08 ` Richard Fitzgerald 2017-04-10 18:03 ` Rob Herring 2017-04-14 21:01 ` kbuild test robot 2017-04-14 21:01 ` kbuild test robot 2017-04-05 10:08 ` [PATCH 14/16] ASoC: cs47l35: Add codec driver for Cirrus Logic CS47L35 Richard Fitzgerald 2017-04-05 10:08 ` Richard Fitzgerald 2017-04-05 10:08 ` [PATCH 15/16] ASoC: cs47l85: Add codec driver for Cirrus Logic CS47L85 Richard Fitzgerald 2017-04-05 10:08 ` Richard Fitzgerald 2017-04-05 10:08 ` [PATCH 16/16] ASoC: cs47l90: Add codec driver for Cirrus Logic CS47L90 Richard Fitzgerald 2017-04-05 10:08 ` Richard Fitzgerald
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170407111458.vw7oxemasqhcfepq@sirena.org.uk \ --to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \ --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \ --cc=ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \ --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \ --cc=rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.