From: Rob Herring <robh@kernel.org> To: Eric Anholt <eric@anholt.net> Cc: dri-devel@lists.freedesktop.org, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3 v3] drm/vc4: Turn the V3D clock on at runtime. Date: Fri, 28 Apr 2017 13:29:13 -0500 [thread overview] Message-ID: <20170428182913.pv73xj45onxlnd3c@rob-hp-laptop> (raw) In-Reply-To: <20170424201209.31148-1-eric@anholt.net> On Mon, Apr 24, 2017 at 01:12:09PM -0700, Eric Anholt wrote: > For the Raspberry Pi's bindings, the power domain also implicitly > turns on the clock and deasserts reset, but for the new Cygnus port we > start representing the clock in the devicetree. > > v2: Document the clock-names property, check for -ENOENT for no clock > in DT. > v3: Drop NULL checks around clk calls which embed NULL checks. > > Signed-off-by: Eric Anholt <eric@anholt.net> > --- > .../devicetree/bindings/display/brcm,bcm-vc4.txt | 4 +++ > drivers/gpu/drm/vc4/vc4_drv.h | 1 + > drivers/gpu/drm/vc4/vc4_v3d.c | 31 +++++++++++++++++++++- > 3 files changed, 35 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt > index ca02d3e4db91..2318266f6481 100644 > --- a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt > +++ b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt > @@ -59,6 +59,10 @@ Required properties for V3D: > - interrupts: The interrupt number > See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt > > +Optional properties for V3D: > +- clocks: The clock the unit runs on > +- clock-names: Must be "v3d_clk" clock-names is pointless for a single clock. > + > Required properties for DSI: > - compatible: Should be "brcm,bcm2835-dsi0" or "brcm,bcm2835-dsi1" > - reg: Physical base address and length of the DSI block's registers
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Eric Anholt <eric@anholt.net> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/3 v3] drm/vc4: Turn the V3D clock on at runtime. Date: Fri, 28 Apr 2017 13:29:13 -0500 [thread overview] Message-ID: <20170428182913.pv73xj45onxlnd3c@rob-hp-laptop> (raw) In-Reply-To: <20170424201209.31148-1-eric@anholt.net> On Mon, Apr 24, 2017 at 01:12:09PM -0700, Eric Anholt wrote: > For the Raspberry Pi's bindings, the power domain also implicitly > turns on the clock and deasserts reset, but for the new Cygnus port we > start representing the clock in the devicetree. > > v2: Document the clock-names property, check for -ENOENT for no clock > in DT. > v3: Drop NULL checks around clk calls which embed NULL checks. > > Signed-off-by: Eric Anholt <eric@anholt.net> > --- > .../devicetree/bindings/display/brcm,bcm-vc4.txt | 4 +++ > drivers/gpu/drm/vc4/vc4_drv.h | 1 + > drivers/gpu/drm/vc4/vc4_v3d.c | 31 +++++++++++++++++++++- > 3 files changed, 35 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt > index ca02d3e4db91..2318266f6481 100644 > --- a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt > +++ b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt > @@ -59,6 +59,10 @@ Required properties for V3D: > - interrupts: The interrupt number > See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt > > +Optional properties for V3D: > +- clocks: The clock the unit runs on > +- clock-names: Must be "v3d_clk" clock-names is pointless for a single clock. > + > Required properties for DSI: > - compatible: Should be "brcm,bcm2835-dsi0" or "brcm,bcm2835-dsi1" > - reg: Physical base address and length of the DSI block's registers _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-04-28 18:29 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-18 19:11 [PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime Eric Anholt 2017-04-18 19:11 ` Eric Anholt 2017-04-18 19:11 ` [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D Eric Anholt 2017-04-18 19:11 ` Eric Anholt 2017-04-19 4:59 ` Daniel Vetter 2017-04-19 4:59 ` Daniel Vetter 2017-04-19 17:55 ` Eric Anholt 2017-04-19 17:55 ` Eric Anholt 2017-04-19 19:36 ` Daniel Vetter 2017-04-19 19:36 ` Daniel Vetter 2017-04-21 22:53 ` Eric Anholt 2017-04-21 22:53 ` Eric Anholt 2017-04-24 14:26 ` Alex Deucher 2017-04-24 14:26 ` Alex Deucher 2017-05-02 8:16 ` Daniel Vetter 2017-05-02 8:16 ` Daniel Vetter 2017-04-18 19:11 ` [PATCH 3/3] drm/vc4: Add specific compatible strings for Cygnus Eric Anholt 2017-04-18 19:11 ` Eric Anholt 2017-04-20 20:33 ` Rob Herring 2017-04-20 20:33 ` Rob Herring 2017-04-18 19:23 ` [PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime Eric Anholt 2017-04-18 19:23 ` Eric Anholt 2017-04-18 23:38 ` [PATCH 1/3 v2] " Eric Anholt 2017-04-18 23:38 ` Eric Anholt 2017-04-18 23:48 ` Florian Fainelli 2017-04-18 23:48 ` Florian Fainelli 2017-04-19 0:02 ` Eric Anholt 2017-04-19 0:02 ` Eric Anholt 2017-04-19 0:02 ` Eric Anholt 2017-04-19 0:02 ` Eric Anholt 2017-04-24 20:12 ` [PATCH 1/3 v3] " Eric Anholt 2017-04-24 20:12 ` Eric Anholt 2017-04-28 18:29 ` Rob Herring [this message] 2017-04-28 18:29 ` Rob Herring 2017-04-28 21:41 ` Eric Anholt 2017-04-28 21:41 ` Eric Anholt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170428182913.pv73xj45onxlnd3c@rob-hp-laptop \ --to=robh@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=eric@anholt.net \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.