All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net,
	linux-security-module@vger.kernel.org,
	jarkko.sakkinen@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] tpm: vtpm_proxy: Implement new ioctl to get supported flags
Date: Thu, 4 May 2017 09:34:16 -0600	[thread overview]
Message-ID: <20170504153416.GA15930@obsidianresearch.com> (raw)
In-Reply-To: <1493909787-1848-2-git-send-email-stefanb@linux.vnet.ibm.com>

On Thu, May 04, 2017 at 10:56:25AM -0400, Stefan Berger wrote:
> Implement VTPM_PROXY_IOC_GET_SUPT_FLAGS ioctl to get the bitmask
> of flags that the vtpm_proxy driver supports in the
> VTPM_PROXY_IOC_NEW_DEV ioctl. This helps user space in deciding
> which flags to set in that ioctl.

you might be better off just having a VTPM_PROXY_IO_ENABLE_FEATURE
.feature = LOCALITY

If that fails then the feature is not supported, no real need for the
query in that case.

Not sure about Jarkko's point on request/release locality.. Is there a
scenario where the emulator should fail the request locality?

Jason

WARNING: multiple messages have this Message-ID (diff)
From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v3 1/3] tpm: vtpm_proxy: Implement new ioctl to get supported flags
Date: Thu, 4 May 2017 09:34:16 -0600	[thread overview]
Message-ID: <20170504153416.GA15930@obsidianresearch.com> (raw)
In-Reply-To: <1493909787-1848-2-git-send-email-stefanb@linux.vnet.ibm.com>

On Thu, May 04, 2017 at 10:56:25AM -0400, Stefan Berger wrote:
> Implement VTPM_PROXY_IOC_GET_SUPT_FLAGS ioctl to get the bitmask
> of flags that the vtpm_proxy driver supports in the
> VTPM_PROXY_IOC_NEW_DEV ioctl. This helps user space in deciding
> which flags to set in that ioctl.

you might be better off just having a VTPM_PROXY_IO_ENABLE_FEATURE
.feature = LOCALITY

If that fails then the feature is not supported, no real need for the
query in that case.

Not sure about Jarkko's point on request/release locality.. Is there a
scenario where the emulator should fail the request locality?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Stefan Berger
	<stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 1/3] tpm: vtpm_proxy: Implement new ioctl to get supported flags
Date: Thu, 4 May 2017 09:34:16 -0600	[thread overview]
Message-ID: <20170504153416.GA15930@obsidianresearch.com> (raw)
In-Reply-To: <1493909787-1848-2-git-send-email-stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>

On Thu, May 04, 2017 at 10:56:25AM -0400, Stefan Berger wrote:
> Implement VTPM_PROXY_IOC_GET_SUPT_FLAGS ioctl to get the bitmask
> of flags that the vtpm_proxy driver supports in the
> VTPM_PROXY_IOC_NEW_DEV ioctl. This helps user space in deciding
> which flags to set in that ioctl.

you might be better off just having a VTPM_PROXY_IO_ENABLE_FEATURE
.feature = LOCALITY

If that fails then the feature is not supported, no real need for the
query in that case.

Not sure about Jarkko's point on request/release locality.. Is there a
scenario where the emulator should fail the request locality?

Jason

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

  reply	other threads:[~2017-05-04 15:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 14:56 [PATCH v3 0/3] Extend the vTPM proxy driver to pass locality Stefan Berger
2017-05-04 14:56 ` Stefan Berger
2017-05-04 14:56 ` [PATCH v3 1/3] tpm: vtpm_proxy: Implement new ioctl to get supported flags Stefan Berger
2017-05-04 14:56   ` Stefan Berger
2017-05-04 14:56   ` Stefan Berger
2017-05-04 15:34   ` Jason Gunthorpe [this message]
2017-05-04 15:34     ` Jason Gunthorpe
2017-05-04 15:34     ` Jason Gunthorpe
2017-05-04 17:13     ` Stefan Berger
2017-05-04 17:13       ` Stefan Berger
2017-05-04 17:20       ` Jason Gunthorpe
2017-05-04 17:20         ` Jason Gunthorpe
2017-05-04 17:28         ` Stefan Berger
2017-05-04 17:28           ` Stefan Berger
2017-05-04 17:31           ` Jason Gunthorpe
2017-05-04 17:31             ` Jason Gunthorpe
2017-05-04 17:33             ` Stefan Berger
2017-05-04 17:33               ` Stefan Berger
2017-05-04 14:56 ` [PATCH v3 2/3] tpm: vtpm_proxy: Implement request_locality function Stefan Berger
2017-05-04 14:56   ` Stefan Berger
2017-05-04 14:56   ` Stefan Berger
2017-05-04 14:56 ` [PATCH v3 3/3] tpm: vtpm_proxy: Add flag for ioctl to request locality prepended to command Stefan Berger
2017-05-04 14:56   ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170504153416.GA15930@obsidianresearch.com \
    --to=jgunthorpe@obsidianresearch.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.