Re: [PATCH v3 0/6] Introduce new mode validation callbacks

From: Daniel Vetter <daniel@ffwll.ch>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	"Carlos Palminha" <CARLOS.PALMINHA@synopsys.com>,
	"Alexey Brodkin" <Alexey.Brodkin@synopsys.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Dave Airlie" <airlied@linux.ie>,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	"Archit Taneja" <architt@codeaurora.org>
Subject: Re: [PATCH v3 0/6] Introduce new mode validation callbacks
Date: Fri, 12 May 2017 09:32:33 +0200	[thread overview]
Message-ID: <20170512073232.yxknr556dal6isoh@phenom.ffwll.local> (raw)
In-Reply-To: <cover.1494492646.git.joabreu@synopsys.com>

On Thu, May 11, 2017 at 10:05:56AM +0100, Jose Abreu wrote:
> This series is a follow up from the discussion at [1]. We start by
> introducing crtc->mode_valid(), encoder->mode_valid() and
> bridge->mode_valid() callbacks which will be used in followup
> patches and also by cleaning the documentation a little bit.
> 
> We proceed by introducing new helpers to call this new callbacks
> at 2/6.
> 
> At 3/6 a helper function is introduced that calls all mode_valid()
> from a set of bridges.
> 
> Next, at 4/6 we modify the connector probe helper so that only modes
> which are supported by a given bridge+encoder+crtc combination are
> probbed.
> 
> At 5/6 we call all the mode_valid() callbacks for a given pipeline,
> except the connector->mode_valid one, so that the mode is validated.
> This is done before calling mode_fixup().
> 
> Finally, at 6/6 we use the new crtc->mode_valid() callback in arcpgu
> and remove the atomic_check() callback.
> 
> [1] https://patchwork.kernel.org/patch/9702233/
> 
> Jose Abreu (6):
>   drm: Add crtc/encoder/bridge->mode_valid() callbacks
>   drm: Add drm_{crtc/encoder/connector}_mode_valid()
>   drm: Introduce drm_bridge_mode_valid()
>   drm: Use new mode_valid() helpers in connector probe helper
>   drm: Use mode_valid() in atomic modeset
>   drm: arc: Use crtc->mode_valid() callback
> 
> Cc: Carlos Palminha <palminha@synopsys.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Dave Airlie <airlied@linux.ie>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Archit Taneja <architt@codeaurora.org>

Commented with an entire patch on patch 1, patches 2-5 are all

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

But I think some more acks/r-bs would be really good, since this is quite
a bit change in the helper infrastructure. But otherwise ready for merging
imo. Can you pls also review my proposal for patch 1?

Thanks, Daniel

> 
>  drivers/gpu/drm/arc/arcpgu_crtc.c          |  39 ++++++----
>  drivers/gpu/drm/drm_atomic_helper.c        |  76 +++++++++++++++++++-
>  drivers/gpu/drm/drm_bridge.c               |  33 +++++++++
>  drivers/gpu/drm/drm_crtc_helper_internal.h |  13 ++++
>  drivers/gpu/drm/drm_probe_helper.c         | 103 ++++++++++++++++++++++++++-
>  include/drm/drm_bridge.h                   |  22 ++++++
>  include/drm/drm_modeset_helper_vtables.h   | 110 ++++++++++++++++++++++-------
>  7 files changed, 348 insertions(+), 48 deletions(-)
> 
> -- 
> 1.9.1
> 
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch