From: Andrzej Hajda <a.hajda@samsung.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: "Carlos Palminha" <CARLOS.PALMINHA@synopsys.com>,
"Alexey Brodkin" <Alexey.Brodkin@synopsys.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Dave Airlie" <airlied@linux.ie>,
"Archit Taneja" <architt@codeaurora.org>
Subject: Re: [PATCH v3 6/6] drm: arc: Use crtc->mode_valid() callback
Date: Mon, 15 May 2017 10:54:02 +0200 [thread overview]
Message-ID: <f716f328-8a2f-7815-d155-873f2a96eb47@samsung.com> (raw)
In-Reply-To: <f4dbd80323f567cef785b250daf6e50760160ecd.1494492646.git.joabreu@synopsys.com>
On 11.05.2017 11:06, Jose Abreu wrote:
> Now that we have a callback to check if crtc supports a given mode
> we can use it in arcpgu so that we restrict the number of probbed
> modes to the ones we can actually display.
>
> This is specially useful because arcpgu crtc is responsible to set
> a clock value in the commit() stage but unfortunatelly this clock
> does not support all the needed ranges.
>
> Also, remove the atomic_check() callback as mode_valid() callback
> will be called before.
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Cc: Carlos Palminha <palminha@synopsys.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Dave Airlie <airlied@linux.ie>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Archit Taneja <architt@codeaurora.org>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Hajda <a.hajda@samsung.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
Subject: Re: [PATCH v3 6/6] drm: arc: Use crtc->mode_valid() callback
Date: Mon, 15 May 2017 10:54:02 +0200 [thread overview]
Message-ID: <f716f328-8a2f-7815-d155-873f2a96eb47@samsung.com> (raw)
In-Reply-To: <f4dbd80323f567cef785b250daf6e50760160ecd.1494492646.git.joabreu@synopsys.com>
On 11.05.2017 11:06, Jose Abreu wrote:
> Now that we have a callback to check if crtc supports a given mode
> we can use it in arcpgu so that we restrict the number of probbed
> modes to the ones we can actually display.
>
> This is specially useful because arcpgu crtc is responsible to set
> a clock value in the commit() stage but unfortunatelly this clock
> does not support all the needed ranges.
>
> Also, remove the atomic_check() callback as mode_valid() callback
> will be called before.
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Cc: Carlos Palminha <palminha@synopsys.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Dave Airlie <airlied@linux.ie>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Archit Taneja <architt@codeaurora.org>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-05-15 8:54 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 9:05 [PATCH v3 0/6] Introduce new mode validation callbacks Jose Abreu
2017-05-11 9:05 ` [PATCH v3 1/6] drm: Add crtc/encoder/bridge->mode_valid() callbacks Jose Abreu
2017-05-12 7:00 ` Daniel Vetter
2017-05-12 7:00 ` Daniel Vetter
2017-05-12 7:31 ` [PATCH] " Daniel Vetter
2017-05-12 11:29 ` Laurent Pinchart
2017-05-15 6:50 ` Daniel Vetter
2017-05-12 12:37 ` Andrzej Hajda
2017-05-15 6:56 ` Daniel Vetter
2017-05-15 8:10 ` Andrzej Hajda
2017-05-15 8:14 ` Daniel Vetter
2017-05-12 15:59 ` Jose Abreu
2017-05-15 9:11 ` [PATCH 1/2] drm/doc: Document adjusted/request modes a bit better Daniel Vetter
2017-05-15 9:11 ` [PATCH 2/2] drm/doc: Clarify mode_fixup vs. atomic_check a bit more Daniel Vetter
2017-05-16 2:41 ` Jose Abreu
2017-05-16 13:14 ` Andrzej Hajda
2017-05-16 2:38 ` [PATCH 1/2] drm/doc: Document adjusted/request modes a bit better Jose Abreu
2017-05-16 13:17 ` Andrzej Hajda
2017-05-15 9:33 ` [PATCH] drm: Add crtc/encoder/bridge->mode_valid() callbacks Daniel Vetter
2017-05-16 13:15 ` Andrzej Hajda
2017-05-11 9:05 ` [PATCH v3 2/6] drm: Add drm_{crtc/encoder/connector}_mode_valid() Jose Abreu
2017-05-15 8:27 ` Andrzej Hajda
2017-05-15 8:27 ` Andrzej Hajda
2017-05-11 9:05 ` [PATCH v3 3/6] drm: Introduce drm_bridge_mode_valid() Jose Abreu
2017-05-11 9:06 ` [PATCH v3 4/6] drm: Use new mode_valid() helpers in connector probe helper Jose Abreu
2017-05-15 8:39 ` Andrzej Hajda
2017-05-15 8:39 ` Andrzej Hajda
2017-05-15 9:30 ` Daniel Vetter
2017-05-15 9:30 ` Daniel Vetter
2017-05-15 9:51 ` Andrzej Hajda
2017-05-15 9:51 ` Andrzej Hajda
2017-05-11 9:06 ` [PATCH v3 5/6] drm: Use mode_valid() in atomic modeset Jose Abreu
2017-05-15 8:45 ` Andrzej Hajda
2017-05-11 9:06 ` [PATCH v3 6/6] drm: arc: Use crtc->mode_valid() callback Jose Abreu
2017-05-15 8:53 ` Daniel Vetter
2017-05-15 8:53 ` Daniel Vetter
2017-05-15 15:52 ` Daniel Vetter
2017-05-15 15:52 ` Daniel Vetter
2017-05-15 23:55 ` Jose Abreu
2017-05-15 23:55 ` Jose Abreu
2017-05-15 8:54 ` Andrzej Hajda [this message]
2017-05-15 8:54 ` Andrzej Hajda
2017-05-12 7:32 ` [PATCH v3 0/6] Introduce new mode validation callbacks Daniel Vetter
2017-05-12 7:32 ` Daniel Vetter
2017-05-12 13:37 ` Andrzej Hajda
2017-05-12 13:37 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f716f328-8a2f-7815-d155-873f2a96eb47@samsung.com \
--to=a.hajda@samsung.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.