From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@fb.com>, linux-block@vger.kernel.org, Christoph Hellwig <hch@infradead.org> Cc: Bart Van Assche <bart.vanassche@sandisk.com>, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, dm-devel@redhat.com Subject: [PATCH 4/6] blk-mq: update comments on blk_mq_quiesce_queue() Date: Fri, 26 May 2017 11:07:37 +0800 [thread overview] Message-ID: <20170526030740.26959-5-ming.lei@redhat.com> (raw) In-Reply-To: <20170526030740.26959-1-ming.lei@redhat.com> Actually what we want to get from blk_mq_quiesce_queue() isn't only to wait for completion of all ongooing .queue_rq(). In the typical context of canceling requests, we need to make sure that the following is done in the dispatch path before starting to cancel requests: - failed dispatched request is freeed - busy dispatched request is requeued, and the STARTED flag is cleared Signed-off-by: Ming Lei <ming.lei@redhat.com> --- block/blk-mq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 864709453c90..e1fc9ab50c87 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -155,12 +155,12 @@ void blk_mq_unfreeze_queue(struct request_queue *q) EXPORT_SYMBOL_GPL(blk_mq_unfreeze_queue); /** - * blk_mq_quiesce_queue() - wait until all ongoing queue_rq calls have finished + * blk_mq_quiesce_queue() - wait until all ongoing dispatching have finished * @q: request queue. * * Note: this function does not prevent that the struct request end_io() - * callback function is invoked. Additionally, it is not prevented that - * new queue_rq() calls occur unless the queue has been stopped first. + * callback function is invoked. Once this function is returned, we make + * sure no dispatching can happen. */ void blk_mq_quiesce_queue(struct request_queue *q) { -- 2.9.4
WARNING: multiple messages have this Message-ID (diff)
From: ming.lei@redhat.com (Ming Lei) Subject: [PATCH 4/6] blk-mq: update comments on blk_mq_quiesce_queue() Date: Fri, 26 May 2017 11:07:37 +0800 [thread overview] Message-ID: <20170526030740.26959-5-ming.lei@redhat.com> (raw) In-Reply-To: <20170526030740.26959-1-ming.lei@redhat.com> Actually what we want to get from blk_mq_quiesce_queue() isn't only to wait for completion of all ongooing .queue_rq(). In the typical context of canceling requests, we need to make sure that the following is done in the dispatch path before starting to cancel requests: - failed dispatched request is freeed - busy dispatched request is requeued, and the STARTED flag is cleared Signed-off-by: Ming Lei <ming.lei at redhat.com> --- block/blk-mq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 864709453c90..e1fc9ab50c87 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -155,12 +155,12 @@ void blk_mq_unfreeze_queue(struct request_queue *q) EXPORT_SYMBOL_GPL(blk_mq_unfreeze_queue); /** - * blk_mq_quiesce_queue() - wait until all ongoing queue_rq calls have finished + * blk_mq_quiesce_queue() - wait until all ongoing dispatching have finished * @q: request queue. * * Note: this function does not prevent that the struct request end_io() - * callback function is invoked. Additionally, it is not prevented that - * new queue_rq() calls occur unless the queue has been stopped first. + * callback function is invoked. Once this function is returned, we make + * sure no dispatching can happen. */ void blk_mq_quiesce_queue(struct request_queue *q) { -- 2.9.4
next prev parent reply other threads:[~2017-05-26 3:08 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-26 3:07 [PATCH 0/6] blk-mq: fix & improve queue quiescing Ming Lei 2017-05-26 3:07 ` Ming Lei 2017-05-26 3:07 ` [PATCH 1/6] blk-mq: introduce blk_mq_unquiesce_queue Ming Lei 2017-05-26 3:07 ` Ming Lei 2017-05-26 3:07 ` [PATCH 2/6] blk-mq: use the introduced blk_mq_unquiesce_queue() Ming Lei 2017-05-26 3:07 ` Ming Lei 2017-05-26 7:46 ` kbuild test robot 2017-05-26 7:46 ` kbuild test robot 2017-05-26 7:46 ` kbuild test robot 2017-05-26 8:24 ` Ming Lei 2017-05-26 8:24 ` Ming Lei 2017-05-26 8:24 ` Ming Lei 2017-05-26 3:07 ` [PATCH 3/6] blk-mq: fix blk_mq_quiesce_queue Ming Lei 2017-05-26 3:07 ` Ming Lei 2017-05-26 3:07 ` Ming Lei [this message] 2017-05-26 3:07 ` [PATCH 4/6] blk-mq: update comments on blk_mq_quiesce_queue() Ming Lei 2017-05-26 3:07 ` [PATCH 5/6] blk-mq: don't stop queue for quiescing Ming Lei 2017-05-26 3:07 ` Ming Lei 2017-05-26 3:07 ` [PATCH 6/6] blk-mq: clarify dispatching may not be drained/blocked by stopping queue Ming Lei 2017-05-26 3:07 ` Ming Lei 2017-05-26 3:07 ` [PATCH 6/6] blk-mq: clarify dispatching won't be blocked " Ming Lei 2017-05-26 3:07 ` Ming Lei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170526030740.26959-5-ming.lei@redhat.com \ --to=ming.lei@redhat.com \ --cc=axboe@fb.com \ --cc=bart.vanassche@sandisk.com \ --cc=dm-devel@redhat.com \ --cc=hch@infradead.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=linux-scsi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.