From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@fb.com>, linux-block@vger.kernel.org, Christoph Hellwig <hch@infradead.org> Cc: Bart Van Assche <bart.vanassche@sandisk.com>, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, dm-devel@redhat.com Subject: [PATCH 5/6] blk-mq: don't stop queue for quiescing Date: Fri, 26 May 2017 11:07:38 +0800 [thread overview] Message-ID: <20170526030740.26959-6-ming.lei@redhat.com> (raw) In-Reply-To: <20170526030740.26959-1-ming.lei@redhat.com> Now we use the QUIESCED flag to drain & block dispatching, not necessary to stop queue any more. Also queue can be started by other blk-mq APIs, this limits uses of blk_mq_quiesce_queue(). Now blk_mq_quiesce_queue() can be used safely and users won't worry about queue restart during quiescing. Signed-off-by: Ming Lei <ming.lei@redhat.com> --- block/blk-mq.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index e1fc9ab50c87..900eb91e0ece 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -168,8 +168,6 @@ void blk_mq_quiesce_queue(struct request_queue *q) unsigned int i; bool rcu = false; - __blk_mq_stop_hw_queues(q, true); - spin_lock_irq(q->queue_lock); queue_flag_set(QUEUE_FLAG_QUIESCED, q); spin_unlock_irq(q->queue_lock); @@ -198,7 +196,12 @@ void blk_mq_unquiesce_queue(struct request_queue *q) queue_flag_clear(QUEUE_FLAG_QUIESCED, q); spin_unlock_irq(q->queue_lock); - blk_mq_start_stopped_hw_queues(q, true); + /* + * During quiescing, requests can be inserted + * to scheduler queue or sw queue, so we run + * queues for dispatching these requests. + */ + blk_mq_start_hw_queues(q); } EXPORT_SYMBOL_GPL(blk_mq_unquiesce_queue); -- 2.9.4
WARNING: multiple messages have this Message-ID (diff)
From: ming.lei@redhat.com (Ming Lei) Subject: [PATCH 5/6] blk-mq: don't stop queue for quiescing Date: Fri, 26 May 2017 11:07:38 +0800 [thread overview] Message-ID: <20170526030740.26959-6-ming.lei@redhat.com> (raw) In-Reply-To: <20170526030740.26959-1-ming.lei@redhat.com> Now we use the QUIESCED flag to drain & block dispatching, not necessary to stop queue any more. Also queue can be started by other blk-mq APIs, this limits uses of blk_mq_quiesce_queue(). Now blk_mq_quiesce_queue() can be used safely and users won't worry about queue restart during quiescing. Signed-off-by: Ming Lei <ming.lei at redhat.com> --- block/blk-mq.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index e1fc9ab50c87..900eb91e0ece 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -168,8 +168,6 @@ void blk_mq_quiesce_queue(struct request_queue *q) unsigned int i; bool rcu = false; - __blk_mq_stop_hw_queues(q, true); - spin_lock_irq(q->queue_lock); queue_flag_set(QUEUE_FLAG_QUIESCED, q); spin_unlock_irq(q->queue_lock); @@ -198,7 +196,12 @@ void blk_mq_unquiesce_queue(struct request_queue *q) queue_flag_clear(QUEUE_FLAG_QUIESCED, q); spin_unlock_irq(q->queue_lock); - blk_mq_start_stopped_hw_queues(q, true); + /* + * During quiescing, requests can be inserted + * to scheduler queue or sw queue, so we run + * queues for dispatching these requests. + */ + blk_mq_start_hw_queues(q); } EXPORT_SYMBOL_GPL(blk_mq_unquiesce_queue); -- 2.9.4
next prev parent reply other threads:[~2017-05-26 3:08 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-26 3:07 [PATCH 0/6] blk-mq: fix & improve queue quiescing Ming Lei 2017-05-26 3:07 ` Ming Lei 2017-05-26 3:07 ` [PATCH 1/6] blk-mq: introduce blk_mq_unquiesce_queue Ming Lei 2017-05-26 3:07 ` Ming Lei 2017-05-26 3:07 ` [PATCH 2/6] blk-mq: use the introduced blk_mq_unquiesce_queue() Ming Lei 2017-05-26 3:07 ` Ming Lei 2017-05-26 7:46 ` kbuild test robot 2017-05-26 7:46 ` kbuild test robot 2017-05-26 7:46 ` kbuild test robot 2017-05-26 8:24 ` Ming Lei 2017-05-26 8:24 ` Ming Lei 2017-05-26 8:24 ` Ming Lei 2017-05-26 3:07 ` [PATCH 3/6] blk-mq: fix blk_mq_quiesce_queue Ming Lei 2017-05-26 3:07 ` Ming Lei 2017-05-26 3:07 ` [PATCH 4/6] blk-mq: update comments on blk_mq_quiesce_queue() Ming Lei 2017-05-26 3:07 ` Ming Lei 2017-05-26 3:07 ` Ming Lei [this message] 2017-05-26 3:07 ` [PATCH 5/6] blk-mq: don't stop queue for quiescing Ming Lei 2017-05-26 3:07 ` [PATCH 6/6] blk-mq: clarify dispatching may not be drained/blocked by stopping queue Ming Lei 2017-05-26 3:07 ` Ming Lei 2017-05-26 3:07 ` [PATCH 6/6] blk-mq: clarify dispatching won't be blocked " Ming Lei 2017-05-26 3:07 ` Ming Lei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170526030740.26959-6-ming.lei@redhat.com \ --to=ming.lei@redhat.com \ --cc=axboe@fb.com \ --cc=bart.vanassche@sandisk.com \ --cc=dm-devel@redhat.com \ --cc=hch@infradead.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=linux-scsi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.