All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Biju Das <biju.das@bp.renesas.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Chris Paterson <chris.paterson2@renesas.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
Date: Mon, 10 Jul 2017 10:23:51 +0200	[thread overview]
Message-ID: <20170710082350.GB13680@verge.net.au> (raw)
In-Reply-To: <CAMuHMdWsM_FBJ46=U69XptqpyC2cJYx_cqczaHBNq2nxZr68GQ@mail.gmail.com>

On Mon, Jul 10, 2017 at 09:54:40AM +0200, Geert Uytterhoeven wrote:
> Hi Biju,
> 
> On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > Add Ethernet AVB support for r8a7743 SoC.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> 
> With the minor nit below fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -605,6 +605,19 @@
> >                         #size-cells = <0>;
> >                         status = "disabled";
> >                 };
> > +
> > +               avb: ethernet@e6800000 {
> > +                       compatible = "renesas,etheravb-r8a7743",

I do not see a patch to add "renesas,etheravb-r8a7743" to
Documentation/devicetree/bindings/net/renesas,ravb.txt

If you haven't already done so please post a patch to add this
once net-next re-opens.

> > +                                    "renesas,etheravb-rcar-gen2";
> > +                       reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>;
> > +                       interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
> 
> s/0/GIC_SPI/

Thanks, I have applied this patch with the minor update above.

WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
Date: Mon, 10 Jul 2017 10:23:51 +0200	[thread overview]
Message-ID: <20170710082350.GB13680@verge.net.au> (raw)
In-Reply-To: <CAMuHMdWsM_FBJ46=U69XptqpyC2cJYx_cqczaHBNq2nxZr68GQ@mail.gmail.com>

On Mon, Jul 10, 2017 at 09:54:40AM +0200, Geert Uytterhoeven wrote:
> Hi Biju,
> 
> On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > Add Ethernet AVB support for r8a7743 SoC.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> 
> With the minor nit below fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -605,6 +605,19 @@
> >                         #size-cells = <0>;
> >                         status = "disabled";
> >                 };
> > +
> > +               avb: ethernet at e6800000 {
> > +                       compatible = "renesas,etheravb-r8a7743",

I do not see a patch to add "renesas,etheravb-r8a7743" to
Documentation/devicetree/bindings/net/renesas,ravb.txt

If you haven't already done so please post a patch to add this
once net-next re-opens.

> > +                                    "renesas,etheravb-rcar-gen2";
> > +                       reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>;
> > +                       interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
> 
> s/0/GIC_SPI/

Thanks, I have applied this patch with the minor update above.

  parent reply	other threads:[~2017-07-10  8:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07 13:12 [PATCH v 0/2] Add R8A7743/iwg20d-q7 Ethernet AVB support Biju Das
2017-07-07 13:12 ` Biju Das
     [not found] ` <1499433165-62475-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-07-07 13:12   ` [PATCH v 1/2] ARM: dts: r8a7743: Add " Biju Das
2017-07-07 13:12     ` Biju Das
2017-07-07 13:12     ` Biju Das
     [not found]     ` <1499433165-62475-2-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-07-07 17:23       ` Sergei Shtylyov
2017-07-07 17:23         ` Sergei Shtylyov
2017-07-07 17:23         ` Sergei Shtylyov
2017-07-10  7:54       ` Geert Uytterhoeven
2017-07-10  7:54         ` Geert Uytterhoeven
2017-07-10  7:54         ` Geert Uytterhoeven
2017-07-10  8:21         ` Biju Das
2017-07-10  8:21           ` Biju Das
2017-07-10  8:23         ` Simon Horman [this message]
2017-07-10  8:23           ` Simon Horman
2017-07-10  8:36           ` Simon Horman
2017-07-10  8:36             ` Simon Horman
     [not found]             ` <20170710083643.GG13680-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-07-10  9:17               ` Biju Das
2017-07-10  9:17                 ` Biju Das
2017-07-10  9:17                 ` Biju Das
2017-07-07 13:12 ` [PATCH v 2/2] ARM: dts: iwg20d-q7: " Biju Das
2017-07-07 13:12   ` Biju Das
2017-07-10  8:03   ` Geert Uytterhoeven
2017-07-10  8:03     ` Geert Uytterhoeven
2017-07-10  8:24     ` Simon Horman
2017-07-10  8:24       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170710082350.GB13680@verge.net.au \
    --to=horms@verge.net.au \
    --cc=biju.das@bp.renesas.com \
    --cc=chris.paterson2@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.