From: Biju Das <biju.das@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Chris Paterson <Chris.Paterson2@renesas.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
Date: Mon, 10 Jul 2017 08:21:45 +0000 [thread overview]
Message-ID: <KL1PR06MB1702CA5C697C50497F33E587B8A90@KL1PR06MB1702.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdWsM_FBJ46=U69XptqpyC2cJYx_cqczaHBNq2nxZr68GQ@mail.gmail.com>
Hi Geert,
Thanks for the review.
> -----Original Message-----
> From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com]
> On Behalf Of Geert Uytterhoeven
> Sent: 10 July 2017 08:55
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Russell King <linux@armlinux.org.uk>; Sergei
> Shtylyov <sergei.shtylyov@cogentembedded.com>; Simon Horman
> <horms@verge.net.au>; Magnus Damm <magnus.damm@gmail.com>; Chris
> Paterson <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org; Linux-
> Renesas <linux-renesas-soc@vger.kernel.org>; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
>
> Hi Biju,
>
> On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > Add Ethernet AVB support for r8a7743 SoC.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
>
> With the minor nit below fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -605,6 +605,19 @@
> > #size-cells = <0>;
> > status = "disabled";
> > };
> > +
> > + avb: ethernet@e6800000 {
> > + compatible = "renesas,etheravb-r8a7743",
> > + "renesas,etheravb-rcar-gen2";
> > + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>;
> > + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
>
OK. I will fix this.
> s/0/GIC_SPI/
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
WARNING: multiple messages have this Message-ID (diff)
From: biju.das@bp.renesas.com (Biju Das)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
Date: Mon, 10 Jul 2017 08:21:45 +0000 [thread overview]
Message-ID: <KL1PR06MB1702CA5C697C50497F33E587B8A90@KL1PR06MB1702.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdWsM_FBJ46=U69XptqpyC2cJYx_cqczaHBNq2nxZr68GQ@mail.gmail.com>
Hi Geert,
Thanks for the review.
> -----Original Message-----
> From: geert.uytterhoeven at gmail.com [mailto:geert.uytterhoeven at gmail.com]
> On Behalf Of Geert Uytterhoeven
> Sent: 10 July 2017 08:55
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Russell King <linux@armlinux.org.uk>; Sergei
> Shtylyov <sergei.shtylyov@cogentembedded.com>; Simon Horman
> <horms@verge.net.au>; Magnus Damm <magnus.damm@gmail.com>; Chris
> Paterson <Chris.Paterson2@renesas.com>; devicetree at vger.kernel.org; Linux-
> Renesas <linux-renesas-soc@vger.kernel.org>; linux-arm-
> kernel at lists.infradead.org
> Subject: Re: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
>
> Hi Biju,
>
> On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > Add Ethernet AVB support for r8a7743 SoC.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
>
> With the minor nit below fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -605,6 +605,19 @@
> > #size-cells = <0>;
> > status = "disabled";
> > };
> > +
> > + avb: ethernet at e6800000 {
> > + compatible = "renesas,etheravb-r8a7743",
> > + "renesas,etheravb-rcar-gen2";
> > + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>;
> > + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
>
OK. I will fix this.
> s/0/GIC_SPI/
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
next prev parent reply other threads:[~2017-07-10 8:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 13:12 [PATCH v 0/2] Add R8A7743/iwg20d-q7 Ethernet AVB support Biju Das
2017-07-07 13:12 ` Biju Das
[not found] ` <1499433165-62475-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-07-07 13:12 ` [PATCH v 1/2] ARM: dts: r8a7743: Add " Biju Das
2017-07-07 13:12 ` Biju Das
2017-07-07 13:12 ` Biju Das
[not found] ` <1499433165-62475-2-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-07-07 17:23 ` Sergei Shtylyov
2017-07-07 17:23 ` Sergei Shtylyov
2017-07-07 17:23 ` Sergei Shtylyov
2017-07-10 7:54 ` Geert Uytterhoeven
2017-07-10 7:54 ` Geert Uytterhoeven
2017-07-10 7:54 ` Geert Uytterhoeven
2017-07-10 8:21 ` Biju Das [this message]
2017-07-10 8:21 ` Biju Das
2017-07-10 8:23 ` Simon Horman
2017-07-10 8:23 ` Simon Horman
2017-07-10 8:36 ` Simon Horman
2017-07-10 8:36 ` Simon Horman
[not found] ` <20170710083643.GG13680-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-07-10 9:17 ` Biju Das
2017-07-10 9:17 ` Biju Das
2017-07-10 9:17 ` Biju Das
2017-07-07 13:12 ` [PATCH v 2/2] ARM: dts: iwg20d-q7: " Biju Das
2017-07-07 13:12 ` Biju Das
2017-07-10 8:03 ` Geert Uytterhoeven
2017-07-10 8:03 ` Geert Uytterhoeven
2017-07-10 8:24 ` Simon Horman
2017-07-10 8:24 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=KL1PR06MB1702CA5C697C50497F33E587B8A90@KL1PR06MB1702.apcprd06.prod.outlook.com \
--to=biju.das@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.