From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Yong <yong.deng@magewell.com>
Cc: Baruch Siach <baruch@tkos.co.il>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>,
Hans Verkuil <hverkuil@xs4all.nl>, Arnd Bergmann <arnd@arndb.de>,
Hugues Fruchet <hugues.fruchet@st.com>,
Yannick Fertre <yannick.fertre@st.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Benoit Parrot <bparrot@ti.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Jean-Christophe Trotin <jean-christophe.trotin@st.com>,
Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>,
Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.
Date: Wed, 23 Aug 2017 21:24:13 +0200 [thread overview]
Message-ID: <20170823192413.y5psmcgd3ghvpkbz@flea.home> (raw)
In-Reply-To: <20170823104118.b4524830e4bb767d7714772c@magewell.com>
[-- Attachment #1: Type: text/plain, Size: 1685 bytes --]
On Wed, Aug 23, 2017 at 10:41:18AM +0800, Yong wrote:
> > > > > +static irqreturn_t sun6i_csi_isr(int irq, void *dev_id)
> > > > > +{
> > > > > + struct sun6i_csi_dev *sdev = (struct sun6i_csi_dev *)dev_id;
> > > > > + struct regmap *regmap = sdev->regmap;
> > > > > + u32 status;
> > > > > +
> > > > > + regmap_read(regmap, CSI_CH_INT_STA_REG, &status);
> > > > > +
> > > > > + if ((status & CSI_CH_INT_STA_FIFO0_OF_PD) ||
> > > > > + (status & CSI_CH_INT_STA_FIFO1_OF_PD) ||
> > > > > + (status & CSI_CH_INT_STA_FIFO2_OF_PD) ||
> > > > > + (status & CSI_CH_INT_STA_HB_OF_PD)) {
> > > > > + regmap_write(regmap, CSI_CH_INT_STA_REG, status);
> > > > > + regmap_update_bits(regmap, CSI_EN_REG, CSI_EN_CSI_EN, 0);
> > > > > + regmap_update_bits(regmap, CSI_EN_REG, CSI_EN_CSI_EN,
> > > > > + CSI_EN_CSI_EN);
> > > >
> > > > You need to enable / disable it at every frame? How do you deal with
> > > > double buffering? (or did you choose to ignore it for now?)
> > >
> > > These *_OF_PD status bits indicate an overflow error condition.
> >
> > Shouldn't we return an error code then? The names of these flags could
> > be better too.
>
> Then, where and how to deal with the error coce.
If you want to deal with FIFO overflow, I'm not sure you have anything
to do. It means, you've been to slow to queue buffers, so I guess
stopping the pipeline until more buffers are queued would make
sense. And we should probably increase the sequence number while doing
so to notify the userspace that some frames were lost.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Yong <yong.deng@magewell.com>
Cc: Baruch Siach <baruch@tkos.co.il>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>,
Hans Verkuil <hverkuil@xs4all.nl>, Arnd Bergmann <arnd@arndb.de>,
Hugues Fruchet <hugues.fruchet@st.com>,
Yannick Fertre <yannick.fertre@st.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Benoit Parrot <bparrot@ti.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Jean-Christophe Trotin <jean-christophe.trotin@st.com>,
Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>,
Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Robert
Subject: Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.
Date: Wed, 23 Aug 2017 21:24:13 +0200 [thread overview]
Message-ID: <20170823192413.y5psmcgd3ghvpkbz@flea.home> (raw)
In-Reply-To: <20170823104118.b4524830e4bb767d7714772c@magewell.com>
[-- Attachment #1: Type: text/plain, Size: 1685 bytes --]
On Wed, Aug 23, 2017 at 10:41:18AM +0800, Yong wrote:
> > > > > +static irqreturn_t sun6i_csi_isr(int irq, void *dev_id)
> > > > > +{
> > > > > + struct sun6i_csi_dev *sdev = (struct sun6i_csi_dev *)dev_id;
> > > > > + struct regmap *regmap = sdev->regmap;
> > > > > + u32 status;
> > > > > +
> > > > > + regmap_read(regmap, CSI_CH_INT_STA_REG, &status);
> > > > > +
> > > > > + if ((status & CSI_CH_INT_STA_FIFO0_OF_PD) ||
> > > > > + (status & CSI_CH_INT_STA_FIFO1_OF_PD) ||
> > > > > + (status & CSI_CH_INT_STA_FIFO2_OF_PD) ||
> > > > > + (status & CSI_CH_INT_STA_HB_OF_PD)) {
> > > > > + regmap_write(regmap, CSI_CH_INT_STA_REG, status);
> > > > > + regmap_update_bits(regmap, CSI_EN_REG, CSI_EN_CSI_EN, 0);
> > > > > + regmap_update_bits(regmap, CSI_EN_REG, CSI_EN_CSI_EN,
> > > > > + CSI_EN_CSI_EN);
> > > >
> > > > You need to enable / disable it at every frame? How do you deal with
> > > > double buffering? (or did you choose to ignore it for now?)
> > >
> > > These *_OF_PD status bits indicate an overflow error condition.
> >
> > Shouldn't we return an error code then? The names of these flags could
> > be better too.
>
> Then, where and how to deal with the error coce.
If you want to deal with FIFO overflow, I'm not sure you have anything
to do. It means, you've been to slow to queue buffers, so I guess
stopping the pipeline until more buffers are queued would make
sense. And we should probably increase the sequence number while doing
so to notify the userspace that some frames were lost.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.
Date: Wed, 23 Aug 2017 21:24:13 +0200 [thread overview]
Message-ID: <20170823192413.y5psmcgd3ghvpkbz@flea.home> (raw)
In-Reply-To: <20170823104118.b4524830e4bb767d7714772c@magewell.com>
On Wed, Aug 23, 2017 at 10:41:18AM +0800, Yong wrote:
> > > > > +static irqreturn_t sun6i_csi_isr(int irq, void *dev_id)
> > > > > +{
> > > > > + struct sun6i_csi_dev *sdev = (struct sun6i_csi_dev *)dev_id;
> > > > > + struct regmap *regmap = sdev->regmap;
> > > > > + u32 status;
> > > > > +
> > > > > + regmap_read(regmap, CSI_CH_INT_STA_REG, &status);
> > > > > +
> > > > > + if ((status & CSI_CH_INT_STA_FIFO0_OF_PD) ||
> > > > > + (status & CSI_CH_INT_STA_FIFO1_OF_PD) ||
> > > > > + (status & CSI_CH_INT_STA_FIFO2_OF_PD) ||
> > > > > + (status & CSI_CH_INT_STA_HB_OF_PD)) {
> > > > > + regmap_write(regmap, CSI_CH_INT_STA_REG, status);
> > > > > + regmap_update_bits(regmap, CSI_EN_REG, CSI_EN_CSI_EN, 0);
> > > > > + regmap_update_bits(regmap, CSI_EN_REG, CSI_EN_CSI_EN,
> > > > > + CSI_EN_CSI_EN);
> > > >
> > > > You need to enable / disable it at every frame? How do you deal with
> > > > double buffering? (or did you choose to ignore it for now?)
> > >
> > > These *_OF_PD status bits indicate an overflow error condition.
> >
> > Shouldn't we return an error code then? The names of these flags could
> > be better too.
>
> Then, where and how to deal with the error coce.
If you want to deal with FIFO overflow, I'm not sure you have anything
to do. It means, you've been to slow to queue buffers, so I guess
stopping the pipeline until more buffers are queued would make
sense. And we should probably increase the sequence number while doing
so to notify the userspace that some frames were lost.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170823/354fbae2/attachment.sig>
next prev parent reply other threads:[~2017-08-23 19:24 UTC|newest]
Thread overview: 159+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 5:01 [PATCH v2 0/3] Initial Allwinner V3s CSI Support Yong Deng
2017-07-27 5:01 ` Yong Deng
2017-07-27 5:01 ` Yong Deng
2017-07-27 5:01 ` [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI Yong Deng
2017-07-27 5:01 ` Yong Deng
2017-07-27 5:01 ` Yong Deng
2017-07-27 12:16 ` Baruch Siach
2017-07-27 12:16 ` Baruch Siach
2017-07-27 12:16 ` Baruch Siach
2017-07-27 12:25 ` Maxime Ripard
2017-07-27 12:25 ` Maxime Ripard
2017-07-27 12:25 ` Maxime Ripard
2017-07-31 0:47 ` Yong
2017-07-31 0:47 ` Yong
2017-07-31 0:47 ` Yong
2017-07-28 16:02 ` Maxime Ripard
2017-07-28 16:02 ` Maxime Ripard
2017-07-28 16:02 ` Maxime Ripard
2017-07-30 6:08 ` Baruch Siach
2017-07-30 6:08 ` Baruch Siach
2017-07-30 6:08 ` Baruch Siach
2017-07-31 1:48 ` Yong
2017-07-31 1:48 ` Yong
2017-07-31 1:48 ` Yong
2017-07-31 5:13 ` Baruch Siach
2017-07-31 5:13 ` Baruch Siach
2017-07-31 5:13 ` Baruch Siach
2017-08-21 20:21 ` Maxime Ripard
2017-08-21 20:21 ` Maxime Ripard
2017-08-21 20:21 ` Maxime Ripard
2017-08-23 2:41 ` Yong
2017-08-23 2:41 ` Yong
2017-08-23 2:41 ` Yong
2017-08-23 19:24 ` Maxime Ripard [this message]
2017-08-23 19:24 ` Maxime Ripard
2017-08-23 19:24 ` Maxime Ripard
2017-08-24 1:43 ` Yong
2017-08-24 1:43 ` Yong
2017-08-24 1:43 ` Yong
2017-07-31 3:16 ` Yong
2017-07-31 3:16 ` Yong
2017-07-31 3:16 ` Yong
2017-08-22 17:43 ` Maxime Ripard
2017-08-22 17:43 ` Maxime Ripard
2017-08-22 17:43 ` Maxime Ripard
2017-08-23 2:32 ` Yong
2017-08-23 2:32 ` Yong
2017-08-23 2:32 ` Yong
2017-08-25 13:41 ` Maxime Ripard
2017-08-25 13:41 ` Maxime Ripard
2017-08-25 13:41 ` Maxime Ripard
2017-08-28 7:00 ` Yong
2017-08-28 7:00 ` Yong
2017-08-28 7:00 ` Yong
2017-08-21 14:37 ` Hans Verkuil
2017-08-21 14:37 ` Hans Verkuil
2017-08-21 14:37 ` Hans Verkuil
2017-08-22 3:01 ` Yong
2017-08-22 3:01 ` Yong
2017-08-22 3:01 ` Yong
2017-08-22 6:43 ` Hans Verkuil
2017-08-22 6:43 ` Hans Verkuil
2017-08-22 6:43 ` Hans Verkuil
2017-08-22 7:51 ` Yong
2017-08-22 7:51 ` Yong
2017-08-22 7:51 ` Yong
2017-08-22 20:17 ` Maxime Ripard
2017-08-22 20:17 ` Maxime Ripard
2017-08-22 20:17 ` Maxime Ripard
2017-08-22 20:52 ` Laurent Pinchart
2017-08-22 20:52 ` Laurent Pinchart
2017-08-22 20:52 ` Laurent Pinchart
2017-08-23 6:52 ` Hans Verkuil
2017-08-23 6:52 ` Hans Verkuil
2017-08-23 6:52 ` Hans Verkuil
2017-08-23 7:43 ` Laurent Pinchart
2017-08-23 7:43 ` Laurent Pinchart
2017-08-23 7:43 ` Laurent Pinchart
2017-08-23 11:13 ` icenowy
2017-08-23 11:13 ` icenowy at aosc.io
2017-08-23 11:13 ` icenowy
2017-09-21 13:45 ` [linux-sunxi] " Ondřej Jirman
2017-09-21 13:45 ` Ondřej Jirman
2017-09-21 13:45 ` 'Ondřej Jirman' via linux-sunxi
2017-09-22 0:57 ` 回复：[linux-sunxi] " 邓永
2017-09-22 8:44 ` Mylene JOSSERAND
2017-09-22 8:44 ` Mylene JOSSERAND
2017-09-22 8:44 ` Mylene JOSSERAND
2017-09-22 9:08 ` Yong
2017-09-22 9:08 ` Yong
2017-09-22 9:08 ` Yong
2017-11-21 15:48 ` Maxime Ripard
2017-11-21 15:48 ` Maxime Ripard
2017-11-21 15:48 ` Maxime Ripard
2017-11-22 1:33 ` Yong
2017-11-22 1:33 ` Yong
2017-11-22 1:33 ` Yong
2017-11-22 9:45 ` Maxime Ripard
2017-11-22 9:45 ` Maxime Ripard
2017-11-22 9:45 ` Maxime Ripard
2017-11-23 1:14 ` Yong
2017-11-23 1:14 ` Yong
2017-11-23 1:14 ` Yong
2017-11-25 16:02 ` Maxime Ripard
2017-11-25 16:02 ` Maxime Ripard
2017-11-25 16:02 ` Maxime Ripard
2017-12-04 9:45 ` Yong
2017-12-04 9:45 ` Yong
2017-12-04 9:45 ` Yong
2017-12-15 10:50 ` Maxime Ripard
2017-12-15 10:50 ` Maxime Ripard
2017-12-15 10:50 ` Maxime Ripard
2017-12-15 11:01 ` Yong
2017-12-15 11:01 ` Yong
2017-12-15 11:01 ` Yong
2017-12-15 22:14 ` Maxime Ripard
2017-12-15 22:14 ` Maxime Ripard
2017-12-15 22:14 ` Maxime Ripard
2017-07-27 5:01 ` [PATCH v2 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) Yong Deng
2017-07-27 5:01 ` Yong Deng
2017-07-27 5:01 ` Yong Deng
2017-07-28 16:03 ` Maxime Ripard
2017-07-28 16:03 ` Maxime Ripard
2017-07-28 16:03 ` Maxime Ripard
2017-07-31 0:50 ` Yong
2017-07-31 0:50 ` Yong
2017-07-31 0:50 ` Yong
2017-08-03 19:14 ` Rob Herring
2017-08-03 19:14 ` Rob Herring
2017-08-03 19:14 ` Rob Herring
2017-08-07 1:00 ` Yong
2017-08-07 1:00 ` Yong
2017-08-07 1:00 ` Yong
2017-12-19 11:53 ` Sakari Ailus
2017-12-19 11:53 ` Sakari Ailus
2017-12-19 11:53 ` Sakari Ailus
2017-12-21 2:49 ` Yong
2017-12-21 2:49 ` Yong
2017-12-21 2:49 ` Yong
2017-12-27 21:47 ` Sakari Ailus
2017-12-27 21:47 ` Sakari Ailus
2017-12-27 21:47 ` Sakari Ailus
2017-12-28 1:04 ` Yong
2017-12-28 1:04 ` Yong
2017-12-28 1:04 ` Yong
2017-07-27 5:01 ` [PATCH v2 3/3] media: MAINTAINERS: add entries for Allwinner V3s CSI Yong Deng
2017-07-27 5:01 ` Yong Deng
2017-07-27 5:01 ` Yong Deng
2017-12-19 11:48 ` Sakari Ailus
2017-12-19 11:48 ` Sakari Ailus
2017-12-19 11:48 ` Sakari Ailus
2017-12-21 2:40 ` Yong
2017-12-21 2:40 ` Yong
2017-12-21 2:40 ` Yong
-- strict thread matches above, loose matches on Subject: below --
2017-07-27 3:51 [PATCH v2 0/3] Initial Allwinner V3s CSI Support Yong Deng
2017-07-27 3:51 ` [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI Yong Deng
2017-07-27 3:51 ` Yong Deng
2017-07-27 3:51 ` Yong Deng
[not found] ` <1501127474-40895-1-git-send-email-yong.deng-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org>
2017-07-27 3:51 ` Yong Deng
2017-07-27 3:51 ` Yong Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823192413.y5psmcgd3ghvpkbz@flea.home \
--to=maxime.ripard@free-electrons.com \
--cc=arnd@arndb.de \
--cc=baruch@tkos.co.il \
--cc=benjamin.gaignard@linaro.org \
--cc=bparrot@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hugues.fruchet@st.com \
--cc=hverkuil@xs4all.nl \
--cc=jean-christophe.trotin@st.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=minghsiu.tsai@mediatek.com \
--cc=p.zabel@pengutronix.de \
--cc=ramesh.shanmugasundaram@bp.renesas.com \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=yannick.fertre@st.com \
--cc=yong.deng@magewell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.