From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: Fabrizio Castro
<fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux-Renesas
<linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Chris Paterson
<Chris.Paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
Subject: Re: Applied "spi: sh-msiof: Add compatible strings for r8a774[35]" to the spi tree
Date: Tue, 26 Sep 2017 10:30:09 -0700 [thread overview]
Message-ID: <20170926173009.xdw6mtvcyixpenr7@sirena.org.uk> (raw)
In-Reply-To: <CAMuHMdUv-5COUuzJOWx=BTb5oJ7tFOi1BpocuJ7+VuCZ3fEuPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On Mon, Sep 25, 2017 at 09:15:53PM +0200, Geert Uytterhoeven wrote:
> My rebuttal is threefold:
> 1. Listing the fallback property is mandatory for new SoCs. We only keep
> the per-SoC compatible values in the driver for older SoCs that predate
> the introduction of fallback properties.
So good practice is always good practice, but I'd argue that it's not
bad practice to also explicitly enumerate all the documented compatibles
in the driver. Being liberal in what you accept and all that.
> 2. Some harm is involved, in the form of increased kernel image size.
Is this really a meaningful impact?
> 3. When updating DT bindings for new SoCs, we usually add "No driver
> update is needed" to the patch description to clarify. Unfortunately
> that was missed here.
That's basically the same good practice thing, it's just documenting
what you're trying to do here with not putting things in code but
writing things in changelogs doesn't make them so!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-spi <linux-spi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>
Subject: Re: Applied "spi: sh-msiof: Add compatible strings for r8a774[35]" to the spi tree
Date: Tue, 26 Sep 2017 10:30:09 -0700 [thread overview]
Message-ID: <20170926173009.xdw6mtvcyixpenr7@sirena.org.uk> (raw)
In-Reply-To: <CAMuHMdUv-5COUuzJOWx=BTb5oJ7tFOi1BpocuJ7+VuCZ3fEuPg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On Mon, Sep 25, 2017 at 09:15:53PM +0200, Geert Uytterhoeven wrote:
> My rebuttal is threefold:
> 1. Listing the fallback property is mandatory for new SoCs. We only keep
> the per-SoC compatible values in the driver for older SoCs that predate
> the introduction of fallback properties.
So good practice is always good practice, but I'd argue that it's not
bad practice to also explicitly enumerate all the documented compatibles
in the driver. Being liberal in what you accept and all that.
> 2. Some harm is involved, in the form of increased kernel image size.
Is this really a meaningful impact?
> 3. When updating DT bindings for new SoCs, we usually add "No driver
> update is needed" to the patch description to clarify. Unfortunately
> that was missed here.
That's basically the same good practice thing, it's just documenting
what you're trying to do here with not putting things in code but
writing things in changelogs doesn't make them so!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-09-26 17:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 8:54 [PATCH 0/2] spi: sh-msiof: Add r8a774[35] bindings Fabrizio Castro
2017-09-25 8:54 ` Fabrizio Castro
[not found] ` <1506329660-4064-1-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-09-25 8:54 ` [PATCH 1/2] spi: sh-msiof: Add compatible strings for r8a774[35] Fabrizio Castro
2017-09-25 8:54 ` Fabrizio Castro
[not found] ` <1506329660-4064-2-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-09-25 11:21 ` Geert Uytterhoeven
2017-09-25 11:21 ` Geert Uytterhoeven
[not found] ` <CAMuHMdUA-ukN=Vv68Zbe2N2Z=fkKrq=w9QPm4uKyb5k68v+qcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-25 12:01 ` Fabrizio Castro
2017-09-25 12:01 ` Fabrizio Castro
2017-09-25 16:16 ` Applied "spi: sh-msiof: Add compatible strings for r8a774[35]" to the spi tree Mark Brown
2017-09-25 16:16 ` Mark Brown
2017-09-25 16:16 ` Mark Brown
2017-09-25 17:48 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVsRwW+10ERyTJAa8XhhkPMn4ruymUwPKot+kmczBwbcA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-25 18:45 ` Mark Brown
2017-09-25 18:45 ` Mark Brown
[not found] ` <20170925184545.5k4nke27rgud3uwp-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-09-25 19:15 ` Geert Uytterhoeven
2017-09-25 19:15 ` Geert Uytterhoeven
2017-09-26 12:23 ` Fabrizio Castro
[not found] ` <CAMuHMdUv-5COUuzJOWx=BTb5oJ7tFOi1BpocuJ7+VuCZ3fEuPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-26 17:30 ` Mark Brown [this message]
2017-09-26 17:30 ` Mark Brown
2017-09-27 5:36 ` Magnus Damm
[not found] ` <CANqRtoQjvkm4rMXt6jEaVWBeieEzqzT-yw_oARV7sj-SpTxB6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-27 17:01 ` Mark Brown
2017-09-27 17:01 ` Mark Brown
[not found] ` <20170927170145.lseodaywmmuqvmcj-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-09-28 5:41 ` Magnus Damm
2017-09-28 5:41 ` Magnus Damm
2017-09-25 8:54 ` [PATCH 2/2] dt-bindings: spi: sh-msiof: Add r8a774[35] to the compatible list Fabrizio Castro
2017-09-25 8:54 ` Fabrizio Castro
[not found] ` <1506329660-4064-3-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-09-25 11:18 ` Geert Uytterhoeven
2017-09-25 11:18 ` Geert Uytterhoeven
2017-09-25 16:16 ` Applied "spi: sh-msiof: Add r8a774[35] to the compatible list" to the spi tree Mark Brown
2017-09-25 16:16 ` Mark Brown
2017-09-25 16:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926173009.xdw6mtvcyixpenr7@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=Chris.Paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
--cc=biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.