From: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> To: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux-Renesas <linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Chris Paterson <Chris.Paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>, Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> Subject: Re: [PATCH 1/2] spi: sh-msiof: Add compatible strings for r8a774[35] Date: Mon, 25 Sep 2017 13:21:34 +0200 [thread overview] Message-ID: <CAMuHMdUA-ukN=Vv68Zbe2N2Z=fkKrq=w9QPm4uKyb5k68v+qcg@mail.gmail.com> (raw) In-Reply-To: <1506329660-4064-2-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> Hi Fabrizio, On Mon, Sep 25, 2017 at 10:54 AM, Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> wrote: > Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> This patch is not needed... > --- > drivers/spi/spi-sh-msiof.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c > index 0eb1e95..0080844 100644 > --- a/drivers/spi/spi-sh-msiof.c > +++ b/drivers/spi/spi-sh-msiof.c > @@ -1021,6 +1021,8 @@ static const struct sh_msiof_chipdata rcar_gen3_data = { > > static const struct of_device_id sh_msiof_match[] = { > { .compatible = "renesas,sh-mobile-msiof", .data = &sh_data }, > + { .compatible = "renesas,msiof-r8a7743", .data = &rcar_gen2_data }, > + { .compatible = "renesas,msiof-r8a7745", .data = &rcar_gen2_data }, > { .compatible = "renesas,msiof-r8a7790", .data = &rcar_gen2_data }, > { .compatible = "renesas,msiof-r8a7791", .data = &rcar_gen2_data }, > { .compatible = "renesas,msiof-r8a7792", .data = &rcar_gen2_data }, ... as the driver already matches against the family-specific compatible value below: { .compatible = "renesas,rcar-gen2-msiof", .data = &rcar_gen2_data }, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, linux-spi <linux-spi@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Chris Paterson <Chris.Paterson2@renesas.com>, Biju Das <biju.das@bp.renesas.com> Subject: Re: [PATCH 1/2] spi: sh-msiof: Add compatible strings for r8a774[35] Date: Mon, 25 Sep 2017 13:21:34 +0200 [thread overview] Message-ID: <CAMuHMdUA-ukN=Vv68Zbe2N2Z=fkKrq=w9QPm4uKyb5k68v+qcg@mail.gmail.com> (raw) In-Reply-To: <1506329660-4064-2-git-send-email-fabrizio.castro@bp.renesas.com> Hi Fabrizio, On Mon, Sep 25, 2017 at 10:54 AM, Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> This patch is not needed... > --- > drivers/spi/spi-sh-msiof.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c > index 0eb1e95..0080844 100644 > --- a/drivers/spi/spi-sh-msiof.c > +++ b/drivers/spi/spi-sh-msiof.c > @@ -1021,6 +1021,8 @@ static const struct sh_msiof_chipdata rcar_gen3_data = { > > static const struct of_device_id sh_msiof_match[] = { > { .compatible = "renesas,sh-mobile-msiof", .data = &sh_data }, > + { .compatible = "renesas,msiof-r8a7743", .data = &rcar_gen2_data }, > + { .compatible = "renesas,msiof-r8a7745", .data = &rcar_gen2_data }, > { .compatible = "renesas,msiof-r8a7790", .data = &rcar_gen2_data }, > { .compatible = "renesas,msiof-r8a7791", .data = &rcar_gen2_data }, > { .compatible = "renesas,msiof-r8a7792", .data = &rcar_gen2_data }, ... as the driver already matches against the family-specific compatible value below: { .compatible = "renesas,rcar-gen2-msiof", .data = &rcar_gen2_data }, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2017-09-25 11:21 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-25 8:54 [PATCH 0/2] spi: sh-msiof: Add r8a774[35] bindings Fabrizio Castro 2017-09-25 8:54 ` Fabrizio Castro [not found] ` <1506329660-4064-1-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> 2017-09-25 8:54 ` [PATCH 1/2] spi: sh-msiof: Add compatible strings for r8a774[35] Fabrizio Castro 2017-09-25 8:54 ` Fabrizio Castro [not found] ` <1506329660-4064-2-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> 2017-09-25 11:21 ` Geert Uytterhoeven [this message] 2017-09-25 11:21 ` Geert Uytterhoeven [not found] ` <CAMuHMdUA-ukN=Vv68Zbe2N2Z=fkKrq=w9QPm4uKyb5k68v+qcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-09-25 12:01 ` Fabrizio Castro 2017-09-25 12:01 ` Fabrizio Castro 2017-09-25 16:16 ` Applied "spi: sh-msiof: Add compatible strings for r8a774[35]" to the spi tree Mark Brown 2017-09-25 16:16 ` Mark Brown 2017-09-25 16:16 ` Mark Brown 2017-09-25 17:48 ` Geert Uytterhoeven [not found] ` <CAMuHMdVsRwW+10ERyTJAa8XhhkPMn4ruymUwPKot+kmczBwbcA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-09-25 18:45 ` Mark Brown 2017-09-25 18:45 ` Mark Brown [not found] ` <20170925184545.5k4nke27rgud3uwp-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2017-09-25 19:15 ` Geert Uytterhoeven 2017-09-25 19:15 ` Geert Uytterhoeven 2017-09-26 12:23 ` Fabrizio Castro [not found] ` <CAMuHMdUv-5COUuzJOWx=BTb5oJ7tFOi1BpocuJ7+VuCZ3fEuPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-09-26 17:30 ` Mark Brown 2017-09-26 17:30 ` Mark Brown 2017-09-27 5:36 ` Magnus Damm [not found] ` <CANqRtoQjvkm4rMXt6jEaVWBeieEzqzT-yw_oARV7sj-SpTxB6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-09-27 17:01 ` Mark Brown 2017-09-27 17:01 ` Mark Brown [not found] ` <20170927170145.lseodaywmmuqvmcj-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2017-09-28 5:41 ` Magnus Damm 2017-09-28 5:41 ` Magnus Damm 2017-09-25 8:54 ` [PATCH 2/2] dt-bindings: spi: sh-msiof: Add r8a774[35] to the compatible list Fabrizio Castro 2017-09-25 8:54 ` Fabrizio Castro [not found] ` <1506329660-4064-3-git-send-email-fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> 2017-09-25 11:18 ` Geert Uytterhoeven 2017-09-25 11:18 ` Geert Uytterhoeven 2017-09-25 16:16 ` Applied "spi: sh-msiof: Add r8a774[35] to the compatible list" to the spi tree Mark Brown 2017-09-25 16:16 ` Mark Brown 2017-09-25 16:16 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdUA-ukN=Vv68Zbe2N2Z=fkKrq=w9QPm4uKyb5k68v+qcg@mail.gmail.com' \ --to=geert-td1emuhucqxl1znqvxdv9g@public.gmane.org \ --cc=Chris.Paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \ --cc=biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org \ --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org \ --cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.