From: Christoph Hellwig <hch@lst.de> To: Jan Kara <jack@suse.cz> Cc: Christoph Hellwig <hch@infradead.org>, linux-nvdimm@lists.01.org, linux-api@vger.kernel.org, Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 17/17] xfs: support for synchronous DAX faults Date: Thu, 19 Oct 2017 15:17:35 +0200 [thread overview] Message-ID: <20171019131735.GC20645@lst.de> (raw) In-Reply-To: <20171019125817.11580-18-jack@suse.cz> > +#define XFS_MAP_SUPPORTED (LEGACY_MAP_MASK | MAP_SYNC) I'd kill this define. Also is there any good reason that we have to add LEGACY_MAP_MASK instead of assuming it's supported in the core? > #endif > .mmap = xfs_file_mmap, > + .mmap_supported_flags = XFS_MAP_SUPPORTED, > .open = xfs_file_open, > .release = xfs_file_release, > .fsync = xfs_file_fsync, I usually either reformat all members to be aligned again, or if that's too much churn (in this case it probably is) just use a single space before the = to minimize the alignment differences. Otherwise your changes look good to me. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Jan Kara <jack@suse.cz> Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, Ross Zwisler <ross.zwisler@linux.intel.com>, Dan Williams <dan.j.williams@intel.com>, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, Christoph Hellwig <hch@infradead.org>, linux-api@vger.kernel.org, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH 17/17] xfs: support for synchronous DAX faults Date: Thu, 19 Oct 2017 15:17:35 +0200 [thread overview] Message-ID: <20171019131735.GC20645@lst.de> (raw) In-Reply-To: <20171019125817.11580-18-jack@suse.cz> > +#define XFS_MAP_SUPPORTED (LEGACY_MAP_MASK | MAP_SYNC) I'd kill this define. Also is there any good reason that we have to add LEGACY_MAP_MASK instead of assuming it's supported in the core? > #endif > .mmap = xfs_file_mmap, > + .mmap_supported_flags = XFS_MAP_SUPPORTED, > .open = xfs_file_open, > .release = xfs_file_release, > .fsync = xfs_file_fsync, I usually either reformat all members to be aligned again, or if that's too much churn (in this case it probably is) just use a single space before the = to minimize the alignment differences. Otherwise your changes look good to me.
next prev parent reply other threads:[~2017-10-19 13:13 UTC|newest] Thread overview: 151+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-19 12:57 [PATCH 0/17 v4] dax, ext4, xfs: Synchronous page faults Jan Kara 2017-10-19 12:57 ` Jan Kara 2017-10-19 12:57 ` Jan Kara 2017-10-19 12:57 ` Jan Kara 2017-10-19 12:57 ` Jan Kara 2017-10-19 12:58 ` [PATCH 01/17] mm: introduce MAP_SHARED_VALIDATE, a mechanism to safely define new mmap flags Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 16:48 ` Dan Williams 2017-10-19 16:48 ` Dan Williams 2017-10-19 16:48 ` Dan Williams 2017-10-20 7:27 ` Christoph Hellwig 2017-10-20 7:27 ` Christoph Hellwig 2017-10-24 13:08 ` Jan Kara 2017-10-24 13:08 ` Jan Kara 2017-10-24 13:08 ` Jan Kara 2017-10-19 12:58 ` [PATCH 02/17] mm: Remove VM_FAULT_HWPOISON_LARGE_MASK Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 03/17] dax: Simplify arguments of dax_insert_mapping() Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 04/17] dax: Factor out getting of pfn out of iomap Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 05/17] dax: Create local variable for VMA in dax_iomap_pte_fault() Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 06/17] dax: Create local variable for vmf->flags & FAULT_FLAG_WRITE test Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 07/17] dax: Inline dax_insert_mapping() into the callsite Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 08/17] dax: Inline dax_pmd_insert_mapping() " Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 09/17] dax: Fix comment describing dax_iomap_fault() Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 10/17] dax: Allow dax_iomap_fault() to return pfn Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 11/17] dax: Allow tuning whether dax_insert_mapping_entry() dirties entry Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 12/17] mm: Define MAP_SYNC and VM_SYNC flags Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 13/17] dax, iomap: Add support for synchronous faults Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 14/17] dax: Implement dax_finish_sync_fault() Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 15/17] ext4: Simplify error handling in ext4_dax_huge_fault() Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 16/17] ext4: Support for synchronous DAX faults Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` [PATCH 17/17] xfs: support " Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 13:17 ` Christoph Hellwig [this message] 2017-10-19 13:17 ` Christoph Hellwig 2017-10-19 12:58 ` [PATCH] mmap.2: Add description of MAP_SHARED_VALIDATE and MAP_SYNC Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-19 12:58 ` Jan Kara 2017-10-20 21:47 ` Ross Zwisler 2017-10-20 21:47 ` Ross Zwisler 2017-10-20 21:47 ` Ross Zwisler 2017-10-24 13:27 ` Jan Kara 2017-10-24 13:27 ` Jan Kara 2017-10-24 13:27 ` Jan Kara 2017-10-24 14:55 ` Ross Zwisler 2017-10-24 14:55 ` Ross Zwisler 2017-10-24 14:55 ` Ross Zwisler 2017-10-24 15:23 [PATCH 0/17 v5] dax, ext4, xfs: Synchronous page faults Jan Kara 2017-10-24 15:24 ` [PATCH 17/17] xfs: support for synchronous DAX faults Jan Kara 2017-10-24 15:24 ` Jan Kara 2017-10-24 15:24 ` Jan Kara 2017-10-24 15:24 ` Jan Kara 2017-10-24 21:29 ` Ross Zwisler 2017-10-24 21:29 ` Ross Zwisler 2017-10-24 21:29 ` Ross Zwisler 2017-10-24 22:23 ` Dave Chinner 2017-10-24 22:23 ` Dave Chinner 2017-10-24 22:23 ` Dave Chinner 2017-10-26 15:48 ` Jan Kara 2017-10-26 15:48 ` Jan Kara 2017-10-26 15:48 ` Jan Kara 2017-10-26 15:48 ` Jan Kara 2017-10-26 21:16 ` Dave Chinner 2017-10-26 21:16 ` Dave Chinner 2017-10-26 21:16 ` Dave Chinner 2017-10-26 21:16 ` Dave Chinner 2017-10-27 10:08 ` Jan Kara 2017-10-27 10:08 ` Jan Kara 2017-10-27 10:08 ` Jan Kara 2017-10-31 15:19 ` Jan Kara 2017-10-31 15:19 ` Jan Kara 2017-10-31 15:19 ` Jan Kara 2017-10-31 15:19 ` Jan Kara 2017-10-31 21:50 ` Dan Williams 2017-10-31 21:50 ` Dan Williams 2017-10-31 21:50 ` Dan Williams 2017-10-31 21:50 ` Dan Williams 2017-11-01 3:47 ` Ross Zwisler 2017-11-01 3:47 ` Ross Zwisler 2017-11-01 3:47 ` Ross Zwisler 2017-11-01 3:47 ` Ross Zwisler 2017-10-27 6:43 ` Christoph Hellwig 2017-10-27 6:43 ` Christoph Hellwig 2017-10-27 9:13 ` Jan Kara 2017-10-27 9:13 ` Jan Kara 2017-10-27 9:13 ` Jan Kara 2017-10-27 9:13 ` Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171019131735.GC20645@lst.de \ --to=hch@lst.de \ --cc=hch@infradead.org \ --cc=jack@suse.cz \ --cc=linux-api@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=linux-xfs@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.