From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-nvdimm@lists.01.org, linux-api@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] mmap.2: Add description of MAP_SHARED_VALIDATE and MAP_SYNC
Date: Tue, 24 Oct 2017 08:55:57 -0600 [thread overview]
Message-ID: <20171024145557.GA30343@linux.intel.com> (raw)
In-Reply-To: <20171024132713.GD8556@quack2.suse.cz>
On Tue, Oct 24, 2017 at 03:27:13PM +0200, Jan Kara wrote:
> On Fri 20-10-17 15:47:53, Ross Zwisler wrote:
> > On Thu, Oct 19, 2017 at 02:58:17PM +0200, Jan Kara wrote:
> > > Signed-off-by: Jan Kara <jack@suse.cz>
> > > ---
> > > man2/mmap.2 | 30 ++++++++++++++++++++++++++++++
> > > 1 file changed, 30 insertions(+)
> > >
> > > diff --git a/man2/mmap.2 b/man2/mmap.2
> > > index 47c3148653be..598ff0c64f7f 100644
> > > --- a/man2/mmap.2
> > > +++ b/man2/mmap.2
> > > @@ -125,6 +125,21 @@ are carried through to the underlying file.
> > > to the underlying file requires the use of
> > > .BR msync (2).)
> > > .TP
> > > +.B MAP_SHARED_VALIDATE
> > > +The same as
> > > +.B MAP_SHARED
> > > +except that
> > > +.B MAP_SHARED
> > > +mappings ignore unknown flags in
> > > +.IR flags .
> > > +In contrast when creating mapping of
> > > +.B MAP_SHARED_VALIDATE
> > > +mapping type, the kernel verifies all passed flags are known and fails the
> > > +mapping with
> > > +.BR EOPNOTSUPP
> > > +otherwise. This mapping type is also required to be able to use some mapping
> > > +flags.
> > > +.TP
> >
> > Some small nits:
> >
> > I think you should maybe include a "(since Linux 4.15)" type note after the
> > MAP_SHARED_VALIDATE header. You also need to update the following line:
> >
> > Both of these flags are described in POSIX.1-2001 and POSIX.1-2008.
> >
> > Which used to refer to MAP_SYNC and MAP_PRIVATE.
>
> Thanks, I've fixed these.
Cool, you can add my:
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org,
Dan Williams <dan.j.williams@intel.com>,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-api@vger.kernel.org
Subject: Re: [PATCH] mmap.2: Add description of MAP_SHARED_VALIDATE and MAP_SYNC
Date: Tue, 24 Oct 2017 08:55:57 -0600 [thread overview]
Message-ID: <20171024145557.GA30343@linux.intel.com> (raw)
In-Reply-To: <20171024132713.GD8556@quack2.suse.cz>
On Tue, Oct 24, 2017 at 03:27:13PM +0200, Jan Kara wrote:
> On Fri 20-10-17 15:47:53, Ross Zwisler wrote:
> > On Thu, Oct 19, 2017 at 02:58:17PM +0200, Jan Kara wrote:
> > > Signed-off-by: Jan Kara <jack@suse.cz>
> > > ---
> > > man2/mmap.2 | 30 ++++++++++++++++++++++++++++++
> > > 1 file changed, 30 insertions(+)
> > >
> > > diff --git a/man2/mmap.2 b/man2/mmap.2
> > > index 47c3148653be..598ff0c64f7f 100644
> > > --- a/man2/mmap.2
> > > +++ b/man2/mmap.2
> > > @@ -125,6 +125,21 @@ are carried through to the underlying file.
> > > to the underlying file requires the use of
> > > .BR msync (2).)
> > > .TP
> > > +.B MAP_SHARED_VALIDATE
> > > +The same as
> > > +.B MAP_SHARED
> > > +except that
> > > +.B MAP_SHARED
> > > +mappings ignore unknown flags in
> > > +.IR flags .
> > > +In contrast when creating mapping of
> > > +.B MAP_SHARED_VALIDATE
> > > +mapping type, the kernel verifies all passed flags are known and fails the
> > > +mapping with
> > > +.BR EOPNOTSUPP
> > > +otherwise. This mapping type is also required to be able to use some mapping
> > > +flags.
> > > +.TP
> >
> > Some small nits:
> >
> > I think you should maybe include a "(since Linux 4.15)" type note after the
> > MAP_SHARED_VALIDATE header. You also need to update the following line:
> >
> > Both of these flags are described in POSIX.1-2001 and POSIX.1-2008.
> >
> > Which used to refer to MAP_SYNC and MAP_PRIVATE.
>
> Thanks, I've fixed these.
Cool, you can add my:
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
Cc: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mmap.2: Add description of MAP_SHARED_VALIDATE and MAP_SYNC
Date: Tue, 24 Oct 2017 08:55:57 -0600 [thread overview]
Message-ID: <20171024145557.GA30343@linux.intel.com> (raw)
In-Reply-To: <20171024132713.GD8556-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
On Tue, Oct 24, 2017 at 03:27:13PM +0200, Jan Kara wrote:
> On Fri 20-10-17 15:47:53, Ross Zwisler wrote:
> > On Thu, Oct 19, 2017 at 02:58:17PM +0200, Jan Kara wrote:
> > > Signed-off-by: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
> > > ---
> > > man2/mmap.2 | 30 ++++++++++++++++++++++++++++++
> > > 1 file changed, 30 insertions(+)
> > >
> > > diff --git a/man2/mmap.2 b/man2/mmap.2
> > > index 47c3148653be..598ff0c64f7f 100644
> > > --- a/man2/mmap.2
> > > +++ b/man2/mmap.2
> > > @@ -125,6 +125,21 @@ are carried through to the underlying file.
> > > to the underlying file requires the use of
> > > .BR msync (2).)
> > > .TP
> > > +.B MAP_SHARED_VALIDATE
> > > +The same as
> > > +.B MAP_SHARED
> > > +except that
> > > +.B MAP_SHARED
> > > +mappings ignore unknown flags in
> > > +.IR flags .
> > > +In contrast when creating mapping of
> > > +.B MAP_SHARED_VALIDATE
> > > +mapping type, the kernel verifies all passed flags are known and fails the
> > > +mapping with
> > > +.BR EOPNOTSUPP
> > > +otherwise. This mapping type is also required to be able to use some mapping
> > > +flags.
> > > +.TP
> >
> > Some small nits:
> >
> > I think you should maybe include a "(since Linux 4.15)" type note after the
> > MAP_SHARED_VALIDATE header. You also need to update the following line:
> >
> > Both of these flags are described in POSIX.1-2001 and POSIX.1-2008.
> >
> > Which used to refer to MAP_SYNC and MAP_PRIVATE.
>
> Thanks, I've fixed these.
Cool, you can add my:
Reviewed-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
next prev parent reply other threads:[~2017-10-24 14:52 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 12:57 [PATCH 0/17 v4] dax, ext4, xfs: Synchronous page faults Jan Kara
2017-10-19 12:57 ` Jan Kara
2017-10-19 12:57 ` Jan Kara
2017-10-19 12:57 ` Jan Kara
2017-10-19 12:57 ` Jan Kara
2017-10-19 12:58 ` [PATCH 01/17] mm: introduce MAP_SHARED_VALIDATE, a mechanism to safely define new mmap flags Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 16:48 ` Dan Williams
2017-10-19 16:48 ` Dan Williams
2017-10-19 16:48 ` Dan Williams
2017-10-20 7:27 ` Christoph Hellwig
2017-10-20 7:27 ` Christoph Hellwig
2017-10-24 13:08 ` Jan Kara
2017-10-24 13:08 ` Jan Kara
2017-10-24 13:08 ` Jan Kara
2017-10-19 12:58 ` [PATCH 02/17] mm: Remove VM_FAULT_HWPOISON_LARGE_MASK Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 03/17] dax: Simplify arguments of dax_insert_mapping() Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 04/17] dax: Factor out getting of pfn out of iomap Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 05/17] dax: Create local variable for VMA in dax_iomap_pte_fault() Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 06/17] dax: Create local variable for vmf->flags & FAULT_FLAG_WRITE test Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 07/17] dax: Inline dax_insert_mapping() into the callsite Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 08/17] dax: Inline dax_pmd_insert_mapping() " Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 09/17] dax: Fix comment describing dax_iomap_fault() Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 10/17] dax: Allow dax_iomap_fault() to return pfn Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 11/17] dax: Allow tuning whether dax_insert_mapping_entry() dirties entry Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 12/17] mm: Define MAP_SYNC and VM_SYNC flags Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 13/17] dax, iomap: Add support for synchronous faults Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 14/17] dax: Implement dax_finish_sync_fault() Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 15/17] ext4: Simplify error handling in ext4_dax_huge_fault() Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 16/17] ext4: Support for synchronous DAX faults Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` [PATCH 17/17] xfs: support " Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 13:17 ` Christoph Hellwig
2017-10-19 13:17 ` Christoph Hellwig
2017-10-19 12:58 ` [PATCH] mmap.2: Add description of MAP_SHARED_VALIDATE and MAP_SYNC Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-19 12:58 ` Jan Kara
2017-10-20 21:47 ` Ross Zwisler
2017-10-20 21:47 ` Ross Zwisler
2017-10-20 21:47 ` Ross Zwisler
2017-10-24 13:27 ` Jan Kara
2017-10-24 13:27 ` Jan Kara
2017-10-24 13:27 ` Jan Kara
2017-10-24 14:55 ` Ross Zwisler [this message]
2017-10-24 14:55 ` Ross Zwisler
2017-10-24 14:55 ` Ross Zwisler
2017-10-24 15:23 [PATCH 0/17 v5] dax, ext4, xfs: Synchronous page faults Jan Kara
2017-10-24 15:24 ` [PATCH] mmap.2: Add description of MAP_SHARED_VALIDATE and MAP_SYNC Jan Kara
2017-10-24 15:24 ` Jan Kara
2017-10-24 15:24 ` Jan Kara
2017-10-24 15:24 ` Jan Kara
2017-10-24 15:24 ` Jan Kara
2017-10-24 21:10 ` Ross Zwisler
2017-10-24 21:10 ` Ross Zwisler
2017-10-24 21:10 ` Ross Zwisler
2017-10-26 13:24 ` Jan Kara
2017-10-26 13:24 ` Jan Kara
2017-10-26 13:24 ` Jan Kara
2017-10-26 18:22 ` Ross Zwisler
2017-10-26 18:22 ` Ross Zwisler
2017-10-26 18:22 ` Ross Zwisler
2017-10-26 18:22 ` Ross Zwisler
2017-11-01 15:36 [PATCH 0/18 v6] dax, ext4, xfs: Synchronous page faults Jan Kara
2017-11-01 15:36 ` [PATCH] mmap.2: Add description of MAP_SHARED_VALIDATE and MAP_SYNC Jan Kara
2017-11-01 15:36 ` Jan Kara
2017-11-01 15:36 ` Jan Kara
2017-11-01 15:36 ` Jan Kara
2017-11-01 15:36 ` Jan Kara
2018-04-12 13:00 ` Michael Kerrisk (man-pages)
2018-04-12 13:00 ` Michael Kerrisk (man-pages)
2018-04-12 13:00 ` Michael Kerrisk (man-pages)
2018-04-12 14:00 ` Ross Zwisler
2018-04-12 14:00 ` Ross Zwisler
2018-04-12 14:22 ` Jan Kara
2018-04-12 14:22 ` Jan Kara
2018-04-12 14:22 ` Jan Kara
2018-04-12 18:20 ` Michael Kerrisk (man-pages)
2018-04-12 18:20 ` Michael Kerrisk (man-pages)
2018-04-12 18:20 ` Michael Kerrisk (man-pages)
2018-04-13 11:17 ` Jan Kara
2018-04-13 11:17 ` Jan Kara
2018-04-13 11:17 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024145557.GA30343@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.