From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Quan Xu <quan.xu03@gmail.com>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org, x86@kernel.org,
xen-devel@lists.xenproject.org,
Yang Zhang <yang.zhang.wz@gmail.com>,
Quan Xu <quan.xu0@gmail.com>, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
Kyle Huey <me@kylehuey.com>, Len Brown <len.brown@intel.com>,
Andy Lutomirski <luto@kernel.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
Tobias Klauser <tklauser@distanz.ch>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH RFC v3 3/6] sched/idle: Add a generic poll before enter real idle path
Date: Thu, 16 Nov 2017 09:45:55 +0100 [thread overview]
Message-ID: <20171116084555.it2hqajxxd6ld5tq@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1711152240010.2146@nanos>
On Wed, Nov 15, 2017 at 11:03:08PM +0100, Thomas Gleixner wrote:
> If I understand the problem correctly then he wants to avoid the heavy
> lifting in tick_nohz_idle_enter() in the first place, but there is already
> an interesting quirk there which makes it exit early.
Sure. And there are people who want to do the same for native.
Adding more ugly and special cases just isn't the way to go about doing
that.
I'm fairly sure I've told the various groups that want to tinker with
this to work together on this. I've also in fairly significant detail
sketched how to rework the idle code and idle predictors.
At this point I'm too tired to dig any of that up, so I'll just keep
saying no to patches that don't even attempt to go in the right
direction.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Yang Zhang <yang.zhang.wz@gmail.com>,
Len Brown <len.brown@intel.com>, Quan Xu <quan.xu0@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org,
LKML <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Kyle Huey <me@kylehuey.com>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, Quan Xu <quan.xu03@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-fsdevel@vger.kernel.org, xen-devel@lists.xenproject.org,
Tom Lendacky <thomas.lendacky@amd.com>,
Tobias Klauser <tklauser@distanz.ch>
Subject: Re: [PATCH RFC v3 3/6] sched/idle: Add a generic poll before enter real idle path
Date: Thu, 16 Nov 2017 09:45:55 +0100 [thread overview]
Message-ID: <20171116084555.it2hqajxxd6ld5tq@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1711152240010.2146@nanos>
On Wed, Nov 15, 2017 at 11:03:08PM +0100, Thomas Gleixner wrote:
> If I understand the problem correctly then he wants to avoid the heavy
> lifting in tick_nohz_idle_enter() in the first place, but there is already
> an interesting quirk there which makes it exit early.
Sure. And there are people who want to do the same for native.
Adding more ugly and special cases just isn't the way to go about doing
that.
I'm fairly sure I've told the various groups that want to tinker with
this to work together on this. I've also in fairly significant detail
sketched how to rework the idle code and idle predictors.
At this point I'm too tired to dig any of that up, so I'll just keep
saying no to patches that don't even attempt to go in the right
direction.
next prev parent reply other threads:[~2017-11-16 8:46 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 10:05 [PATCH RFC v3 0/6] x86/idle: add halt poll support Quan Xu
2017-11-13 10:06 ` [PATCH RFC v3 1/6] x86/paravirt: Add pv_idle_ops to paravirt ops Quan Xu
2017-11-13 10:53 ` Juergen Gross
2017-11-13 11:09 ` Wanpeng Li
2017-11-13 11:09 ` Wanpeng Li
2017-11-13 11:09 ` Wanpeng Li
2017-11-13 11:09 ` Wanpeng Li
2017-11-14 7:02 ` Quan Xu
2017-11-14 7:02 ` Quan Xu
2017-11-14 7:02 ` Quan Xu
2017-11-14 7:12 ` Wanpeng Li
2017-11-14 7:12 ` Wanpeng Li
2017-11-14 8:15 ` Quan Xu
2017-11-14 8:15 ` Quan Xu
2017-11-14 8:15 ` Quan Xu
2017-11-14 8:22 ` Wanpeng Li
2017-11-14 8:22 ` Wanpeng Li
2017-11-14 8:22 ` Wanpeng Li
2017-11-14 8:22 ` Wanpeng Li
2017-11-14 10:23 ` Quan Xu
2017-11-14 10:23 ` Quan Xu
2017-11-14 10:23 ` Quan Xu
2017-11-14 10:23 ` Quan Xu
2017-11-14 8:22 ` Wanpeng Li
2017-11-14 8:15 ` Quan Xu
2017-11-14 7:12 ` Wanpeng Li
2017-11-14 7:12 ` Wanpeng Li
2017-11-14 7:30 ` Juergen Gross
2017-11-14 7:30 ` Juergen Gross
2017-11-14 9:38 ` Quan Xu
2017-11-14 10:27 ` Juergen Gross
2017-11-14 11:43 ` Quan Xu
2017-11-14 11:43 ` Quan Xu
2017-11-14 11:43 ` Quan Xu
2017-11-14 11:58 ` Juergen Gross
2017-11-14 11:58 ` Juergen Gross
2017-11-14 11:58 ` Juergen Gross
2017-11-14 10:27 ` Juergen Gross
2017-11-14 10:27 ` Juergen Gross
2017-11-14 9:38 ` Quan Xu
2017-11-14 9:38 ` Quan Xu
2017-11-14 7:30 ` Juergen Gross
2017-11-13 10:53 ` Juergen Gross
2017-11-13 10:53 ` Juergen Gross
2017-11-13 10:06 ` Quan Xu
2017-11-13 10:06 ` [PATCH RFC v3 2/6] KVM guest: register kvm_idle_poll for pv_idle_ops Quan Xu
2017-11-13 10:06 ` Quan Xu
2017-11-13 10:06 ` [PATCH RFC v3 3/6] sched/idle: Add a generic poll before enter real idle path Quan Xu
2017-11-15 12:11 ` Peter Zijlstra
2017-11-15 12:11 ` Peter Zijlstra
2017-11-15 22:03 ` Thomas Gleixner
2017-11-15 22:03 ` Thomas Gleixner
2017-11-15 22:03 ` Thomas Gleixner
2017-11-16 8:45 ` Peter Zijlstra [this message]
2017-11-16 8:45 ` Peter Zijlstra
2017-11-16 8:58 ` Thomas Gleixner
2017-11-16 8:58 ` Thomas Gleixner
2017-11-16 8:58 ` Thomas Gleixner
2017-11-16 9:29 ` Quan Xu
2017-11-16 9:29 ` Quan Xu
2017-11-16 9:47 ` Thomas Gleixner
2017-11-16 9:47 ` Thomas Gleixner
2017-11-16 9:47 ` Thomas Gleixner
2017-11-16 9:29 ` Quan Xu
2017-11-16 8:45 ` Peter Zijlstra
2017-11-16 9:12 ` Quan Xu
2017-11-16 9:45 ` Daniel Lezcano
2017-11-20 7:05 ` Quan Xu
2017-11-20 7:05 ` Quan Xu
2017-11-20 18:01 ` Daniel Lezcano
2017-11-20 18:01 ` Daniel Lezcano
2017-11-20 18:01 ` Daniel Lezcano
2017-11-20 7:05 ` Quan Xu
2017-11-16 9:45 ` Daniel Lezcano
2017-11-16 9:45 ` Daniel Lezcano
2017-11-16 9:53 ` Thomas Gleixner
2017-11-16 9:53 ` Thomas Gleixner
2017-11-17 11:23 ` Quan Xu
2017-11-17 11:23 ` Quan Xu
2017-11-17 11:23 ` Quan Xu
2017-11-17 11:36 ` Thomas Gleixner
2017-11-17 11:36 ` Thomas Gleixner
2017-11-17 11:36 ` Thomas Gleixner
2017-11-17 11:36 ` Thomas Gleixner
2017-11-17 12:21 ` Quan Xu
2017-11-17 12:21 ` Quan Xu
2017-11-17 12:21 ` Quan Xu
2017-11-17 12:21 ` Quan Xu
2017-11-16 9:53 ` Thomas Gleixner
2017-11-16 9:12 ` Quan Xu
2017-11-16 9:12 ` Quan Xu
2017-11-15 12:11 ` Peter Zijlstra
2017-11-13 10:06 ` Quan Xu
2017-11-15 21:31 ` [PATCH RFC v3 0/6] x86/idle: add halt poll support Konrad Rzeszutek Wilk
2017-11-15 21:31 ` [Xen-devel] " Konrad Rzeszutek Wilk
2017-11-15 21:31 ` Konrad Rzeszutek Wilk
2017-11-20 7:18 ` Quan Xu
2017-11-20 7:18 ` Quan Xu
2017-11-20 7:18 ` Quan Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116084555.it2hqajxxd6ld5tq@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=daniel.lezcano@linaro.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=len.brown@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=me@kylehuey.com \
--cc=mingo@redhat.com \
--cc=quan.xu03@gmail.com \
--cc=quan.xu0@gmail.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tklauser@distanz.ch \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.