From: Greg KH <greg@kroah.com>
To: Timur Tabi <timur@codeaurora.org>
Cc: Sinan Kaya <okaya@codeaurora.org>,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Bjorn Helgaas <bhelgaas@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function
Date: Wed, 22 Nov 2017 15:49:59 +0100 [thread overview]
Message-ID: <20171122144959.GA8081@kroah.com> (raw)
In-Reply-To: <a443e88e-3abd-0dab-2828-9753326e8d5d@codeaurora.org>
On Wed, Nov 22, 2017 at 08:42:35AM -0600, Timur Tabi wrote:
> On 11/22/17 1:51 AM, Greg KH wrote:
> > Ick, no, why? What is wrong with removing this function as is? Don't
> > mark something as __depreciated if there are no in-kernel users, just
> > delete it and move on.
> >
> > If you have out-of-tree drivers, then yes, they can make a wrapper for
> > this function like this if they really feel the need, or they can get
> > their code merged:)
>
> Sorry, I guess I should have been clearer. My suggestion was to fix some of
> the drivers where the domain can be determined, and for the rest, just mark
> the old function as deprecated.
So the build now gets warnings? That's annoying, and then someone else
will have to make the exact same patches that were created here?
> If that's still a terrible idea, well, okay. I'm just unsure that simply
> hard-coding a 0 for the domain for some drivers is really a solution. Don't
> we really want all drivers to properly support all domains?
I bet all of those drivers don't care because they are running only in
systems with 1 domain, otherwise they would be broken today, right? But
really, it shouldn't be that hard to get to the "real" PCI device to
provide the correct pointer to the domain for most of these, as I
pointed out in one patch review already.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function
Date: Wed, 22 Nov 2017 15:49:59 +0100 [thread overview]
Message-ID: <20171122144959.GA8081@kroah.com> (raw)
In-Reply-To: <a443e88e-3abd-0dab-2828-9753326e8d5d@codeaurora.org>
On Wed, Nov 22, 2017 at 08:42:35AM -0600, Timur Tabi wrote:
> On 11/22/17 1:51 AM, Greg KH wrote:
> > Ick, no, why? What is wrong with removing this function as is? Don't
> > mark something as __depreciated if there are no in-kernel users, just
> > delete it and move on.
> >
> > If you have out-of-tree drivers, then yes, they can make a wrapper for
> > this function like this if they really feel the need, or they can get
> > their code merged:)
>
> Sorry, I guess I should have been clearer. My suggestion was to fix some of
> the drivers where the domain can be determined, and for the rest, just mark
> the old function as deprecated.
So the build now gets warnings? That's annoying, and then someone else
will have to make the exact same patches that were created here?
> If that's still a terrible idea, well, okay. I'm just unsure that simply
> hard-coding a 0 for the domain for some drivers is really a solution. Don't
> we really want all drivers to properly support all domains?
I bet all of those drivers don't care because they are running only in
systems with 1 domain, otherwise they would be broken today, right? But
really, it shouldn't be that hard to get to the "real" PCI device to
provide the correct pointer to the domain for most of these, as I
pointed out in one patch review already.
thanks,
greg k-h
next prev parent reply other threads:[~2017-11-22 14:49 UTC|newest]
Thread overview: 180+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 5:30 [PATCH 00/30] PCI: deprecate pci_get_bus_and_slot() Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 01/30] alpha/PCI: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 02/30] powerpc/PCI: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 03/30] x86/PCI: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 04/30] ata: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 05/30] agp: nvidia: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 06/30] edd: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 07/30] ibft: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 08/30] drm/gma500: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 09/30] drm/i915: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 7:52 ` Joonas Lahtinen
2017-11-22 16:28 ` Sinan Kaya
2017-11-22 19:50 ` Jani Nikula
2017-11-22 19:58 ` Timur Tabi
2017-11-23 7:14 ` Jani Nikula
2017-11-23 7:42 ` Joonas Lahtinen
2017-11-23 18:37 ` Sinan Kaya
2017-11-27 8:56 ` Joonas Lahtinen
2017-11-27 14:05 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 10/30] drm/nouveau: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 11/30] hwmon: (coretemp) " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 15:07 ` [11/30] " Guenter Roeck
2017-11-22 15:07 ` Guenter Roeck
2017-11-22 15:07 ` Guenter Roeck
2017-11-22 5:30 ` [PATCH 12/30] Drivers: ide: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 7:53 ` Greg KH
2017-11-22 7:53 ` Greg KH
2017-11-22 7:53 ` Greg KH
2017-11-22 16:24 ` Sinan Kaya
2017-11-22 16:24 ` Sinan Kaya
2017-11-22 16:24 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 13/30] iommu/amd: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 14/30] powerpc/powermac: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 15/30] bnx2x: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 16/30] pch_gbe: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 17/30] PCI: cpqhp: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 18/30] PCI: ibmphp: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 19/30] PCI/quirks: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 20/30] PCI/syscall: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 21/30] xen: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 12:53 ` Juergen Gross
2017-11-22 12:53 ` Juergen Gross
2017-11-22 12:53 ` Juergen Gross
2017-11-22 12:53 ` Juergen Gross
2017-11-22 5:31 ` [PATCH 22/30] openprom: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 23/30] [media] atomisp: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 12:20 ` Alan Cox
2017-11-22 12:20 ` Alan Cox
2017-11-22 12:20 ` Alan Cox
2017-11-22 12:20 ` Alan Cox
2017-11-22 14:05 ` Sinan Kaya
2017-11-22 14:05 ` Sinan Kaya
2017-11-22 14:05 ` Sinan Kaya
2017-11-22 14:05 ` Sinan Kaya
2017-11-22 14:06 ` Sinan Kaya
2017-11-22 14:06 ` Sinan Kaya
2017-11-22 14:06 ` Sinan Kaya
2017-11-22 14:06 ` Sinan Kaya
2017-11-22 17:00 ` Alan Cox
2017-11-22 5:31 ` [PATCH 24/30] staging: rts5208: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 7:54 ` Greg Kroah-Hartman
2017-11-22 7:54 ` Greg Kroah-Hartman
2017-11-22 5:31 ` [PATCH 25/30] backlight: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 26/30] video: fbdev: intelfb: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 27/30] video: fbdev: nvidia: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 28/30] video: fbdev: riva: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 29/30] i7300_idle: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 7:53 ` Greg Kroah-Hartman
2017-11-22 7:53 ` Greg Kroah-Hartman
2017-11-22 7:53 ` Greg Kroah-Hartman
2017-11-22 16:15 ` Sinan Kaya
2017-11-22 16:15 ` Sinan Kaya
2017-11-22 16:15 ` Sinan Kaya
2017-11-22 16:45 ` Greg Kroah-Hartman
2017-11-22 16:45 ` Greg Kroah-Hartman
2017-11-22 16:50 ` Sinan Kaya
2017-11-22 16:50 ` Sinan Kaya
2017-11-22 16:50 ` Sinan Kaya
2017-11-22 16:58 ` Greg Kroah-Hartman
2017-11-22 16:58 ` Greg Kroah-Hartman
2017-11-22 16:58 ` Greg Kroah-Hartman
2017-11-22 5:31 ` [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:45 ` Timur Tabi
2017-11-22 5:45 ` Timur Tabi
2017-11-22 5:45 ` Timur Tabi
2017-11-22 5:55 ` Sinan Kaya
2017-11-22 5:55 ` Sinan Kaya
2017-11-22 5:55 ` Sinan Kaya
2017-11-22 6:08 ` Timur Tabi
2017-11-22 6:08 ` Timur Tabi
2017-11-22 6:08 ` Timur Tabi
2017-11-22 7:51 ` Greg KH
2017-11-22 7:51 ` Greg KH
2017-11-22 7:51 ` Greg KH
2017-11-22 14:42 ` Timur Tabi
2017-11-22 14:42 ` Timur Tabi
2017-11-22 14:42 ` Timur Tabi
2017-11-22 14:49 ` Greg KH [this message]
2017-11-22 14:49 ` Greg KH
2017-11-22 15:18 ` Sinan Kaya
2017-11-22 15:18 ` Sinan Kaya
2017-11-22 15:18 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171122144959.GA8081@kroah.com \
--to=greg@kroah.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.