From: Sinan Kaya <okaya@codeaurora.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-pci@vger.kernel.org, timur@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Philippe Ombredanne <pombredanne@nexb.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 29/30] i7300_idle: deprecate pci_get_bus_and_slot()
Date: Wed, 22 Nov 2017 11:15:47 -0500 [thread overview]
Message-ID: <81de37c1-26b5-41f7-ab32-b98012890971@codeaurora.org> (raw)
In-Reply-To: <20171122075345.GC26583@kroah.com>
On 11/22/2017 2:53 AM, Greg Kroah-Hartman wrote:
>> +++ b/include/linux/i7300_idle.h
>> @@ -48,7 +48,7 @@ static inline int i7300_idle_platform_probe(struct pci_dev **fbd_dev,
>> int i;
>> struct pci_dev *memdev, *dmadev;
>>
>> - memdev = pci_get_bus_and_slot(MEMCTL_BUS, MEMCTL_DEVFN);
>> + memdev = pci_get_domain_bus_and_slot(0, MEMCTL_BUS, MEMCTL_DEVFN);
> You have a pci_dev, why can't you use it here to get the domain?
>
Both fbd_dev and ioat_dev are output parameters.
dmadev = pci_get_bus_and_slot(IOAT_BUS, IOAT_DEVFN);
memdev = pci_get_bus_and_slot(MEMCTL_BUS, MEMCTL_DEVFN);
for (i = 0; fbd_ioat_list[i].vendor != 0; i++) {
if (dmadev->vendor == fbd_ioat_list[i].vendor &&
dmadev->device == fbd_ioat_list[i].ioat_dev) {
if (!(fbd_ioat_list[i].enabled || enable_all))
continue;
if (fbd_dev)
*fbd_dev = memdev;
if (ioat_dev)
*ioat_dev = dmadev;
Funny thing is nobody is calling this function. Maybe, I should just kill it
instead.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@codeaurora.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
linux-pci@vger.kernel.org, timur@codeaurora.org,
open list <linux-kernel@vger.kernel.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
linux-arm-msm@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 29/30] i7300_idle: deprecate pci_get_bus_and_slot()
Date: Wed, 22 Nov 2017 11:15:47 -0500 [thread overview]
Message-ID: <81de37c1-26b5-41f7-ab32-b98012890971@codeaurora.org> (raw)
In-Reply-To: <20171122075345.GC26583@kroah.com>
On 11/22/2017 2:53 AM, Greg Kroah-Hartman wrote:
>> +++ b/include/linux/i7300_idle.h
>> @@ -48,7 +48,7 @@ static inline int i7300_idle_platform_probe(struct pci_dev **fbd_dev,
>> int i;
>> struct pci_dev *memdev, *dmadev;
>>
>> - memdev = pci_get_bus_and_slot(MEMCTL_BUS, MEMCTL_DEVFN);
>> + memdev = pci_get_domain_bus_and_slot(0, MEMCTL_BUS, MEMCTL_DEVFN);
> You have a pci_dev, why can't you use it here to get the domain?
>
Both fbd_dev and ioat_dev are output parameters.
dmadev = pci_get_bus_and_slot(IOAT_BUS, IOAT_DEVFN);
memdev = pci_get_bus_and_slot(MEMCTL_BUS, MEMCTL_DEVFN);
for (i = 0; fbd_ioat_list[i].vendor != 0; i++) {
if (dmadev->vendor == fbd_ioat_list[i].vendor &&
dmadev->device == fbd_ioat_list[i].ioat_dev) {
if (!(fbd_ioat_list[i].enabled || enable_all))
continue;
if (fbd_dev)
*fbd_dev = memdev;
if (ioat_dev)
*ioat_dev = dmadev;
Funny thing is nobody is calling this function. Maybe, I should just kill it
instead.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 29/30] i7300_idle: deprecate pci_get_bus_and_slot()
Date: Wed, 22 Nov 2017 11:15:47 -0500 [thread overview]
Message-ID: <81de37c1-26b5-41f7-ab32-b98012890971@codeaurora.org> (raw)
In-Reply-To: <20171122075345.GC26583@kroah.com>
On 11/22/2017 2:53 AM, Greg Kroah-Hartman wrote:
>> +++ b/include/linux/i7300_idle.h
>> @@ -48,7 +48,7 @@ static inline int i7300_idle_platform_probe(struct pci_dev **fbd_dev,
>> int i;
>> struct pci_dev *memdev, *dmadev;
>>
>> - memdev = pci_get_bus_and_slot(MEMCTL_BUS, MEMCTL_DEVFN);
>> + memdev = pci_get_domain_bus_and_slot(0, MEMCTL_BUS, MEMCTL_DEVFN);
> You have a pci_dev, why can't you use it here to get the domain?
>
Both fbd_dev and ioat_dev are output parameters.
dmadev = pci_get_bus_and_slot(IOAT_BUS, IOAT_DEVFN);
memdev = pci_get_bus_and_slot(MEMCTL_BUS, MEMCTL_DEVFN);
for (i = 0; fbd_ioat_list[i].vendor != 0; i++) {
if (dmadev->vendor == fbd_ioat_list[i].vendor &&
dmadev->device == fbd_ioat_list[i].ioat_dev) {
if (!(fbd_ioat_list[i].enabled || enable_all))
continue;
if (fbd_dev)
*fbd_dev = memdev;
if (ioat_dev)
*ioat_dev = dmadev;
Funny thing is nobody is calling this function. Maybe, I should just kill it
instead.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-11-22 16:15 UTC|newest]
Thread overview: 180+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 5:30 [PATCH 00/30] PCI: deprecate pci_get_bus_and_slot() Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 01/30] alpha/PCI: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 02/30] powerpc/PCI: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 03/30] x86/PCI: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 04/30] ata: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 05/30] agp: nvidia: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 06/30] edd: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 07/30] ibft: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 08/30] drm/gma500: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 09/30] drm/i915: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 7:52 ` Joonas Lahtinen
2017-11-22 16:28 ` Sinan Kaya
2017-11-22 19:50 ` Jani Nikula
2017-11-22 19:58 ` Timur Tabi
2017-11-23 7:14 ` Jani Nikula
2017-11-23 7:42 ` Joonas Lahtinen
2017-11-23 18:37 ` Sinan Kaya
2017-11-27 8:56 ` Joonas Lahtinen
2017-11-27 14:05 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 10/30] drm/nouveau: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 11/30] hwmon: (coretemp) " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 15:07 ` [11/30] " Guenter Roeck
2017-11-22 15:07 ` Guenter Roeck
2017-11-22 15:07 ` Guenter Roeck
2017-11-22 5:30 ` [PATCH 12/30] Drivers: ide: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 7:53 ` Greg KH
2017-11-22 7:53 ` Greg KH
2017-11-22 7:53 ` Greg KH
2017-11-22 16:24 ` Sinan Kaya
2017-11-22 16:24 ` Sinan Kaya
2017-11-22 16:24 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 13/30] iommu/amd: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` [PATCH 14/30] powerpc/powermac: " Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:30 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 15/30] bnx2x: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 16/30] pch_gbe: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 17/30] PCI: cpqhp: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 18/30] PCI: ibmphp: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 19/30] PCI/quirks: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 20/30] PCI/syscall: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 21/30] xen: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 12:53 ` Juergen Gross
2017-11-22 12:53 ` Juergen Gross
2017-11-22 12:53 ` Juergen Gross
2017-11-22 12:53 ` Juergen Gross
2017-11-22 5:31 ` [PATCH 22/30] openprom: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 23/30] [media] atomisp: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 12:20 ` Alan Cox
2017-11-22 12:20 ` Alan Cox
2017-11-22 12:20 ` Alan Cox
2017-11-22 12:20 ` Alan Cox
2017-11-22 14:05 ` Sinan Kaya
2017-11-22 14:05 ` Sinan Kaya
2017-11-22 14:05 ` Sinan Kaya
2017-11-22 14:05 ` Sinan Kaya
2017-11-22 14:06 ` Sinan Kaya
2017-11-22 14:06 ` Sinan Kaya
2017-11-22 14:06 ` Sinan Kaya
2017-11-22 14:06 ` Sinan Kaya
2017-11-22 17:00 ` Alan Cox
2017-11-22 5:31 ` [PATCH 24/30] staging: rts5208: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 7:54 ` Greg Kroah-Hartman
2017-11-22 7:54 ` Greg Kroah-Hartman
2017-11-22 5:31 ` [PATCH 25/30] backlight: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 26/30] video: fbdev: intelfb: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 27/30] video: fbdev: nvidia: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 28/30] video: fbdev: riva: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` [PATCH 29/30] i7300_idle: " Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 7:53 ` Greg Kroah-Hartman
2017-11-22 7:53 ` Greg Kroah-Hartman
2017-11-22 7:53 ` Greg Kroah-Hartman
2017-11-22 16:15 ` Sinan Kaya [this message]
2017-11-22 16:15 ` Sinan Kaya
2017-11-22 16:15 ` Sinan Kaya
2017-11-22 16:45 ` Greg Kroah-Hartman
2017-11-22 16:45 ` Greg Kroah-Hartman
2017-11-22 16:50 ` Sinan Kaya
2017-11-22 16:50 ` Sinan Kaya
2017-11-22 16:50 ` Sinan Kaya
2017-11-22 16:58 ` Greg Kroah-Hartman
2017-11-22 16:58 ` Greg Kroah-Hartman
2017-11-22 16:58 ` Greg Kroah-Hartman
2017-11-22 5:31 ` [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:31 ` Sinan Kaya
2017-11-22 5:45 ` Timur Tabi
2017-11-22 5:45 ` Timur Tabi
2017-11-22 5:45 ` Timur Tabi
2017-11-22 5:55 ` Sinan Kaya
2017-11-22 5:55 ` Sinan Kaya
2017-11-22 5:55 ` Sinan Kaya
2017-11-22 6:08 ` Timur Tabi
2017-11-22 6:08 ` Timur Tabi
2017-11-22 6:08 ` Timur Tabi
2017-11-22 7:51 ` Greg KH
2017-11-22 7:51 ` Greg KH
2017-11-22 7:51 ` Greg KH
2017-11-22 14:42 ` Timur Tabi
2017-11-22 14:42 ` Timur Tabi
2017-11-22 14:42 ` Timur Tabi
2017-11-22 14:49 ` Greg KH
2017-11-22 14:49 ` Greg KH
2017-11-22 15:18 ` Sinan Kaya
2017-11-22 15:18 ` Sinan Kaya
2017-11-22 15:18 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81de37c1-26b5-41f7-ab32-b98012890971@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.