All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Russell King <linux@armlinux.org.uk>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Nishanth Menon <nm@ti.com>
Subject: [PATCH 3/8] ARM: dts: keystone: Get rid of usage of skeleton.dtsi
Date: Fri, 15 Dec 2017 07:20:57 -0600	[thread overview]
Message-ID: <20171215132102.435-4-nm@ti.com> (raw)
In-Reply-To: <20171215132102.435-1-nm@ti.com>

skeleton.dtsi does'nt offer us any real benefits with most of the
parameters being overriden. So, just drop the same entirely and
introduce appropriate changes for chosen node and memory back to
our top level definition.

This also squashes the following warnings with W=1:

arch/arm/boot/dts/keystone-k2hk-evm.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
arch/arm/boot/dts/keystone-k2l-evm.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
arch/arm/boot/dts/keystone-k2e-evm.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

Reported-by: Rob Herring <robh@kernel.org>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
 arch/arm/boot/dts/keystone.dtsi | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index 0e8d094515cc..01496910587a 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -6,8 +6,6 @@
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/gpio/gpio.h>
 
-#include "skeleton.dtsi"
-
 / {
 	compatible = "ti,keystone";
 	model = "Texas Instruments Keystone 2 SoC";
@@ -22,7 +20,10 @@
 		spi2 = &spi2;
 	};
 
-	memory {
+	chosen { };
+
+	memory: memory@80000000 {
+		device_type = "memory";
 		reg = <0x00000000 0x80000000 0x00000000 0x40000000>;
 	};
 
-- 
2.14.1

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
To: Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Santosh Shilimkar
	<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
Subject: [PATCH 3/8] ARM: dts: keystone: Get rid of usage of skeleton.dtsi
Date: Fri, 15 Dec 2017 07:20:57 -0600	[thread overview]
Message-ID: <20171215132102.435-4-nm@ti.com> (raw)
In-Reply-To: <20171215132102.435-1-nm-l0cyMroinI0@public.gmane.org>

skeleton.dtsi does'nt offer us any real benefits with most of the
parameters being overriden. So, just drop the same entirely and
introduce appropriate changes for chosen node and memory back to
our top level definition.

This also squashes the following warnings with W=1:

arch/arm/boot/dts/keystone-k2hk-evm.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
arch/arm/boot/dts/keystone-k2l-evm.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
arch/arm/boot/dts/keystone-k2e-evm.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

Reported-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Signed-off-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
---
 arch/arm/boot/dts/keystone.dtsi | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index 0e8d094515cc..01496910587a 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -6,8 +6,6 @@
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/gpio/gpio.h>
 
-#include "skeleton.dtsi"
-
 / {
 	compatible = "ti,keystone";
 	model = "Texas Instruments Keystone 2 SoC";
@@ -22,7 +20,10 @@
 		spi2 = &spi2;
 	};
 
-	memory {
+	chosen { };
+
+	memory: memory@80000000 {
+		device_type = "memory";
 		reg = <0x00000000 0x80000000 0x00000000 0x40000000>;
 	};
 
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/8] ARM: dts: keystone: Get rid of usage of skeleton.dtsi
Date: Fri, 15 Dec 2017 07:20:57 -0600	[thread overview]
Message-ID: <20171215132102.435-4-nm@ti.com> (raw)
In-Reply-To: <20171215132102.435-1-nm@ti.com>

skeleton.dtsi does'nt offer us any real benefits with most of the
parameters being overriden. So, just drop the same entirely and
introduce appropriate changes for chosen node and memory back to
our top level definition.

This also squashes the following warnings with W=1:

arch/arm/boot/dts/keystone-k2hk-evm.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
arch/arm/boot/dts/keystone-k2l-evm.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
arch/arm/boot/dts/keystone-k2e-evm.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

Reported-by: Rob Herring <robh@kernel.org>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
 arch/arm/boot/dts/keystone.dtsi | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index 0e8d094515cc..01496910587a 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -6,8 +6,6 @@
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/gpio/gpio.h>
 
-#include "skeleton.dtsi"
-
 / {
 	compatible = "ti,keystone";
 	model = "Texas Instruments Keystone 2 SoC";
@@ -22,7 +20,10 @@
 		spi2 = &spi2;
 	};
 
-	memory {
+	chosen { };
+
+	memory: memory at 80000000 {
+		device_type = "memory";
 		reg = <0x00000000 0x80000000 0x00000000 0x40000000>;
 	};
 
-- 
2.14.1

  parent reply	other threads:[~2017-12-15 13:22 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15 13:20 [PATCH 0/8] ARM: dts: keystone*: Stage 1 cleanup for W=1 Nishanth Menon
2017-12-15 13:20 ` Nishanth Menon
2017-12-15 13:20 ` Nishanth Menon
2017-12-15 13:20 ` [PATCH 1/8] ARM: dts: keystone*: Standardize license with SPDX tag Nishanth Menon
2017-12-15 13:20   ` Nishanth Menon
2017-12-15 13:20   ` Nishanth Menon
2017-12-15 13:20 ` [PATCH 2/8] ARM: dts: keystone*: Use a single soc0 instance Nishanth Menon
2017-12-15 13:20   ` Nishanth Menon
2017-12-15 13:20   ` Nishanth Menon
2017-12-15 13:38   ` Nishanth Menon
2017-12-15 13:38     ` Nishanth Menon
2017-12-15 13:38     ` Nishanth Menon
2017-12-16  8:33     ` santosh.shilimkar
2017-12-16  8:33       ` santosh.shilimkar at oracle.com
2017-12-16  8:33       ` santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA
2017-12-15 13:20 ` Nishanth Menon [this message]
2017-12-15 13:20   ` [PATCH 3/8] ARM: dts: keystone: Get rid of usage of skeleton.dtsi Nishanth Menon
2017-12-15 13:20   ` Nishanth Menon
2017-12-15 13:20 ` [PATCH 4/8] ARM: dts: keystone: Add missing unit name to interrupt controller Nishanth Menon
2017-12-15 13:20   ` Nishanth Menon
2017-12-15 13:20   ` Nishanth Menon
2017-12-15 13:20 ` [PATCH 5/8] ARM: dts: keystone-clocks: Add missing unit name to clock nodes that have regs Nishanth Menon
2017-12-15 13:20   ` Nishanth Menon
2017-12-15 13:20   ` Nishanth Menon
2017-12-15 13:21 ` [PATCH 6/8] ARM: dts: keystone-hk-clocks: " Nishanth Menon
2017-12-15 13:21   ` Nishanth Menon
2017-12-15 13:21   ` Nishanth Menon
2017-12-15 13:21 ` [PATCH 7/8] ARM: dts: keystone-k2e-clocks: " Nishanth Menon
2017-12-15 13:21   ` Nishanth Menon
2017-12-15 13:21   ` Nishanth Menon
2017-12-15 13:21 ` [PATCH 8/8] ARM: dts: keystone-k2l-clocks: " Nishanth Menon
2017-12-15 13:21   ` Nishanth Menon
2017-12-15 13:21   ` Nishanth Menon
2017-12-16 20:40 ` [PATCH V2 0/8] ARM: dts: keystone*: Stage 1 cleanup for W=1 Nishanth Menon
2017-12-16 20:40   ` Nishanth Menon
2017-12-16 20:40   ` Nishanth Menon
2017-12-16 20:40   ` [PATCH V2 1/8] ARM: dts: keystone*: Standardize license with SPDX tag Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40   ` [PATCH V2 2/8] ARM: dts: keystone*: Use a single soc0 instance Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40   ` [PATCH V2 3/8] ARM: dts: keystone: Get rid of usage of skeleton.dtsi Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40   ` [PATCH V2 4/8] ARM: dts: keystone: Add missing unit name to interrupt controller Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40   ` [PATCH V2 5/8] ARM: dts: keystone-clocks: Add missing unit name to clock nodes that have regs Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40   ` [PATCH V2 6/8] ARM: dts: keystone-hk-clocks: " Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40   ` [PATCH V2 7/8] ARM: dts: keystone-k2e-clocks: " Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40   ` [PATCH V2 8/8] ARM: dts: keystone-k2l-clocks: " Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 20:40     ` Nishanth Menon
2017-12-16 22:39   ` [PATCH V2 0/8] ARM: dts: keystone*: Stage 1 cleanup for W=1 santosh.shilimkar
2017-12-16 22:39     ` santosh.shilimkar at oracle.com
2017-12-16 22:39     ` santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171215132102.435-4-nm@ti.com \
    --to=nm@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.