From: Tony Lindgren <tony@atomide.com>
To: Maciej Purski <m.purski@samsung.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Carlos Hernandez <ceh@ti.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] regulator: core: Pass max_uV value to regulator_set_voltage_rdev
Date: Mon, 2 Jul 2018 01:05:05 -0700 [thread overview]
Message-ID: <20180702080505.GN112168@atomide.com> (raw)
In-Reply-To: <1529330913-11152-1-git-send-email-m.purski@samsung.com>
* Maciej Purski <m.purski@samsung.com> [180618 14:11]:
> If the regulator is not coupled, balance_voltage() should preserve
> its desired max uV, instead of setting the exact value like in
> coupled regulators case.
>
> Remove debugs, which are not necessary for now.
Sorry for the delay in testing. I gave your series with this one
a quick boot test on beagleboard-x15 and now the output is
different. So instead of just hanging it seems to be stuck in
some eternal loop see below.
Regards,
Tony
8< -------
* Loading modules ...[ 14.490595] omap-mailbox 48840000.mailbox: omap mailbox rev 0x400
[ 14.498515] omap-mailbox 48842000.mailbox: omap mailbox rev 0x400
[ 14.535853] omap_wdt: OMAP Watchdog Timer Rev 0x01: initial timeout 60 sec
[ 14.937029] lib80211: common routines for IEEE802.11 drivers
[ 15.350565] cfg80211: Loading compiled-in X.509 certificates for regulatory database
[ 15.448875] cfg80211: Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
[ 15.460831] platform regulatory.0: Direct firmware load for regulatory.db failed with error -2
[ 15.469916] cfg80211: failed to load regulatory.db
[ 16.092151] cpu cpu0: regulator_set_voltage: 3387
[ 16.097313] smps12: regulator_set_voltage_unlocked: 3040
[ 16.109880] smps12: optimal uV: 1154000 current uV: 970000, max uV: 1250000
[ 16.117085] smps12: regulator_set_voltage_rdev: 3110
[ 16.122696] smps12: _regulator_do_set_voltage: 2907
[ 16.130443] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.137824] smps12: regulator_set_voltage_rdev: 3110
[ 16.143334] smps12: _regulator_do_set_voltage: 2907
[ 16.149849] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.157174] smps12: regulator_set_voltage_rdev: 3110
[ 16.162683] smps12: _regulator_do_set_voltage: 2907
[ 16.169069] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.176391] smps12: regulator_set_voltage_rdev: 3110
[ 16.181932] smps12: _regulator_do_set_voltage: 2907
[ 16.188353] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.195614] smps12: regulator_set_voltage_rdev: 3110
[ 16.201199] smps12: _regulator_do_set_voltage: 2907
[ 16.207676] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.214931] smps12: regulator_set_voltage_rdev: 3110
[ 16.220614] smps12: _regulator_do_set_voltage: 2907
[ 16.227159] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.234379] smps12: regulator_set_voltage_rdev: 3110
[ 16.239961] smps12: _regulator_do_set_voltage: 2907
[ 16.246494] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.253746] smps12: regulator_set_voltage_rdev: 3110
[ 16.259890] smps12: _regulator_do_set_voltage: 2907
[ 16.267013] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.274114] smps12: regulator_set_voltage_rdev: 3110
[ 16.279565] smps12: _regulator_do_set_voltage: 2907
[ 16.288426] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.295562] smps12: regulator_set_voltage_rdev: 3110
[ 16.301580] smps12: _regulator_do_set_voltage: 2907
[ 16.308331] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.315655] smps12: regulator_set_voltage_rdev: 3110
[ 16.321328] smps12: _regulator_do_set_voltage: 2907
[ 16.327686] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.334945] smps12: regulator_set_voltage_rdev: 3110
[ 16.340662] smps12: _regulator_do_set_voltage: 2907
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] regulator: core: Pass max_uV value to regulator_set_voltage_rdev
Date: Mon, 2 Jul 2018 01:05:05 -0700 [thread overview]
Message-ID: <20180702080505.GN112168@atomide.com> (raw)
In-Reply-To: <1529330913-11152-1-git-send-email-m.purski@samsung.com>
* Maciej Purski <m.purski@samsung.com> [180618 14:11]:
> If the regulator is not coupled, balance_voltage() should preserve
> its desired max uV, instead of setting the exact value like in
> coupled regulators case.
>
> Remove debugs, which are not necessary for now.
Sorry for the delay in testing. I gave your series with this one
a quick boot test on beagleboard-x15 and now the output is
different. So instead of just hanging it seems to be stuck in
some eternal loop see below.
Regards,
Tony
8< -------
* Loading modules ...[ 14.490595] omap-mailbox 48840000.mailbox: omap mailbox rev 0x400
[ 14.498515] omap-mailbox 48842000.mailbox: omap mailbox rev 0x400
[ 14.535853] omap_wdt: OMAP Watchdog Timer Rev 0x01: initial timeout 60 sec
[ 14.937029] lib80211: common routines for IEEE802.11 drivers
[ 15.350565] cfg80211: Loading compiled-in X.509 certificates for regulatory database
[ 15.448875] cfg80211: Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
[ 15.460831] platform regulatory.0: Direct firmware load for regulatory.db failed with error -2
[ 15.469916] cfg80211: failed to load regulatory.db
[ 16.092151] cpu cpu0: regulator_set_voltage: 3387
[ 16.097313] smps12: regulator_set_voltage_unlocked: 3040
[ 16.109880] smps12: optimal uV: 1154000 current uV: 970000, max uV: 1250000
[ 16.117085] smps12: regulator_set_voltage_rdev: 3110
[ 16.122696] smps12: _regulator_do_set_voltage: 2907
[ 16.130443] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.137824] smps12: regulator_set_voltage_rdev: 3110
[ 16.143334] smps12: _regulator_do_set_voltage: 2907
[ 16.149849] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.157174] smps12: regulator_set_voltage_rdev: 3110
[ 16.162683] smps12: _regulator_do_set_voltage: 2907
[ 16.169069] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.176391] smps12: regulator_set_voltage_rdev: 3110
[ 16.181932] smps12: _regulator_do_set_voltage: 2907
[ 16.188353] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.195614] smps12: regulator_set_voltage_rdev: 3110
[ 16.201199] smps12: _regulator_do_set_voltage: 2907
[ 16.207676] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.214931] smps12: regulator_set_voltage_rdev: 3110
[ 16.220614] smps12: _regulator_do_set_voltage: 2907
[ 16.227159] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.234379] smps12: regulator_set_voltage_rdev: 3110
[ 16.239961] smps12: _regulator_do_set_voltage: 2907
[ 16.246494] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.253746] smps12: regulator_set_voltage_rdev: 3110
[ 16.259890] smps12: _regulator_do_set_voltage: 2907
[ 16.267013] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.274114] smps12: regulator_set_voltage_rdev: 3110
[ 16.279565] smps12: _regulator_do_set_voltage: 2907
[ 16.288426] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.295562] smps12: regulator_set_voltage_rdev: 3110
[ 16.301580] smps12: _regulator_do_set_voltage: 2907
[ 16.308331] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.315655] smps12: regulator_set_voltage_rdev: 3110
[ 16.321328] smps12: _regulator_do_set_voltage: 2907
[ 16.327686] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000
[ 16.334945] smps12: regulator_set_voltage_rdev: 3110
[ 16.340662] smps12: _regulator_do_set_voltage: 2907
next prev parent reply other threads:[~2018-07-02 8:05 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 22:15 Regression in Linux next again Tony Lindgren
2018-05-29 22:15 ` Tony Lindgren
2018-05-30 9:13 ` Mark Brown
2018-05-30 9:13 ` Mark Brown
2018-05-30 14:03 ` Maciej Purski
2018-05-30 14:03 ` Maciej Purski
2018-05-30 14:33 ` Mark Brown
2018-05-30 14:33 ` Mark Brown
2018-05-30 14:45 ` Tony Lindgren
2018-05-30 14:45 ` Tony Lindgren
[not found] ` <CGME20180604135952eucas1p292f7bcec405e6a1a6261031df36cad32@eucas1p2.samsung.com>
2018-06-04 13:59 ` Maciej Purski
2018-06-04 13:59 ` Maciej Purski
[not found] ` <CGME20180604135952eucas1p2d76b6aa5d8fc9912113d519b48f7e99a@eucas1p2.samsung.com>
2018-06-04 13:59 ` [PATCH 1/7] regulator: core: Add debug messages Maciej Purski
2018-06-04 13:59 ` Maciej Purski
[not found] ` <CGME20180604135952eucas1p2e3fdb68bf31e32b7c9557051671885a9@eucas1p2.samsung.com>
2018-06-04 13:59 ` [PATCH 2/7] regulator: core: Add regulator_set_voltage_rdev() Maciej Purski
2018-06-04 13:59 ` Maciej Purski
[not found] ` <CGME20180604135953eucas1p2f2c9dd9581cd114d323c3d64afe5c308@eucas1p2.samsung.com>
2018-06-04 13:59 ` [PATCH 3/7] regulator: core: Use re-entrant locks Maciej Purski
2018-06-04 13:59 ` Maciej Purski
[not found] ` <CGME20180604135953eucas1p2ec281df0793bc73e79f3000837abcb04@eucas1p2.samsung.com>
2018-06-04 13:59 ` [PATCH 4/7] regulator: core: Implement voltage balancing algorithm Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 13:59 ` Maciej Purski
[not found] ` <CGME20180604135954eucas1p2156fed3300b5514a4efa2baf9e7b9bc5@eucas1p2.samsung.com>
2018-06-04 13:59 ` [PATCH 5/7] regulator: core: Lock dependent regulators Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 14:20 ` Lucas Stach
2018-06-04 14:20 ` Lucas Stach
2018-06-18 12:37 ` Maciej Purski
2018-06-18 12:37 ` Maciej Purski
[not found] ` <CGME20180604135954eucas1p2eeb77ada3ca97fecc6caec20d7e8397a@eucas1p2.samsung.com>
2018-06-04 13:59 ` [PATCH 6/7] regulator: core: Lock dependent regulators on regulator_enable() Maciej Purski
2018-06-04 13:59 ` Maciej Purski
[not found] ` <CGME20180604135954eucas1p2bebd1c4970401bb957da228056f9a662@eucas1p2.samsung.com>
2018-06-04 13:59 ` [PATCH 7/7] regulator: core: Enable voltage balancing Maciej Purski
2018-06-04 13:59 ` Maciej Purski
2018-06-04 23:13 ` kbuild test robot
2018-06-04 23:13 ` kbuild test robot
2018-06-04 23:13 ` kbuild test robot
2018-06-04 23:54 ` kbuild test robot
2018-06-04 23:54 ` kbuild test robot
2018-06-04 23:54 ` kbuild test robot
2018-06-05 4:45 ` Regression in Linux next again Tony Lindgren
2018-06-05 4:45 ` Tony Lindgren
[not found] ` <CGME20180613103622eucas1p1778ba2c2e5dd85ccb4c488bd0a38386d@eucas1p1.samsung.com>
2018-06-13 10:33 ` [PATCH v2] regulator: core: Enable voltage balancing Maciej Purski
2018-06-13 10:33 ` Maciej Purski
2018-06-15 11:29 ` Tony Lindgren
2018-06-15 11:29 ` Tony Lindgren
2018-06-18 13:17 ` Maciej Purski
2018-06-18 13:17 ` Maciej Purski
[not found] ` <CGME20180618140856eucas1p281619f9bf003655a3c2eac356216ab25@eucas1p2.samsung.com>
2018-06-18 14:08 ` [PATCH] regulator: core: Pass max_uV value to regulator_set_voltage_rdev Maciej Purski
2018-06-18 14:08 ` Maciej Purski
2018-07-02 8:05 ` Tony Lindgren [this message]
2018-07-02 8:05 ` Tony Lindgren
2018-09-28 20:09 ` Dmitry Osipenko
2018-09-28 20:09 ` Dmitry Osipenko
2018-09-28 20:09 ` Dmitry Osipenko
2018-09-28 20:09 ` Dmitry Osipenko
2018-09-28 20:22 ` Tony Lindgren
2018-09-28 20:22 ` Tony Lindgren
2018-09-28 20:36 ` Dmitry Osipenko
2018-09-28 20:36 ` Dmitry Osipenko
2018-09-28 22:26 ` Dmitry Osipenko
2018-09-28 22:26 ` Dmitry Osipenko
2018-09-28 22:26 ` Dmitry Osipenko
2018-09-28 22:41 ` Tony Lindgren
2018-09-28 22:41 ` Tony Lindgren
2018-09-28 23:17 ` Dmitry Osipenko
2018-09-28 23:17 ` Dmitry Osipenko
2018-09-28 23:17 ` Dmitry Osipenko
2018-09-28 23:51 ` Dmitry Osipenko
2018-09-28 23:51 ` Dmitry Osipenko
2018-09-28 23:51 ` Dmitry Osipenko
2018-09-29 0:27 ` Tony Lindgren
2018-09-29 0:27 ` Tony Lindgren
2018-09-29 0:44 ` Dmitry Osipenko
2018-09-29 0:44 ` Dmitry Osipenko
2018-10-01 7:25 ` Maciej Purski
2018-10-01 7:25 ` Maciej Purski
2018-10-01 13:34 ` Dmitry Osipenko
2018-10-01 13:34 ` Dmitry Osipenko
2018-05-30 14:53 ` Regression in Linux next again Naresh Kamboju
2018-05-30 14:53 ` Naresh Kamboju
2018-05-31 5:44 ` Naresh Kamboju
2018-05-31 5:44 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702080505.GN112168@atomide.com \
--to=tony@atomide.com \
--cc=broonie@kernel.org \
--cc=ceh@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m.purski@samsung.com \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.