From: Lee Jones <lee.jones@linaro.org> To: Tony Xie <tony.xie@rock-chips.com> Cc: heiko@sntech.de, broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, chenjh@rock-chips.com, xsf@rock-chips.com, zhangqing@rock-chips.com, huangtao@rock-chips.com Subject: Re: [PATCH v3 3/5] dt-bindings: mfd: rk808: Add binding information for RK809 and RK817. Date: Tue, 11 Sep 2018 13:37:19 +0100 [thread overview] Message-ID: <20180911123719.GM4185@dell> (raw) In-Reply-To: <1535081441-20718-4-git-send-email-tony.xie@rock-chips.com> On Fri, 24 Aug 2018, Tony Xie wrote: > Add device tree bindings documentation for Rockchip's RK809 & RK817 PMIC. > > Signed-off-by: Tony Xie <tony.xie@rock-chips.com> > --- > Documentation/devicetree/bindings/mfd/rk808.txt | 56 +++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt > index 91b6522..c025a99 100644 > --- a/Documentation/devicetree/bindings/mfd/rk808.txt > +++ b/Documentation/devicetree/bindings/mfd/rk808.txt > @@ -3,11 +3,15 @@ RK8XX Power Management Integrated Circuit > The rk8xx family current members: > rk805 > rk808 > +rk809 > +rk817 > rk818 > > Required properties: > - compatible: "rockchip,rk805" > - compatible: "rockchip,rk808" > +- compatible: "rockchip,rk809" > +- compatible: "rockchip,rk817" > - compatible: "rockchip,rk818" > - reg: I2C slave address > - interrupt-parent: The parent interrupt controller. > @@ -46,6 +50,28 @@ Optional RK808 properties: > the gpio controller. If DVS GPIOs aren't present, voltage changes will happen > very quickly with no slow ramp time. > > +Optional RK809 properties: > +- vcc1-supply: The input supply for DCDC_REG1 > +- vcc2-supply: The input supply for DCDC_REG2 > +- vcc3-supply: The input supply for DCDC_REG3 > +- vcc4-supply: The input supply for DCDC_REG4 > +- vcc5-supply: The input supply for LDO_REG1, LDO_REG2, LDO_REG3 > +- vcc6-supply: The input supply for LDO_REG4, LDO_REG5, LDO_REG6 > +- vcc7-supply: The input supply for LDO_REG7, LDO_REG8, LDO_REG9 > +- vcc8-supply: The input supply for SWITCH_REG1 > +- vcc9-supply: The input supply for DCDC_REG5, SWITCH_REG2 > + > +Optional RK817 properties: > +- vcc1-supply: The input supply for DCDC_REG1 > +- vcc2-supply: The input supply for DCDC_REG2 > +- vcc3-supply: The input supply for DCDC_REG3 > +- vcc4-supply: The input supply for DCDC_REG4 > +- vcc5-supply: The input supply for LDO_REG1, LDO_REG2, LDO_REG3 > +- vcc6-supply: The input supply for LDO_REG4, LDO_REG5, LDO_REG6 > +- vcc7-supply: The input supply for LDO_REG7, LDO_REG8, LDO_REG9 > +- vcc8-supply: The input supply for BOOST > +- vcc9-supply: The input supply for OTG_SWITCH I think I'd like to see these squashed down a bit. Something like: > +Optional shared RK809 and RK817 properties: > +- vcc1-supply: The input supply for DCDC_REG1 > +- vcc2-supply: The input supply for DCDC_REG2 > +- vcc3-supply: The input supply for DCDC_REG3 > +- vcc4-supply: The input supply for DCDC_REG4 > +- vcc5-supply: The input supply for LDO_REG1, LDO_REG2, LDO_REG3 > +- vcc6-supply: The input supply for LDO_REG4, LDO_REG5, LDO_REG6 > +- vcc7-supply: The input supply for LDO_REG7, LDO_REG8, LDO_REG9 > + > +Optional RK809 properties: > +- vcc8-supply: The input supply for SWITCH_REG1 > +- vcc9-supply: The input supply for DCDC_REG5, SWITCH_REG2 > + > +Optional RK817 properties: > +- vcc8-supply: The input supply for BOOST > +- vcc9-supply: The input supply for OTG_SWITCH That's if 1-7 are as identical as they look at first glance. > Optional RK818 properties: > - vcc1-supply: The input supply for DCDC_REG1 > - vcc2-supply: The input supply for DCDC_REG2 > @@ -87,6 +113,28 @@ number as described in RK808 datasheet. > - SWITCH_REGn > - valid values for n are 1 to 2 > > +Following regulators of the RK809 PMIC block are supported. Note that > +the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO > +number as described in RK808 datasheet. > + > + - DCDC_REGn > + - valid values for n are 1 to 5. > + - LDO_REGn > + - valid values for n are 1 to 9. > + - SWITCH_REGn > + - valid values for n are 1 to 2. > + > +Following regulators of the RK817 PMIC block are supported. Note that > +the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO > +number as described in RK818 datasheet. Is there any need to keep saying the same thing over and over? Especially for something fairly obvious. > + - DCDC_REGn > + - valid values for n are 1 to 4. > + - LDO_REGn > + - valid values for n are 1 to 9. > + - BOOST > + - OTG_SWITCH > + > Following regulators of the RK818 PMIC block are supported. Note that > the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO > number as described in RK818 datasheet. > @@ -99,6 +147,14 @@ number as described in RK818 datasheet. > - HDMI_SWITCH > - OTG_SWITCH > > +There are three pins needed to config for each of RK809 and RK817, > +named "gpio_ts" "gpio_gt" "gpio_slp". > + The gpio_gt and gpio_ts pins support the gpio function. > + The gpio_slp pin is for controlling the pmic states, as below: > + - reset > + - power down > + - sleep > + > Standard regulator bindings are used inside regulator subnodes. Check > Documentation/devicetree/bindings/regulator/regulator.txt > for more details -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 3/5] dt-bindings: mfd: rk808: Add binding information for RK809 and RK817. Date: Tue, 11 Sep 2018 13:37:19 +0100 [thread overview] Message-ID: <20180911123719.GM4185@dell> (raw) In-Reply-To: <1535081441-20718-4-git-send-email-tony.xie@rock-chips.com> On Fri, 24 Aug 2018, Tony Xie wrote: > Add device tree bindings documentation for Rockchip's RK809 & RK817 PMIC. > > Signed-off-by: Tony Xie <tony.xie@rock-chips.com> > --- > Documentation/devicetree/bindings/mfd/rk808.txt | 56 +++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt > index 91b6522..c025a99 100644 > --- a/Documentation/devicetree/bindings/mfd/rk808.txt > +++ b/Documentation/devicetree/bindings/mfd/rk808.txt > @@ -3,11 +3,15 @@ RK8XX Power Management Integrated Circuit > The rk8xx family current members: > rk805 > rk808 > +rk809 > +rk817 > rk818 > > Required properties: > - compatible: "rockchip,rk805" > - compatible: "rockchip,rk808" > +- compatible: "rockchip,rk809" > +- compatible: "rockchip,rk817" > - compatible: "rockchip,rk818" > - reg: I2C slave address > - interrupt-parent: The parent interrupt controller. > @@ -46,6 +50,28 @@ Optional RK808 properties: > the gpio controller. If DVS GPIOs aren't present, voltage changes will happen > very quickly with no slow ramp time. > > +Optional RK809 properties: > +- vcc1-supply: The input supply for DCDC_REG1 > +- vcc2-supply: The input supply for DCDC_REG2 > +- vcc3-supply: The input supply for DCDC_REG3 > +- vcc4-supply: The input supply for DCDC_REG4 > +- vcc5-supply: The input supply for LDO_REG1, LDO_REG2, LDO_REG3 > +- vcc6-supply: The input supply for LDO_REG4, LDO_REG5, LDO_REG6 > +- vcc7-supply: The input supply for LDO_REG7, LDO_REG8, LDO_REG9 > +- vcc8-supply: The input supply for SWITCH_REG1 > +- vcc9-supply: The input supply for DCDC_REG5, SWITCH_REG2 > + > +Optional RK817 properties: > +- vcc1-supply: The input supply for DCDC_REG1 > +- vcc2-supply: The input supply for DCDC_REG2 > +- vcc3-supply: The input supply for DCDC_REG3 > +- vcc4-supply: The input supply for DCDC_REG4 > +- vcc5-supply: The input supply for LDO_REG1, LDO_REG2, LDO_REG3 > +- vcc6-supply: The input supply for LDO_REG4, LDO_REG5, LDO_REG6 > +- vcc7-supply: The input supply for LDO_REG7, LDO_REG8, LDO_REG9 > +- vcc8-supply: The input supply for BOOST > +- vcc9-supply: The input supply for OTG_SWITCH I think I'd like to see these squashed down a bit. Something like: > +Optional shared RK809 and RK817 properties: > +- vcc1-supply: The input supply for DCDC_REG1 > +- vcc2-supply: The input supply for DCDC_REG2 > +- vcc3-supply: The input supply for DCDC_REG3 > +- vcc4-supply: The input supply for DCDC_REG4 > +- vcc5-supply: The input supply for LDO_REG1, LDO_REG2, LDO_REG3 > +- vcc6-supply: The input supply for LDO_REG4, LDO_REG5, LDO_REG6 > +- vcc7-supply: The input supply for LDO_REG7, LDO_REG8, LDO_REG9 > + > +Optional RK809 properties: > +- vcc8-supply: The input supply for SWITCH_REG1 > +- vcc9-supply: The input supply for DCDC_REG5, SWITCH_REG2 > + > +Optional RK817 properties: > +- vcc8-supply: The input supply for BOOST > +- vcc9-supply: The input supply for OTG_SWITCH That's if 1-7 are as identical as they look at first glance. > Optional RK818 properties: > - vcc1-supply: The input supply for DCDC_REG1 > - vcc2-supply: The input supply for DCDC_REG2 > @@ -87,6 +113,28 @@ number as described in RK808 datasheet. > - SWITCH_REGn > - valid values for n are 1 to 2 > > +Following regulators of the RK809 PMIC block are supported. Note that > +the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO > +number as described in RK808 datasheet. > + > + - DCDC_REGn > + - valid values for n are 1 to 5. > + - LDO_REGn > + - valid values for n are 1 to 9. > + - SWITCH_REGn > + - valid values for n are 1 to 2. > + > +Following regulators of the RK817 PMIC block are supported. Note that > +the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO > +number as described in RK818 datasheet. Is there any need to keep saying the same thing over and over? Especially for something fairly obvious. > + - DCDC_REGn > + - valid values for n are 1 to 4. > + - LDO_REGn > + - valid values for n are 1 to 9. > + - BOOST > + - OTG_SWITCH > + > Following regulators of the RK818 PMIC block are supported. Note that > the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO > number as described in RK818 datasheet. > @@ -99,6 +147,14 @@ number as described in RK818 datasheet. > - HDMI_SWITCH > - OTG_SWITCH > > +There are three pins needed to config for each of RK809 and RK817, > +named "gpio_ts" "gpio_gt" "gpio_slp". > + The gpio_gt and gpio_ts pins support the gpio function. > + The gpio_slp pin is for controlling the pmic states, as below: > + - reset > + - power down > + - sleep > + > Standard regulator bindings are used inside regulator subnodes. Check > Documentation/devicetree/bindings/regulator/regulator.txt > for more details -- Lee Jones [???] Linaro Services Technical Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-09-11 12:37 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-24 3:30 [PATCH v3 0/5] support a new type of PMIC,including two chips(rk817 and rk809) Tony Xie 2018-08-24 3:30 ` [PATCH v3 0/5] support a new type of PMIC, including " Tony Xie 2018-08-24 3:30 ` [PATCH v3 1/5] mfd: rk808: Add RK817 and RK809 support Tony Xie 2018-08-24 3:30 ` Tony Xie 2018-09-11 11:47 ` Lee Jones 2018-09-11 11:47 ` Lee Jones 2018-10-23 3:12 ` tony 2018-10-23 3:12 ` tony 2018-10-23 3:12 ` tony 2018-10-23 6:26 ` Lee Jones 2018-10-23 6:26 ` Lee Jones 2018-10-23 7:21 ` tony 2018-10-23 7:21 ` tony 2018-08-24 3:30 ` [PATCH v3 2/5] regulator: rk808: add RK809 and RK817 support Tony Xie 2018-08-24 3:30 ` Tony Xie 2018-08-24 12:23 ` Wadim Egorov 2018-08-24 12:23 ` Wadim Egorov 2018-09-03 8:52 ` tony1 2018-08-24 3:30 ` [PATCH v3 3/5] dt-bindings: mfd: rk808: Add binding information for RK809 and RK817 Tony Xie 2018-08-24 3:30 ` Tony Xie 2018-08-28 22:40 ` Rob Herring 2018-08-28 22:40 ` Rob Herring 2018-08-28 22:40 ` Rob Herring 2018-09-11 12:37 ` Lee Jones [this message] 2018-09-11 12:37 ` Lee Jones 2018-08-24 3:30 ` [PATCH v3 4/5] rtc: rk808: add RK809 and RK817 support Tony Xie 2018-08-24 3:30 ` Tony Xie 2018-08-27 21:14 ` Alexandre Belloni 2018-08-27 21:14 ` Alexandre Belloni 2018-08-24 3:35 ` Tony Xie 2018-08-24 3:35 ` Tony Xie 2018-08-24 3:36 ` [PATCH v3 5/5] clk: RK808: " Tony Xie 2018-08-24 3:36 ` Tony Xie 2018-08-31 17:34 ` Stephen Boyd 2018-08-31 17:34 ` Stephen Boyd 2018-08-31 17:34 ` Stephen Boyd 2018-08-31 17:34 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180911123719.GM4185@dell \ --to=lee.jones@linaro.org \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=broonie@kernel.org \ --cc=chenjh@rock-chips.com \ --cc=devicetree@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=huangtao@rock-chips.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-rtc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=tony.xie@rock-chips.com \ --cc=xsf@rock-chips.com \ --cc=zhangqing@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.