From: Lee Jones <lee.jones@linaro.org> To: tony <tony.xie@rock-chips.com> Cc: heiko@sntech.de, broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, chenjh@rock-chips.com, xsf@rock-chips.com, zhangqing@rock-chips.com, huangtao@rock-chips.com Subject: Re: [PATCH v3 1/5] mfd: rk808: Add RK817 and RK809 support Date: Tue, 23 Oct 2018 07:26:01 +0100 [thread overview] Message-ID: <20181023062601.GS4939@dell> (raw) In-Reply-To: <b0f9fff3-3084-91b3-fa78-5163ebd43bbb@rock-chips.com> > > > The rk809 and rk817 are a Power Management IC (PMIC) for multimedia > > > and handheld devices. It contains the following components: > > > > > > - Regulators > > > - RTC > > > - Clocking > > > > > > Both RK809 and RK817 chips are using a similar register map, > > > so we can reuse the RTC and Clocking and regulators functionality. > > > > > > Signed-off-by: Tony Xie <tony.xie@rock-chips.com> > > > --- > > > drivers/mfd/Kconfig | 6 +- > > > drivers/mfd/rk808.c | 218 +++++++++++++++++++++++++++++++++++++++++++++- > > > include/linux/mfd/rk808.h | 172 ++++++++++++++++++++++++++++++++++++ > > > kernel/reboot.c | 1 + > > > 4 files changed, 391 insertions(+), 6 deletions(-) [...] > > > diff --git a/kernel/reboot.c b/kernel/reboot.c > > > index e4ced88..83810d7 100644 > > > --- a/kernel/reboot.c > > > +++ b/kernel/reboot.c > > > @@ -49,6 +49,7 @@ > > > */ > > > void (*pm_power_off_prepare)(void); > > > +EXPORT_SYMBOL_GPL(pm_power_off_prepare); > > Why do you need this where no other driver in the kernel does? > There is a gpio_slp pin for RK809 and RK817,this pin has reset、power > down and sleep functions,so > when system is going to power down, this pin is needed to switch to > power down function,and then we just only control > this pin to high to power down the system in atf at last。 There are other PM call-backs that you can use for this. There shouldn't be any requirement to export and call functions at this level directly. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/5] mfd: rk808: Add RK817 and RK809 support Date: Tue, 23 Oct 2018 07:26:01 +0100 [thread overview] Message-ID: <20181023062601.GS4939@dell> (raw) In-Reply-To: <b0f9fff3-3084-91b3-fa78-5163ebd43bbb@rock-chips.com> > > > The rk809 and rk817 are a Power Management IC (PMIC) for multimedia > > > and handheld devices. It contains the following components: > > > > > > - Regulators > > > - RTC > > > - Clocking > > > > > > Both RK809 and RK817 chips are using a similar register map, > > > so we can reuse the RTC and Clocking and regulators functionality. > > > > > > Signed-off-by: Tony Xie <tony.xie@rock-chips.com> > > > --- > > > drivers/mfd/Kconfig | 6 +- > > > drivers/mfd/rk808.c | 218 +++++++++++++++++++++++++++++++++++++++++++++- > > > include/linux/mfd/rk808.h | 172 ++++++++++++++++++++++++++++++++++++ > > > kernel/reboot.c | 1 + > > > 4 files changed, 391 insertions(+), 6 deletions(-) [...] > > > diff --git a/kernel/reboot.c b/kernel/reboot.c > > > index e4ced88..83810d7 100644 > > > --- a/kernel/reboot.c > > > +++ b/kernel/reboot.c > > > @@ -49,6 +49,7 @@ > > > */ > > > void (*pm_power_off_prepare)(void); > > > +EXPORT_SYMBOL_GPL(pm_power_off_prepare); > > Why do you need this where no other driver in the kernel does? > ??? There is a gpio_slp pin for RK809 and RK817?this pin has reset?power > down and sleep functions?so > ??? when system is going to power down, this pin is needed to switch to > power down function?and then we just only control > ??? this pin to high to power down the system in atf at last? There are other PM call-backs that you can use for this. There shouldn't be any requirement to export and call functions at this level directly. -- Lee Jones [???] Linaro Services Technical Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-10-23 6:26 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-24 3:30 [PATCH v3 0/5] support a new type of PMIC,including two chips(rk817 and rk809) Tony Xie 2018-08-24 3:30 ` [PATCH v3 0/5] support a new type of PMIC, including " Tony Xie 2018-08-24 3:30 ` [PATCH v3 1/5] mfd: rk808: Add RK817 and RK809 support Tony Xie 2018-08-24 3:30 ` Tony Xie 2018-09-11 11:47 ` Lee Jones 2018-09-11 11:47 ` Lee Jones 2018-10-23 3:12 ` tony 2018-10-23 3:12 ` tony 2018-10-23 3:12 ` tony 2018-10-23 6:26 ` Lee Jones [this message] 2018-10-23 6:26 ` Lee Jones 2018-10-23 7:21 ` tony 2018-10-23 7:21 ` tony 2018-08-24 3:30 ` [PATCH v3 2/5] regulator: rk808: add RK809 and RK817 support Tony Xie 2018-08-24 3:30 ` Tony Xie 2018-08-24 12:23 ` Wadim Egorov 2018-08-24 12:23 ` Wadim Egorov 2018-09-03 8:52 ` tony1 2018-08-24 3:30 ` [PATCH v3 3/5] dt-bindings: mfd: rk808: Add binding information for RK809 and RK817 Tony Xie 2018-08-24 3:30 ` Tony Xie 2018-08-28 22:40 ` Rob Herring 2018-08-28 22:40 ` Rob Herring 2018-08-28 22:40 ` Rob Herring 2018-09-11 12:37 ` Lee Jones 2018-09-11 12:37 ` Lee Jones 2018-08-24 3:30 ` [PATCH v3 4/5] rtc: rk808: add RK809 and RK817 support Tony Xie 2018-08-24 3:30 ` Tony Xie 2018-08-27 21:14 ` Alexandre Belloni 2018-08-27 21:14 ` Alexandre Belloni 2018-08-24 3:35 ` Tony Xie 2018-08-24 3:35 ` Tony Xie 2018-08-24 3:36 ` [PATCH v3 5/5] clk: RK808: " Tony Xie 2018-08-24 3:36 ` Tony Xie 2018-08-31 17:34 ` Stephen Boyd 2018-08-31 17:34 ` Stephen Boyd 2018-08-31 17:34 ` Stephen Boyd 2018-08-31 17:34 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181023062601.GS4939@dell \ --to=lee.jones@linaro.org \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=broonie@kernel.org \ --cc=chenjh@rock-chips.com \ --cc=devicetree@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=huangtao@rock-chips.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-rtc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=tony.xie@rock-chips.com \ --cc=xsf@rock-chips.com \ --cc=zhangqing@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.